Re: Issue 3648 in reviewboard: rbt post of committed code not supported for Perforce

2014-12-11 Thread reviewboard

Updates:
Status: SetupIssue

Comment #3 on issue 3648 by trowb...@gmail.com: rbt post of committed code  
not supported for Perforce

https://code.google.com/p/reviewboard/issues/detail?id=3648

I believe the issue is just that your p4 command-line client is too old.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3648 in reviewboard: rbt post of committed code not supported for Perforce

2014-11-13 Thread reviewboard


Comment #2 on issue 3648 by gavin.d@gmail.com: rbt post of committed  
code not supported for Perforce

https://code.google.com/p/reviewboard/issues/detail?id=3648

Yes I'm using Perforce client Rev. P4/NTX86/2010.1/251161 (2010/06/16).

I understand that the initial call to p4.change will return the status as  
pending or submitted, and that when it's submitted there is different  
logic. However I don't understand p4.filelog('//...@%s,%s' % (real_base,  
tip)) because a revision range syntax cannot be used for a changelist  
number.


I think the correct syntax should be something like this which specifies a  
changelist number:

p4 filelog -c822657 -m1 //...

Thanks.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3648 in reviewboard: rbt post of committed code not supported for Perforce

2014-10-30 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 3648 by trowb...@gmail.com: rbt post of committed code  
not supported for Perforce

https://code.google.com/p/reviewboard/issues/detail?id=3648

This should definitely work correctly. One quick question--do you have a  
perforce client?


Can you clarify what you mean by "doesn't look right for this scenario"?  
We've definitely tested posting submitted changelists.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.