Re: Issue 3755 in reviewboard: rbtools post command ignores --update flag
Updates: Status: Fixed Comment #5 on issue 3755 by trowb...@gmail.com: rbtools post command ignores --update flag https://code.google.com/p/reviewboard/issues/detail?id=3755 Fixed in release-0.7.x (94301f5). This will ship in 0.7.4. Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3755 in reviewboard: rbtools post command ignores --update flag
Comment #3 on issue 3755 by jonathan...@gmail.com: rbtools post command ignores --update flag https://code.google.com/p/reviewboard/issues/detail?id=3755 rbt post -u has always popped up with the review to update, and I type "yes" and everything works great. I don't always use --diff-filename but I have to whenever working with UTF-16 files. SVN does not handle UTF-16 line endings correctly and generates broken-looking diffs. But git-svn generates correct diffs, so I have to manually break them with this workflow: 1. rbt diff > patch 2. format-svn-diff.sh patch 3. rbt post --diff-filename patch format-svn-diff.sh is a script I wrote that copies UTF-16 files to an SVN working directory, generates an SVN diff, and then copies the result back into the patch. I would love if rbtools could handle all this automatically, but I don't expect y'all to workaround someone else's bug. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3755 in reviewboard: rbtools post command ignores --update flag
Comment #2 on issue 3755 by chip...@gmail.com: rbtools post command ignores --update flag https://code.google.com/p/reviewboard/issues/detail?id=3755 A related question: Why are you needing to use --diff-filename in the first place? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3755 in reviewboard: rbtools post command ignores --update flag
Updates: Status: NeedInfo Comment #1 on issue 3755 by chip...@gmail.com: rbtools post command ignores --update flag https://code.google.com/p/reviewboard/issues/detail?id=3755 Hi Jonathan, How was it performing before? -u should not have been compatible with --diff-filename (and in fact, we were just talking here about how it should display an error when using both). -u is based on the contents of the HEAD commit in the repository, whereas --diff-filename is meant to bypass using contents from the repository and instead trusting the information you provide on the command line. We never anticipated people would be using both at once. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
