Re: Issue 489 in reviewboard: [ ] DON'T SHIP IT button
Comment #43 on issue 489 by csipak.a...@ardinsys.eu: [ ] DON'T SHIP IT button https://code.google.com/p/reviewboard/issues/detail?id=489 @pvgodd: looks like this issue got forgotten. Last time it was touched by a project member, it was bound to the 1.8 milestone (after it was repeatedly postponed through every big version milestonse earlier). 1.8 never came, version number went straight to 2.0, which didn't contain the new feature. It is also missing from the release notes of 2.5 Beta 1. BTW, there's another feature request targeting the ship it function, but in a less complicated manner, see issue 3462. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 489 in reviewboard: [ ] DON'T SHIP IT button
Comment #44 on issue 489 by trowb...@gmail.com: [ ] DON'T SHIP IT button https://code.google.com/p/reviewboard/issues/detail?id=489 It's not forgotten, just that this is a relatively tricky thing (literally everyone has an opinion about how ship-its should be improved/changed and whatever we do has to be very carefully thought out) and we have fairly limited resources. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 489 in reviewboard: [ ] DON'T SHIP IT button
Comment #42 on issue 489 by pvgodd...@gmail.com: [ ] DON'T SHIP IT button https://code.google.com/p/reviewboard/issues/detail?id=489 Are there any known plugins for this feature available / is this this feature still under consideration? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 489 in reviewboard: [ ] DON'T SHIP IT button
Comment #40 on issue 489 by trowb...@gmail.com: [ ] DON'T SHIP IT button http://code.google.com/p/reviewboard/issues/detail?id=489 Issue 3219 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 489 in reviewboard: [ ] DON'T SHIP IT button
Comment #38 on issue 489 by pvgodd...@gmail.com: [ ] DON'T SHIP IT button http://code.google.com/p/reviewboard/issues/detail?id=489 Good to see this is finally accepted. For our organization it would be important this 'hold it' 'sink it' toggle to be available through the api. Our workflow for illustration purposes: Our svn repository has contains lists of authorized reviewers for certain areas of the code base (developers who know at least a bit about that section of code). To be able to commit to these areas we have a svn precommit hook to check if the commit is authorized by any of these reviewers. due to the size of the project there are often more then one on many parts of the code. Currently we check reviewboard if there is a 'ship-it' by a appropriate person if it is the commit is allowed. (else its refused). The reason we need the hold it is because from time to time one of the reviewers reviews it and fails to find a bug present in the review and check the 'ship it'. if another reviewer finds a bug in the review before its committed (or wants to contest the entire commit somehow) there is currently no way (except email / messages) to prevent the commit. in our case a commit would always be blocked as long as there is at least one hold-it present. (it would basically used as a veto system) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 489 in reviewboard: [ ] DON'T SHIP IT button
Comment #37 on issue 489 by ke...@keithmoyer.com: [ ] DON'T SHIP IT button http://code.google.com/p/reviewboard/issues/detail?id=489 For what it's worth, this situation would be handled fine if there were a # of Open Issues column on the dashboard. When someone else does a Ship It! and I disagree, I simply post a review with comments/issues. The Review Requester will be paying close enough attention to the review to know this information, but members of Review Groups would benefit from seeing Oh hey, there's a ship it on this _and_ open issues, so there's some possible disagreement. Maybe I should weigh in. We've made it clear in our (commercial, btw) organization that some random person's Ship It! is not sufficient for you to check in your code. You have to get the Ship It! from the _right people_, and you need to give sufficient time for other people to chime in (even if you get a Ship It! immediately). There are a lot of different use-cases of people using ReviewBoard, but adding another approval state Hold It/Sink It would only add confusion (I have a couple of comments that need to be addressed, do I need to Hold It? Only when someone else has Ship It?). And, the presence of open issues already means it's not ready (If they're not relevant, mark them dropped - otherwise, you need to fix them). I would expect to get negative feedback from the people using the tool here if Sink It/Hold It were to appear (but, we could deal with it). My $0.02 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 489 in reviewboard: [ ] DON'T SHIP IT button
Comment #33 on issue 489 by narf1...@gmail.com: [ ] DON'T SHIP IT button http://code.google.com/p/reviewboard/issues/detail?id=489 All the discussion above highlights a very nice enhancement, but I just thought to put down what I've been doing as a possible work around. In order for code being valid for shipping it needs x no of Ship It!'s and no open issues. For example: Dev A comes along and says Ship It!, but then Dev B finds a problem and opens and issue. Because there are still issues open, the Ship It! is not valid and simply comments on the fact that Dev A found it ok to go. This prevents code from being shipped despite someone having clicked Ship It!. A delete 'Ship It!' would still be nice for accidental clicks, and it would be cool to see the no of open issues on the dashboard. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 489 in reviewboard: [ ] DON'T SHIP IT button
Comment #31 on issue 489 by bela.lub...@gmail.com: [ ] DON'T SHIP IT button http://code.google.com/p/reviewboard/issues/detail?id=489 [Hold] is good. Per-reviewer flag, can be cleared by anyone (leaving a paper trail). Any further semantic process needs to be handled by humans once the review has gotten into this sort of exception state. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 489 in reviewboard: [ ] DON'T SHIP IT button
Comment #30 on issue 489 by whwalk...@gmail.com: [ ] DON'T SHIP IT button http://code.google.com/p/reviewboard/issues/detail?id=489 My preference would be to add a Hold button. This would be a generic indicator that could be used for any review to flag at a high level that something is amiss. Comments should accompany the indication detailing why a hold was being requested such as I want to review but need more time, Issue below on line xxx needs discussion, or I think another solution is needed. The semantics of how this flag is used could be defined by the organization. There will also need to be a process to release the Hold. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 489 in reviewboard: [ ] DON'T SHIP IT button
Comment #29 on issue 489 by mike.d.c...@gmail.com: [ ] DON'T SHIP IT button http://code.google.com/p/reviewboard/issues/detail?id=489 How about instead of Ship It, Don't Ship It, we use +1 / 0 / -1? Examples: I've just finished reviewing some code, and I feel it's not exactly ready for the prime time. I put in my final comments regarding the review request, and then give the review request a -1. Back in the Dashboard (or while viewing the review request), I can see that the current revision for this review request has a field in the table showing: 0 / -1 meaning that there are no +1's, and a single -1. Another reviewer has a different opinion, however, and after their review, they give a +1. So now, in the Dashboard I see that the latest revision for this review request displays a score of +1 / -1. A third reviewer comes in, and agrees with me, so now we see: +1 / -2. The reviewee modifies their review request. A new revision is uploaded, so the score is now reset at 0 / 0. Note that a reviewer can also mark a review with 0, in the event that they have I know that there was some concern that this would turn into a vote. I'm pretty sure the Ship It is already a vote though. There's just no way to vote the other way. Thoughts? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 489 in reviewboard: [ ] DON'T SHIP IT button
Comment #22 on issue 489 by Jan.Koprowski: [ ] DON'T SHIP IT button http://code.google.com/p/reviewboard/issues/detail?id=489 Basis of problem is in differences between OpenSource and commerical reviewing model. RB support OpenSource review model from nature. When I need update some informations in bug track I made this like this: * When RB is submitted I update issue - review ok * When RB comment is published I check Ship It and: * When checked I don't do anything * When unchecked I update issue - review rejected Of course Ship It is stricly OpenSource function which doesn't have sens in commercial model but I think my idea is fine. Submitted and Ship It - good for Open Source model Submitted and Rejected - good for commercial model -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 489 in reviewboard: [ ] DON'T SHIP IT button
Comment #24 on issue 489 by bernard3000: [ ] DON'T SHIP IT button http://code.google.com/p/reviewboard/issues/detail?id=489 I do not understand very well your point. How is reviewing different between a commercial model versus an open source model? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 489 in reviewboard: [ ] DON'T SHIP IT button
Comment #25 on issue 489 by Jan.Koprowski: [ ] DON'T SHIP IT button http://code.google.com/p/reviewboard/issues/detail?id=489 This is complex issue. Reasons of this difference come from variety of reviews occur in Open Source. In open source review system people send various requests. One will be submit, other will be discard. There is also something like community which can rate (ship it) idea. In commercial You get client. Only client advance ideas, fixes, features. Before implementing each of them was discussed with architects, payed (by client), approved by project leader and they MUST be implemented. When developer send code to review there is almost no option to discard or delete change. Submiting is the ultimate purpose - always. There is no need to rate this code they are acceptable or not. There is no opportunity to discard review because they only need improvement. Commercial review have very quasistate workflow Submit/Reject nothing more. No discard, no ship it, no sink it, no dammit ranking cause this code only need improvement - nothing more. They can't be discarded because client want it and payed this code. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
