Re: RBTools Ticket #4973: rbt patch - SVN - failing with "a bytes-like object is required, not 'str'"

2022-08-15 Thread Christian Hammond 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4973/
--

New update by rpowell
For Beanbag, Inc. > RBTools > Ticket #4973


Reply:

Fixed in 14b3b248cc9c079453fde5df43db755f2cd90b3a. This will go into 3.1.2 
and 4.0.


Status:
- Confirmed
+ Fixed

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20220816021217.16339.74480%40ip-10-1-54-209.ec2.internal.

Re: RBTools Ticket #4973: rbt patch - SVN - failing with "a bytes-like object is required, not 'str'"

2022-08-15 Thread Christian Hammond 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4973/
--

New update by rpowell
For Beanbag, Inc. > RBTools > Ticket #4973


Reply:

We'll get this into 3.1.2. Thanks!


Status:
- New
+ Confirmed


Assigned to:
+ chipx86

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20220815213111.16335.90874%40ip-10-1-54-209.ec2.internal.

Re: RBTools Ticket #4973: rbt patch - SVN - failing with "a bytes-like object is required, not 'str'"

2022-08-11 Thread Robert Powell 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4973/
--

New update by rpowell
For Beanbag, Inc. > RBTools > Ticket #4973


Reply:

I can confirm that works.

$ rbt --version
RBTools 3.1.1 (Python 3.8.10)

before:
```
$ rbt patch 269521
Applying 1 patch from review request 269521 (diff revision 17)

CRITICAL: a bytes-like object is required, not 'str'
```

With change:
```
$ diff 
/home/bpowell/.local/lib/python3.8/site-packages/rbtools/clients/svn.py 
/home/bpowell/.local/lib/python3.8/site-packages/rbtools/clients/svn.py_orig
1117,1119c1117
< rc, patch_output = self._run_svn(cmd,
<  return_error_code=True,
<  results_unicode=False)
---
> rc, patch_output = self._run_svn(cmd, return_error_code=True)
```

patch applies without error

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20220812015007.25046.16943%40ip-10-1-54-209.ec2.internal.

Re: RBTools Ticket #4973: rbt patch - SVN - failing with "a bytes-like object is required, not 'str'"

2022-08-08 Thread D J 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4973/
--

New update by rpowell
For Beanbag, Inc. > RBTools > Ticket #4973


Reply:

Trying again:

```
diff --git a/rbtools/clients/svn.py b/rbtools/clients/svn.py
index e6c6e02..5dae3ec 100644
--- a/rbtools/clients/svn.py
+++ b/rbtools/clients/svn.py
@@ -1114,7 +1114,9 @@ class SVNClient(SCMClient):
 
 cmd.append(six.text_type(patch_file))
 
-rc, patch_output = self._run_svn(cmd, return_error_code=True)
+rc, patch_output = self._run_svn(cmd,
+ return_error_code=True,
+ results_unicode=False)
 
 if self.supports_empty_files():
 try:

```

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20220809035828.28969.94597%40ip-10-1-54-209.ec2.internal.

Re: RBTools Ticket #4973: rbt patch - SVN - failing with "a bytes-like object is required, not 'str'"

2022-06-14 Thread Robert Powell 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4973/
--

New update by rpowell
For Beanbag, Inc. > RBTools > Ticket #4973


Reply:

posted review: https://reviews.reviewboard.org/r/12372/

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20220615021310.15762.36044%40ip-10-1-54-209.ec2.internal.

Re: RBTools Ticket #4973: rbt patch - SVN - failing with "a bytes-like object is required, not 'str'"

2022-06-14 Thread Robert Powell 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4973/
--

New update by rpowell
For Beanbag, Inc. > RBTools > Ticket #4973


Summary:
- rbt patch - SVN
+ rbt patch - SVN - failing with "a bytes-like object is required, not 
'str'"

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20220615012928.15762.66351%40ip-10-1-54-209.ec2.internal.