Re: Review Board Ticket #4444: Diff Logic Misses Completely Changed Line

[David Walsh]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets//
--

New update by davidwalsh
For Beanbag, Inc. > Review Board > Ticket #


Reply:

@glob : Yes, that's incredibly useful!

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4444: Diff Logic Misses Completely Changed Line

[glob]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets//
--

New update by davidwalsh
For Beanbag, Inc. > Review Board > Ticket #


Reply:

github's side-by-side view makes these sorts of changes crystal clear, imho 
without making the overall experience worse.


Files:
- Screenshot 2016-07-26 15.45.50.png
  

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4444: Diff Logic Misses Completely Changed Line

[Christian Hammond]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets//
--

New update by davidwalsh
For Beanbag, Inc. > Review Board > Ticket #


Reply:

We'll probably want to keep the entire line yellow. It's how other diff 
viewers work, and how Review Board has worked its entire life, so changing that 
would be very disruptive. Making the whole line darker when we can't find a few 
characters that change would also make the entire line's text a bit harder to 
read, and nearby replace lines with only segments changing would blend in too 
much. The current worst-case scenario behavior (keeping the whole line in 
yellow) is at least still consistent with traditional diff viewers.

I think we'll want to keep this as-is for now, but we'll keep the 
suggestions in mind.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4444: Diff Logic Misses Completely Changed Line

[glob]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets//
--

New update by davidwalsh
For Beanbag, Inc. > Review Board > Ticket #


Reply:

another option would be to not highlight an entire line unless the entire 
line has changed.
ie. "few character" changes would have a while background, with just the 
modified characters highlighted with a yellow background.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4444: Diff Logic Misses Completely Changed Line

[Botond Ballo]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets//
--

New update by davidwalsh
For Beanbag, Inc. > Review Board > Ticket #


Reply:

I have a very simple suggestion that doesn't seem to make the overall 
experience worse: when the entire line has changed, choose the darker yellow as 
the highlight color for the entire line.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4444: Diff Logic Misses Completely Changed Line

[David Trowbridge]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets//
--

New update by davidwalsh
For Beanbag, Inc. > Review Board > Ticket #


Reply:

The point of the small character highlights is to call out cases where only 
a few characters have changed, which are otherwise very difficult to spot. In 
the case where the entire line has changed, we don't want to overload the 
screen with the darker background because of the reduced contrast.

In your screenshot, you've managed to find the edge case in this behavior, 
which is where most of the changes are very small but one is not. In this case 
it's probably less than optimal, but it's definitely not "missing" the line 
(it's highlighted in yellow, indicating that the line has changed).

Unfortunately, we can't do much about this without making the overall 
experience worse for the general case.


Status:
- New
+ NotABug

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.