Hi,all
My RB version is 1.0.5.1. There is a scenario:
Local CVS Repository has many files, When I use the post-review,
It will not support --revision-range option, Because different file in
CVS Repository will have different revision-range values.
So I had tried to generate diff
Sorry, I finally tracked down the issue. There was a bug in our auth
backend that was throwing an exception, but inside the djblets code, it
was silently catching and ignoring all exceptions from custom auth
backends. I temporarily removed that catch and I was able to track down
the cause of the
I'm using SVN version 1.6.9.
On Feb 24, 9:51 pm, Christian Hammond chip...@chipx86.com wrote:
Hmm, hard to say. I'm able to do that with svn v1.3.1. Which version are you
using?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc.
This is the simplest patch:
261,262c261,262
self.rb_user = None
self.rb_pass = None
---
self.rb_user = options.http_username
self.rb_pass = options.http_password
2639a2640,2646
parser.add_option(--http-username,
dest=http_username,
Failed to execute command: ['svn', 'diff', '--diff-cmd=diff',
'file:///
srv/svn/fred/@10', 'file:///srv/svn/fred/@11', '', '', '']
It's the three empty strings (last 3 params) that are causing
problems.
svn diff file:///srv/svn/fred/@10 file:///srv/svn/fred/@11 '' '' ''
svn: Target lists to
I created an enhancement request
http://code.google.com/p/reviewboard/issues/detail?id=1514
with an attached patch. First ever patch so be kind!
On Feb 25, 7:43 am, Stodge sto...@gmail.com wrote:
This is the simplest patch:
261,262c261,262
self.rb_user = None
self.rb_pass
This patch might help:
--- ORIGINAL-svn-hook-postcommit-review 2010-02-25 08:50:07.0
-0500
+++ svn-hook-postcommit-review 2010-02-25 08:49:41.0 -0500
@@ -216,6 +216,9 @@
# common arguments
args = [repository_url, username, password, publish,
submitas,
This might be a better patch:
--- ORIGINAL-svn-hook-postcommit-review 2010-02-25 08:50:07.0
-0500
+++ svn-hook-postcommit-review 2010-02-25 09:09:40.0 -0500
@@ -221,6 +221,9 @@
if len(reviewid) == 0:
args += [summary, description, bugs]
+# Filter out blank
Ah, the one time I didn't check the commit history.
Thanks, fixes the problem!
Regards,
Florian
2010/2/24 Christian Hammond chip...@chipx86.com
Hi,
This is fixed in the nightlies. It'll be included in beta 2.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -
FYI: I ran an older version of post-review on the same code and it
uploaded just fine.
I easy_install -U rbtools and ran post-review -r # and it failed
w/ the UnicodeDecodeError.
Again, the files post-review is having a hard time with use the
default encoding of Visual Studio 2008.
After running
On Thursday 25 February 2010 01:55:42 Pv wrote:
I am pretty sure this aborts in RBTools itself before it ever gets to
the server.
Again, a manual upload of the diff file to the server works fine.
Could http://reviews.reviewboard.org/r/1298/ have caused this?
Regards,
Thilo
--
Want to help
Yes, I just commented that out and the upload was successful.
Pv
On Feb 25, 12:25 pm, Thilo-Alexander Ginkel th...@ginkel.com
wrote:
On Thursday 25 February 2010 01:55:42 Pv wrote:
I am pretty sure this aborts in RBTools itself before it ever gets to
the server.
Again, a manual upload of
It should have been:
return content_type, content.encode('utf-8', 'ignore')
Pv
On Feb 25, 12:43 pm, Pv p...@swooby.com wrote:
Yes, I just commented that out and the upload was successful.
Pv
On Feb 25, 12:25 pm, Thilo-Alexander Ginkel th...@ginkel.com
wrote:
On Thursday 25
Actually, that doesn't work either.
This stuff has always blown my mind a bit:
s = 'La Pe\xf1a'
print s
La Pe±a
s.encode('utf8')
Traceback (most recent call last):
File stdin, line 1, in module
UnicodeDecodeError: 'ascii' codec can't decode byte 0xf1 in position
5: ordinal not
Sorry for the poor formatting (couldn't find how to edit the previous
post):
s = 'La Pe\xf1a'
print s
La Pe±a
s.encode('utf8')
Traceback (most recent call last):
File stdin, line 1, in module
UnicodeDecodeError: 'ascii' codec can't decode byte 0xf1 in position
5: ordinal not in
Agreed, we need to do that.
In general, I recommend installing on Linux, which we have more experience
with and our dependencies are more actively tested on. This can be done in a
VM or something, if need be.
I'm really hoping we can get a proper Win32 installer in time. We need
someone to
Although I haven't really used the product yet, I can see you're doing
a great job. Thanks you.
If I get this to work, I will be happy to share the configuration and
dependencies I've used. Even upload them somewhere.
Even if it's just a bunch of installed, not bundled into one, I am
sure it would
Did anyone find a solution to this problem? This error shows up once
in a while in our configuration as well. RB errors out due to
following problem
UnicodeDecodeError: 'utf8' codec can't decode byte 0x92 in position
716: unexpected code byte
Ronak
On Jan 9, 6:36 pm, Christian Hammond
update:
Found this post by Christian:
http://www.mail-archive.com/reviewboard@googlegroups.com/msg02417.html
which suggest using pysvn v 1.6.3.
SVN repo now shows in the new review request. No errors in log!
Continuing with testing ...
On Feb 26, 12:26 pm, danielc co.dan...@gmail.com wrote:
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1513 by sylvain.desodt: Update diff : Error: Saving the form
failed due to a server error: 0 n/a
http://code.google.com/p/reviewboard/issues/detail?id=1513
*NOTE: Do not post confidential information in this bug report.*
Status: New
Owner:
Labels: Type-Enhancement Priority-Medium
New issue 1514 by stodge: post-review.py doesn't allow parameters for http
username/password
http://code.google.com/p/reviewboard/issues/detail?id=1514
*NOTE: If you have a patch, please submit it to http://reviews.review-
Comment #1 on issue 1514 by stodge: post-review.py doesn't allow parameters
for http username/password
http://code.google.com/p/reviewboard/issues/detail?id=1514
Sorry - attached the wrong patch. Here's the correct one.
Attachments:
post-review.patch 1.1 KB
--
You received this
Comment #3 on issue 1359 by fiddur: Diff fails for text file with non-ascii
characters
http://code.google.com/p/reviewboard/issues/detail?id=1359
Actually, that wasn't such a good idea after all; the diff was accepted but
could not
be applied :P
Adding this to sitecustomize.py was
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1515 by stodge: SVN hook can include empty arguments which seems
to confuse svn diff
http://code.google.com/p/reviewboard/issues/detail?id=1515
*NOTE: Do not post confidential information in this bug report.*
What version
Comment #1 on issue 1516 by locomocogogo: post-review clearcase setup
http://code.google.com/p/reviewboard/issues/detail?id=1516
Ok, I can install RBTools with -Z option. So, should I edit the python code
in the
egg directory to set up clearcase and reviewboard server configuration?
--
You
Comment #4 on issue 1359 by lonico: Diff fails for text file with non-ascii
characters
http://code.google.com/p/reviewboard/issues/detail?id=1359
I have a similar issue, but with post-review:
Traceback (most recent call last):
File /u/laurentn/p4/code-review-feb22/rbtools/postreview.py,
Comment #1 on issue 1515 by chipx86: SVN hook can include empty arguments
which seems to confuse svn diff
http://code.google.com/p/reviewboard/issues/detail?id=1515
Can you post the patch at http://reviews.reviewboard.org/ ? We don't review
patches
on the bug tracker.
--
You received
27 matches
Mail list logo
