Re: postreview.py exists with invalid syntax using Windows

2010-06-11 Thread LeChuck
Thanks Christian, I've deinstalled Python 3.1 and installed Python 2.6. It's now working :-) So now I can start experimenting with svn hooks. Markus On Jun 10, 7:51 pm, Christian Hammond chip...@chipx86.com wrote: Hi Markus, Python 3.x is very different from 2.x. We don't support it yet (nor

Re: postreview.py exists with invalid syntax using Windows

2010-06-11 Thread Jan Koprowski
If You look for SVN hooks I attach example in http://code.google.com/p/reviewboard/issues/detail?id=445 This hook check status of Roundup Issue tracker ticket. If ok they made review or commit code if review was made and diffs are identical. On Jun 11, 11:15 am, LeChuck m...@silverseed.de wrote:

Re: post-review not working with ClearCase - RB1.5B2 on Windows

2010-06-11 Thread Cássio Fernando Berra
Awesome, thanks Jan! Unfortunately I’ve no background in Python, so if you don’t mind, let me know how do I apply those patches. Thanks again! Martelo 2010/6/10 Jan Koprowski jan.koprow...@gmail.com Hi! I made some patches to ClearCase. Please look at patches

Question about issue 394 - if a diff includes a file that has been cvs remove'd, reviewboard won't accept it

2010-06-11 Thread Matt Brown
I notice that the status is listed as PendingReview - has this fix ever been applied to the reviewboard trunk? http://code.google.com/p/reviewboard/issues/detail?id=394 I ask only because I am having the same exact issue as outlined in the bug report. Thanks Matt -- Want to help the Review

Re: post-review not working with ClearCase - RB1.5B2 on Windows

2010-06-11 Thread Jan Koprowski
Read this. All what You need is download raw diff and use patch On Jun 11, 2:05 pm, Cássio Fernando Berra martel...@gmail.com wrote: Awesome, thanks Jan! Unfortunately I’ve no background in Python, so if you don’t mind, let me know how do I apply those patches. Thanks again! Martelo

Re: ReviewBoard example instance

2010-06-11 Thread Stephen Gallagher
On 06/10/2010 03:24 PM, Christian Hammond wrote: Hi Stephen, We're running on MySQL. I don't know why you'd be seeing such a huge delay with PostgreSQL though. Can you tell me which pages are showing delays? (Is it all of them?) if it's the dashboard, there are some known slowdowns when

Re: Issue 1615 in reviewboard: Removing a file after it has been svn added causes post-review to not work

2010-06-11 Thread reviewboard
Comment #4 on issue 1615 by chris0123456789: Removing a file after it has been svn added causes post-review to not work http://code.google.com/p/reviewboard/issues/detail?id=1615 Yes: diff (GNU diffutils) 2.8.1 -- You received this message because you are subscribed to the Google Groups

Re: Issue 1681 in reviewboard: asdfsaf

2010-06-11 Thread reviewboard
Updates: Status: Spam Comment #1 on issue 1681 by chipx86: asdfsaf http://code.google.com/p/reviewboard/issues/detail?id=1681 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to

Re: Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it

2010-06-11 Thread reviewboard
Comment #13 on issue 394 by chipx86: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it http://code.google.com/p/reviewboard/issues/detail?id=394 It does look like the fix exists in the codebase, both on master and 1.0.x. -- You received this message because

Re: Issue 1655 in reviewboard: Reply to the previous comment button in diff view just takes you to review view

2010-06-11 Thread reviewboard
Comment #1 on issue 1655 by dgibson66: Reply to the previous comment button in diff view just takes you to review view http://code.google.com/p/reviewboard/issues/detail?id=1655 The right action here, in my opinion, would be to open a reply text box without changing pages. -- You

Re: Issue 1655 in reviewboard: Reply to the previous comment button in diff view just takes you to review view

2010-06-11 Thread reviewboard
Comment #2 on issue 1655 by chipx86: Reply to the previous comment button in diff view just takes you to review view http://code.google.com/p/reviewboard/issues/detail?id=1655 Yes, but we need to figure out the interaction there, because in order for the comment to be public, you have to

Re: Issue 1633 in reviewboard: Repository configuration should not expose passwords

2010-06-11 Thread reviewboard
Updates: Labels: -Milestone-Release1.5 Milestone-Release1.6 Comment #7 on issue 1633 by trowbrds: Repository configuration should not expose passwords http://code.google.com/p/reviewboard/issues/detail?id=1633 Looks like there's not a good, easy solution to this that works

Issue 1682 in reviewboard: post-review mangles the Perforce server name when the IP is in /etc/hosts

2010-06-11 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1682 by bburtin: post-review mangles the Perforce server name when the IP is in /etc/hosts http://code.google.com/p/reviewboard/issues/detail?id=1682 *NOTE: Do not post confidential information in this bug report.* What

Re: Issue 1682 in reviewboard: post-review mangles the Perforce server name when the IP is in /etc/hosts

2010-06-11 Thread reviewboard
Comment #1 on issue 1682 by bburtin: post-review mangles the Perforce server name when the IP is in /etc/hosts http://code.google.com/p/reviewboard/issues/detail?id=1682 The problem is probably somewhere around here in PerforceClient: hostname, port = repository_path.split(:)