We have post-commit hook to create review requests. So the request gets created with the person who commits as a submitter. Then there are set of reviewers defined. So based on the folder structure of files, requests get assigned to corresponding reviewers.
Now only reviewers should be able to complete the review and close the request. As you have mentioned, can we control who can mark the review for 'Ship It'? Thanks for your response. Regards -Madhavi On Jun 4, 6:14 am, Tucker <j...@gmail.com> wrote: > I'm curious, what is your expected work flow? As, I assume, the > submitter is also going to be the person who commits the change, how > would the reviewer know when it is OK to mark a review closed? For my > use, I would like to make a review unable to be Closed->Submitted > without someone first having marked it "Ship It!" Marking something > Closed->Discarded should be allowed without a "Ship It!" though. > > This is basically what I'm talking about: > > close: > if reviewer: > if discarded: > pass > elif approved and submitted: > pass > else: > fail > > > > > > > > > > On Fri, Jun 3, 2011 at 2:28 AM, Madhavi <madhavii.gu...@gmail.com> wrote: > > Hi, > > > We are using ReviewBoard 1.5.5 > > > Currently, the submitter can close the generated review request. We > > want to control that. Submitter should not be able to close his/her > > own review requests. Only reviewers should be able to do so. > > > Please let me know whether it is possible and if yes how can I achieve > > this? > > > Regards > > -Madhavi > > > -- > > Want to help the Review Board project? Donate today > > athttp://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~----------~----~----~----~------~----~------~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group > > athttp://groups.google.com/group/reviewboard?hl=en > > -- > > --tucker -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
