Thanks guys for quick feedback. No, I wasn't aware of 'multi-line' comments (sounds useful!), but as Chris mentioned, most times is not so much that the comment applies to multiple lines, but more like for the original submitter a quick way to locate the affected line (the line no. may not be that effective, especially in larger sources, as it may have been moved around by prior changes).
Happy to file the enhancement request, though - I presume I'll find the bug tracker linked from the website, right? as to provide 'visual' context, I presume you could style it in a way that makes it obvious (eg, gray background, or white b/g with light gray f/g for the 'context' lines, while the affected lines retain the original styling - eg black on green, or whatever) Regards, * * *Marco Massenzio* *Director Engineering * * * * * D 650.525.3546 *|* ma...@snaplogic.com 71 East 3rd Avenue, 2nd Floor, San Mateo, California 94401 On Fri, Jan 6, 2012 at 10:14 PM, Christian Hammond <chip...@chipx86.com>wrote: > It wouldn't take much work for us to add context to this. Just +/- a > couple of lines when determining the range. We'd probably want to somehow > make it clear that it's context and not the affected code, though. That > would maybe require a little more thought. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > On Fri, Jan 6, 2012 at 6:44 PM, Chris Tooley <ch...@tooley.com> wrote: > >> We actually have the same issues and do use multi-line comments. >> Multi-line comments are fit when the comment applies to the whole block in >> our case. I see what you mean, but it's a confusing option to use for us. >> On Jan 6, 2012 8:01 PM, "David Trowbridge" <trowb...@gmail.com> wrote: >> >>> We don't show additional context right now (I suppose we could consider >>> adding >>> such an option), but are you aware of multi-line comments? If the comment >>> applies to a block of code more than one line in length, you can click >>> and drag >>> to specify all the relevant lines. This lets the reviewer decide how >>> much context >>> is necessary, and if you're not using it already, would probably go a >>> long way >>> towards solving your problem. >>> >>> -David >>> >>> >>> On Fri, Jan 6, 2012 at 5:24 PM, Marco <ma...@snaplogic.com> wrote: >>> >>>> Hi, >>>> >>>> here we all love RB, and use it happily. >>>> However, there's one feature missing that drives us nuts: in review >>>> mode, when going through the reviewer's comments, only the actual line >>>> the comment is relative to is displayed. >>>> >>>> Often, it would be very useful to be able to see the 'context' of the >>>> line (eg, a couple of lines above and below) but we seem unable to >>>> find an option that would allow us to enable that, so we're assuming >>>> that's not possible. >>>> >>>> One colleagues suggested, as a workaround, that we have 3 monitors: >>>> one for the review, one for the diff, and the third for Eclipse/emacs/ >>>> vim whatever - is that about right? >>>> >>>> If you guys could implement this (or suggest a workaround that does >>>> not treble our IT budget) that'd be most appreciated! >>>> >>>> Thanks, >>>> Marco. >>>> >>>> -- >>>> Want to help the Review Board project? Donate today at >>>> http://www.reviewboard.org/donate/ >>>> Happy user? Let us know at http://www.reviewboard.org/users/ >>>> -~----------~----~----~----~------~----~------~--~--- >>>> To unsubscribe from this group, send email to >>>> reviewboard+unsubscr...@googlegroups.com >>>> For more options, visit this group at >>>> http://groups.google.com/group/reviewboard?hl=en >>>> >>> >>> -- >>> Want to help the Review Board project? Donate today at >>> http://www.reviewboard.org/donate/ >>> Happy user? Let us know at http://www.reviewboard.org/users/ >>> -~----------~----~----~----~------~----~------~--~--- >>> To unsubscribe from this group, send email to >>> reviewboard+unsubscr...@googlegroups.com >>> For more options, visit this group at >>> http://groups.google.com/group/reviewboard?hl=en >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~----------~----~----~----~------~----~------~--~--- >> To unsubscribe from this group, send email to >> reviewboard+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
