Re: Error when diff files on ReviewBoard site

2014-07-23 Thread hoàng tuấn
Dear Mr David, I get this log when i click at *ViewDiff* or *click at the file* on *ReviewRequest* I sent to you all i got. ===*Review Request* https://lh4.googleusercontent.com/-tdnYHF7hsHY/U89aaHzso-I/AC0/lw9bYueKplU/s1600/1.PNG

Need help for adding drop down button in comment window ---- customization of rbsevrity 0.5.1 plugin

2014-07-23 Thread Rama krishna
Hi All, I have successfully installed rbsevrity 0.5.1 plugin. I am able to see Major, Minor and Info button on comment window, Could you please me how to add drop down button on comment window. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review

Re: Need help for adding drop down button in comment window ---- customization of rbsevrity 0.5.1 plugin

2014-07-23 Thread Christian Hammond
There’s nothing built-in to do this. You would have to write it yourself from scratch. You can refer to the source code for rbseverity to see how modifications are made, but other than that, it’s all up to you. Christian --  Christian Hammond - christ...@beanbaginc.com Review Board - 

Re: Need help for adding drop down button in comment window ---- customization of rbsevrity 0.5.1 plugin

2014-07-23 Thread Rama krishna
ok after modifying severity.js file we need to re-install again? On Wednesday, July 23, 2014 2:23:36 PM UTC+5:30, Christian Hammond wrote: There’s nothing built-in to do this. You would have to write it yourself from scratch. You can refer to the source code for rbseverity to see how

How to avoid empty draft creation when upload diff fails

2014-07-23 Thread Joe
Hello, In our company, we have a custom source code packaging format. So we have written a wrapper above rbtools, based on this link https://www.reviewboard.org/docs/rbtools/dev/api/tutorial/ In our python script, we use the following snippet to create and upload a review request: f =

Re: New seup: Reviewboard seems to fail on thinking SVN repo should be a checked out version

2014-07-23 Thread Michael Kovacs
David, I seriously appreciate the help you are giving me on this issue OK so I have the syntax and implemented the --repository-url in the post-commit-run.cmd file, which is called by the actual post-commit.cmd on VisualSVN. As can be seen above, I was passing a set of authentication

Re: New seup: Reviewboard seems to fail on thinking SVN repo should be a checked out version

2014-07-23 Thread Michael Kovacs
I found a reference (of yours, actually!) which shows the syntax of the repo url to be ...=file:// Tried the line as --repository-url=file:///data/SVNRoot/NetworkConfigs but back to the original issue then: Current directory = C:\Data\SVNRoot\NetworkConfigs Checking for a Subversion

rbt tools bug in handling deletes from perforce?

2014-07-23 Thread jcombe
Hello, I think there is a bug in rbt post in generating the diff from perforce for a submitted change list that contains a delete. The most recent version of the file in the submitted change list output from perforce is the delete. I think the issue begins in _compute_range_changes in

Re: How to avoid empty draft creation when upload diff fails

2014-07-23 Thread Christian Hammond
Hi Joe, There’s no way to permanently delete it. You should probably just reuse it. We have an API resource,  https://www.reviewboard.org/docs/manual/dev/webapi/2.0/resources/validation/, that can validate a diff prior to upload, so that you can catch any errors without creating a review

Re: How to avoid empty draft creation when upload diff fails

2014-07-23 Thread Bruce Cran
Can't you permanently delete it after publishing it with you as the only reviewer (if you have the necessary permissions)? -- Bruce On Wed, Jul 23, 2014 at 12:35 PM, Christian Hammond christ...@beanbaginc.com wrote: Hi Joe, There’s no way to permanently delete it. You should probably

Re: How to avoid empty draft creation when upload diff fails

2014-07-23 Thread Christian Hammond
You can if you’re an administrator or have the proper option set, but we don’t recommend it. That’s really a last-resort option. The diff validation resource is the best bet in this case. Christian --  Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org

Issue 3491 in reviewboard: Alt+S shortcut interfering with Polish (Programmer) Keyboard Layout

2014-07-23 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3491 by kwes...@kwesoly.net: Alt+S shortcut interfering with Polish (Programmer) Keyboard Layout http://code.google.com/p/reviewboard/issues/detail?id=3491 What version are you running? ReviewBoard 2.0.2 What's the URL of