Hi, We're using the postreview extension and have been hitting that issue pretty regularly. It's particularly annoying because I think that reviewboard caches the diff so if you messed up, even if you push afterwards and run hg postreview again it will still fail. I've finally stumbled on the -o option which seems to solve the issue, so that's pretty awesome. But that left me wondering, is there any reason why this isn't the default behaviour? From what I understand, it looks like rbt now does this by default.
Or otherwise, at least have postreview abort if it cannot find the parent in the remote repository rather than create a corrupted review request? (Sure, I could use defaults, but the Mercurial guys told me defaults are bad and I should feel bad even thinking about it <http://mercurial.selenic.com/wiki/Defaults>.) Cheers Jeremie On Thursday, 5 June 2014 02:14:06 UTC+1, ccaughie wrote: > > Ah - yes, you have to use the -o option to tell ReviewBoard to figure > out the parent diff base by doing the equivalent of "hg outgoing". For this > to work you need to make sure that your default push repository is the same > as the one that ReviewBoard sees; if it isn't you can use -O instead. ("hg > help postreview" has all of this information.) > > --master also works but means you have to figure it out yourself. > > Apologies for not thinking of that earlier. I have it configured in my > default args for the postreview command so I never actually have to type it. > > Colin > > On 06/04/2014 4:36 PM, Bruce Cran wrote: > > I'm using Mercurial 3.0, ReviewBoard 2.0.1 and as of today, the latest > code from https://bitbucket.org/ccaughie/hgreviewboard . I did forget to > add "hg add file2.txt" to the list of steps, but I ran it during testing. > Should the code figure out which revision to use for the parent diff base? > It works if I specify "--master qparent". > > -- > Bruce > > > On Wed, Jun 4, 2014 at 4:36 PM, Colin Caughie <c.ca...@gmail.com > <javascript:>> wrote: > >> Following those instructions exactly I get an error message of "The >> specified diff file is empty", which is not surprising since file2.txt was >> never added to the repository. >> >> If I do "hg add file2.txt" before the first qnew on the other hand, "hg >> postreview" works fine and correctly shows Line2 being added to file2.txt. >> >> If it is still breaking for you even with the hg add, can you let me know >> what versions of mercurial, ReviewBoard and the reviewboard extension >> you're using? >> >> If you're using the latest versions and it still doesn't work, please >> send me the output of >> >> hg postreview --debug --apitrace >> > -- > Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ > --- > Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ > --- > Happy user? Let us know at http://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard...@googlegroups.com <javascript:>. > For more options, visit https://groups.google.com/d/optout. > > > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
