About '--branch' option of post-review

2010-03-10 Thread JohnHenry
Hi,
The post-review tool has an option named --branch, I am using
CVS Repository now, But I am not sure whether this branch is equal to
CVS branch.
I had view source of Cvs.py _cat_specific_file() fucntion.
-
   p = subprocess.Popen(['cvs', '-f', '-d', self.repository,
'checkout',
  '-r', str(revision), '-p', filename],
 stderr=subprocess.PIPE,
stdout=subprocess.PIPE,
 close_fds=(os.name != 'nt'))
contents = p.stdout.read()
errmsg = p.stderr.read()
failure = p.wait()

but the str(revison) comes from HEAD, It seems  nothing  relative with
the post-view branch option. Then How to use branch option in
Reviewboard?

 Best Regards!

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: About '--branch' option of post-review

2010-03-10 Thread Christian Hammond
Hi,

The --branch option can actually be any string. It's not even required. It's
basically a way to tell reviewers here's the branch the work is being done
on. It can really be anything you specify, though, as it's for display
purposes only.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Wed, Mar 10, 2010 at 9:05 PM, JohnHenry qhlonl...@163.com wrote:

 Hi,
The post-review tool has an option named --branch, I am using
 CVS Repository now, But I am not sure whether this branch is equal to
 CVS branch.
I had view source of Cvs.py _cat_specific_file() fucntion.

 -
   p = subprocess.Popen(['cvs', '-f', '-d', self.repository,
 'checkout',
  '-r', str(revision), '-p', filename],
 stderr=subprocess.PIPE,
 stdout=subprocess.PIPE,
 close_fds=(os.name != 'nt'))
contents = p.stdout.read()
errmsg = p.stderr.read()
failure = p.wait()

 
 but the str(revison) comes from HEAD, It seems  nothing  relative with
 the post-view branch option. Then How to use branch option in
 Reviewboard?

  Best Regards!

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en