Re:Re: About the idea of integrating the CVS and ReviewBoard into a development process

2009-12-23 Thread qhlonline
Hi, Scott, I want to know, If we set all those code-review process after code commition, We do post-commit review, Then how to realize that? I had use post-review to generate a post-commit review request for specific files, But failed. My command is: post-review --debug

Re: Re: About the idea of integrating the CVS and ReviewBoard into a development process

2009-12-23 Thread Scott Quesnelle
I would suggest taking a look at: http://linuxdevcenter.com/pub/a/linux/2003/06/05/scripts.html This requires some scripting on your part. Our script queries our bug tracking system (ClearQuest) and validates that the bugid is valid and that the bug is in the correct state (Code Review) and that

Re:Re: Re: About the idea of integrating the CVS and ReviewBoard into a development process

2009-12-23 Thread qhlonline
Thanks Scott,The method you provided seems doing pre-commit review. But now we have changed our idea. We want do automation on post-commit review. Thus, If somebody has commmited his code, a CVS post-commit script will be stimulated and post a review request for this user. Now the key problem

Re: About the idea of integrating the CVS and ReviewBoard into a development process

2009-12-21 Thread Scott Quesnelle
We are doing reviews prior to the changes being commited to CVS. To enforce this process, you can modify the CVS pre-commit script. This script can then check change for review approval. We currently require the bugid to be in the cvs commit log, as such we query the bug tracking system and

Re:Re: About the idea of integrating the CVS and ReviewBoard into a development process

2009-12-21 Thread qhlonline
Thanks for your suggestion, Scott. I am not familar with CVS pre-commit script, And I can not find enough document about RB integrating with Bug Tracker (In ReviewBoard document, I can only know how to set the bugTracker in RB server, But I don't know its function and its usage there), Can you