What revision of Review Board is this?
Also, how are you generating the diff? Does post-review work?
Christian
--
Christian Hammond - chip...@chipx86.com
VMware, Inc.
On Fri, Jan 16, 2009 at 2:32 PM, Cong Do c...@rgbnetworks.com wrote:
Hi,
We tried to generate a code review using
What revision of Review Board is this? - 0.9
Also, how are you generating the diff? - p4 diff -du ...
Does post-review work? - didn't try
--
Christian Hammond - chip...@chipx86.com
VMware, Inc.
On Fri, Jan 16, 2009 at 2:32 PM, Cong Do c...@rgbnetworks.com wrote:
Hi,
We tried to
The revision is the SVN revision or nightly build.
Okay, so p4 diff is the problem. p4 diff doesn't provide the information
needed for doing any kind of code reviews. We expect certain information in
the diff, which isn't available. With Perforce, you'll have to use
post-review to post your
@googlegroups.com
Cc: Matthew Chang
Subject: Re: Cannot create review using Perforce
The revision is the SVN revision or nightly build.
Okay, so p4 diff is the problem. p4 diff doesn't provide the information
needed for doing any kind of code reviews. We expect certain information
in the diff, which isn't
Hammond
*Sent:* Friday, January 16, 2009 3:28 PM
*To:* reviewboard@googlegroups.com
*Cc:* Matthew Chang
*Subject:* Re: Cannot create review using Perforce
The revision is the SVN revision or nightly build.
Okay, so p4 diff is the problem. p4 diff doesn't provide the information
needed
