Re: Comments do not get saved in draft mode

2012-03-14 Thread David Trowbridge
This is a known issue. We don't support commenting on draft diffs because
they
could be replaced before publishing, which would cause the comments to be
lost.

Our plan is to disable the commenting UI until there's a published diff,
but nobody
has done it yet.

-David


On Wed, Mar 14, 2012 at 8:05 AM, Scott SRS wrote:

> Steps to reproduce:
> (1) I run "post-review" so the diffs in my code get posted to Review
> Board
> (2) I view the diff files, click on a line of code, and add a comment.
> (3) Even if the comment appears to get saved, if I refresh the page
> the comment is lost.
>
> This is only an issue for me with code reviews that haven't been
> published yet.
>
> Has anyone else seen this issue?
>
> Thanks!
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Comments do not get saved in draft mode

2012-03-14 Thread Scott SRS
Steps to reproduce:
(1) I run "post-review" so the diffs in my code get posted to Review
Board
(2) I view the diff files, click on a line of code, and add a comment.
(3) Even if the comment appears to get saved, if I refresh the page
the comment is lost.

This is only an issue for me with code reviews that haven't been
published yet.

Has anyone else seen this issue?

Thanks!

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en