Re: Creating a diff seems slow

2009-02-04 Thread Martin 

thank you!

Yes, I use memcached.

I'll see what I can do about your other suggestions.

On Feb 3, 11:32 pm, Christian Hammond  wrote:
> It's hard to say. I recommend attempting the same checkout from that box in
> a shell. You may also want to try using http instead of https for the SVN
> repository, see if that makes a difference.
>
> The rendering can take a while because Review Board has to do the follwoing:
>
> 1) Take the file from the repository and write it to disk.
> 2) Take the patch from the database and invoke 'patch' with it, patching the
> file from the repository we wrote to disk.
> 3) Read that file in and perform a diff internally between the two buffers.
> 4) Render that to HTML.
>
> There's a few things in there that can be slow. However, if you have good
> caching enabled (memcached is *strongly* recommended, as it's what powers
> such things as Facebook and Youtube), you should only have that hit once per
> new diff.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> VMware, Inc.
>
> On Tue, Feb 3, 2009 at 8:06 PM, Martin  wrote:
>
> > Hi,
>
> > just upgraded to alpha2. Love the progressive load!
> > However, it appears to be quite slow.
>
> > Here is a snippet of my log (sorry for obfuscating)
>
> > 2009-02-03 19:46:01,919 - DEBUG - Begin: Generating diff file info for
> > diffset id 1621, filediff 26631
> > 2009-02-03 19:46:01,933 - INFO - Cache miss for key codereview:diff-
> > sidebyside-hl-26631.
> > 2009-02-03 19:46:02,247 - INFO - Cache miss for key codereview:https://
> > svn.build.foo.com/svn/foo:a/b/c/d/e/f/FileName.cs:84306.
> > 2009-02-0319:46:02,252
> >  - DEBUG - Begin: Fetching file 'a/b/c/d/e/f/
> > FileName.cs' r84306 from /svn/foo
> > 2009-02-03 19:46:05,186 - DEBUG - End: Fetching file 'a/b/c/d/e/f/
> > FileName.cs' r84306 from /svn/foo
> > 2009-02-03 19:46:05,189 - DEBUG - Fetching file 'a/b/c/d/e/f/
> > FileName.cs' r84306 from /svn/foo took 2.932401 seconds
> > 2009-02-03 19:46:05,216 - DEBUG - Begin: Patching file a/b/c/d/e/f/
> > FileName.cs
> > 2009-02-03 19:46:05,458 - DEBUG - End: Patching file a/b/c/d/e/f/
> > FileName.cs
> > 2009-02-03 19:46:05,463 - DEBUG - Patching file a/b/c/d/e/f/
> > FileName.cs took 0.239046 seconds
> > 2009-02-03 19:46:08,903 - DEBUG - Generating diff chunks for filediff
> > id 26631
> > 2009-02-03 19:46:09,173 - DEBUG - Done generating diff chunks for
> > filediff id 26631
> > 2009-02-03 19:46:09,764 - DEBUG - End: Generating diff file info for
> > diffset id 1621, filediff 26631
> > 2009-02-03 19:46:09,768 - WARNING - Generating diff file info for
> > diffset  id 1621, filediff 26631 took 7.846293 seconds
>
> > Just the download itself took almost 3 seconds. Our network is on a
> > gigabit switch and the svn and reviewboard servers are quite adjacent.
> > After downloading it for 3 seconds, it takes another 4 seconds to
> > render it :(
>
> > The file in question has 637 lines.
>
> > What can I do to speed things up? What could be the issue here?
>
> > Thanks!!
>
> > Martin
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Creating a diff seems slow

2009-02-03 Thread Christian Hammond 
It's hard to say. I recommend attempting the same checkout from that box in
a shell. You may also want to try using http instead of https for the SVN
repository, see if that makes a difference.

The rendering can take a while because Review Board has to do the follwoing:

1) Take the file from the repository and write it to disk.
2) Take the patch from the database and invoke 'patch' with it, patching the
file from the repository we wrote to disk.
3) Read that file in and perform a diff internally between the two buffers.
4) Render that to HTML.

There's a few things in there that can be slow. However, if you have good
caching enabled (memcached is *strongly* recommended, as it's what powers
such things as Facebook and Youtube), you should only have that hit once per
new diff.

Christian

-- 
Christian Hammond - chip...@chipx86.com
VMware, Inc.


On Tue, Feb 3, 2009 at 8:06 PM, Martin  wrote:

>
> Hi,
>
> just upgraded to alpha2. Love the progressive load!
> However, it appears to be quite slow.
>
> Here is a snippet of my log (sorry for obfuscating)
>
> 2009-02-03 19:46:01,919 - DEBUG - Begin: Generating diff file info for
> diffset id 1621, filediff 26631
> 2009-02-03 19:46:01,933 - INFO - Cache miss for key codereview:diff-
> sidebyside-hl-26631.
> 2009-02-03 19:46:02,247 - INFO - Cache miss for key codereview:https://
> svn.build.foo.com/svn/foo:a/b/c/d/e/f/FileName.cs:84306.
> 2009-02-0319:46:02,252
>  - DEBUG - Begin: Fetching file 'a/b/c/d/e/f/
> FileName.cs' r84306 from /svn/foo
> 2009-02-03 19:46:05,186 - DEBUG - End: Fetching file 'a/b/c/d/e/f/
> FileName.cs' r84306 from /svn/foo
> 2009-02-03 19:46:05,189 - DEBUG - Fetching file 'a/b/c/d/e/f/
> FileName.cs' r84306 from /svn/foo took 2.932401 seconds
> 2009-02-03 19:46:05,216 - DEBUG - Begin: Patching file a/b/c/d/e/f/
> FileName.cs
> 2009-02-03 19:46:05,458 - DEBUG - End: Patching file a/b/c/d/e/f/
> FileName.cs
> 2009-02-03 19:46:05,463 - DEBUG - Patching file a/b/c/d/e/f/
> FileName.cs took 0.239046 seconds
> 2009-02-03 19:46:08,903 - DEBUG - Generating diff chunks for filediff
> id 26631
> 2009-02-03 19:46:09,173 - DEBUG - Done generating diff chunks for
> filediff id 26631
> 2009-02-03 19:46:09,764 - DEBUG - End: Generating diff file info for
> diffset id 1621, filediff 26631
> 2009-02-03 19:46:09,768 - WARNING - Generating diff file info for
> diffset  id 1621, filediff 26631 took 7.846293 seconds
>
> Just the download itself took almost 3 seconds. Our network is on a
> gigabit switch and the svn and reviewboard servers are quite adjacent.
> After downloading it for 3 seconds, it takes another 4 seconds to
> render it :(
>
> The file in question has 637 lines.
>
> What can I do to speed things up? What could be the issue here?
>
> Thanks!!
>
> Martin
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Creating a diff seems slow

2009-02-03 Thread Martin 

Hi,

just upgraded to alpha2. Love the progressive load!
However, it appears to be quite slow.

Here is a snippet of my log (sorry for obfuscating)

2009-02-03 19:46:01,919 - DEBUG - Begin: Generating diff file info for
diffset id 1621, filediff 26631
2009-02-03 19:46:01,933 - INFO - Cache miss for key codereview:diff-
sidebyside-hl-26631.
2009-02-03 19:46:02,247 - INFO - Cache miss for key codereview:https://
svn.build.foo.com/svn/foo:a/b/c/d/e/f/FileName.cs:84306.
2009-02-03 19:46:02,252 - DEBUG - Begin: Fetching file 'a/b/c/d/e/f/
FileName.cs' r84306 from /svn/foo
2009-02-03 19:46:05,186 - DEBUG - End: Fetching file 'a/b/c/d/e/f/
FileName.cs' r84306 from /svn/foo
2009-02-03 19:46:05,189 - DEBUG - Fetching file 'a/b/c/d/e/f/
FileName.cs' r84306 from /svn/foo took 2.932401 seconds
2009-02-03 19:46:05,216 - DEBUG - Begin: Patching file a/b/c/d/e/f/
FileName.cs
2009-02-03 19:46:05,458 - DEBUG - End: Patching file a/b/c/d/e/f/
FileName.cs
2009-02-03 19:46:05,463 - DEBUG - Patching file a/b/c/d/e/f/
FileName.cs took 0.239046 seconds
2009-02-03 19:46:08,903 - DEBUG - Generating diff chunks for filediff
id 26631
2009-02-03 19:46:09,173 - DEBUG - Done generating diff chunks for
filediff id 26631
2009-02-03 19:46:09,764 - DEBUG - End: Generating diff file info for
diffset id 1621, filediff 26631
2009-02-03 19:46:09,768 - WARNING - Generating diff file info for
diffset  id 1621, filediff 26631 took 7.846293 seconds

Just the download itself took almost 3 seconds. Our network is on a
gigabit switch and the svn and reviewboard servers are quite adjacent.
After downloading it for 3 seconds, it takes another 4 seconds to
render it :(

The file in question has 637 lines.

What can I do to speed things up? What could be the issue here?

Thanks!!

Martin
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---