Issue 1285 in reviewboard: Expanding hidden lines between revisions
Updates: Status: Fixed Owner: chipx86 Comment #2 on issue 1285 by chipx86: Expanding hidden lines between revisions http://code.google.com/p/reviewboard/issues/detail?id=1285 Yeah, this should have been fixed a while ago in 1.0.2. Please upgrade to 1.0.4 and see if it's fixed. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1285 in reviewboard: Expanding hidden lines between revisions
Updates: Status: Confirmed Labels: Milestone-Release1.0.x Component-DiffViewer Comment #1 on issue 1285 by chipx86: Expanding hidden lines between revisions http://code.google.com/p/reviewboard/issues/detail?id=1285 Kind of thought we fixed this, but we'll schedule this for 1.0.x. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Re: Expanding hidden lines between revisions
Hey Christian, Thanks, I logged that bug. Whilst I'm at it, I noticed another artifact related to Expand - not sure if it has been noted yet. If you highlight a changed section of a file diff - so that it gets a dark outlined border, and then hit expand for that file- the border remains in the same absolute location (thus in a section of the file you expanded without any diff), rather than remaining around the originally highlighted diff lines. On Aug 24, 10:39 am, Christian Hammond chip...@chipx86.com wrote: Hi Tom, Would you mind filing a bug on this? We'll look at getting it into 1.0.2. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Mon, Aug 24, 2009 at 2:32 AM, tom december1...@gmail.com wrote: hey Christian, I'm on 1.0.1, with perforce as the repository. Cheers On Aug 23, 7:04 am, Christian Hammond chip...@chipx86.com wrote: Hi Tom, What version of Review Board are you running? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Sat, Aug 22, 2009 at 6:14 AM, tom december1...@gmail.com wrote: Hi, Not sure if this is known, but when I try to expand hidden lines in the diff output between diff revisions (say between r2 and r3) for files that were newly added in the later revision (so here added in r3), I get a 404. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Expanding hidden lines between revisions
hey Christian, I'm on 1.0.1, with perforce as the repository. Cheers On Aug 23, 7:04 am, Christian Hammond chip...@chipx86.com wrote: Hi Tom, What version of Review Board are you running? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Sat, Aug 22, 2009 at 6:14 AM, tom december1...@gmail.com wrote: Hi, Not sure if this is known, but when I try to expand hidden lines in the diff output between diff revisions (say between r2 and r3) for files that were newly added in the later revision (so here added in r3), I get a 404. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 1285 in reviewboard: Expanding hidden lines between revisions
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1285 by December1981: Expanding hidden lines between revisions http://code.google.com/p/reviewboard/issues/detail?id=1285 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.0.1 What's the URL of the page containing the problem? javascript behaviour, when looking at diff between diff revisions (http://reviewboardserver/r/x/diff/y-z/#) What steps will reproduce the problem? 1. Create an initial review (r1) 2. Update the review with additional files (r2) 3. Do a diff between r1-r2 4. Click on Expand for a diff tab for a file which was newly added on r2 What is the expected output? What do you see instead? Expect to see the full file I attempted to expand, get a 404 tab at the top of the page instead. What operating system are you using? What browser? reviewboard hosted on gnu/linux (python 2.5), issue spotted with firefox 3.5 under xp. Please provide any additional information below. using perforce as repository -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
