Re: Files in Patch not the same as files in view diff
I restarted the memcache and that seems to have fixed the issues.
thanks
On Aug 20, 11:49 am, Christian Hammond wrote:
> Oh, so your diff is uploading passwd but you're seeing Config.mak.
>
> It's possible that you have some odd caching problem. If you're using
> memcached, try restarting it to clear the cache. If it's a file-based cache,
> delete all the files in the cache. Then re-view the diff.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
> On Fri, Aug 20, 2010 at 8:51 AM, tag_98007work wrote:
>
>
>
> > View diff shows:
>
> > Revision 1 New Change # this file is really /config/host_tools/
> > Config.mak not sysfiles/etc/passwd
> > 1 # WG_CPU is toolchain prefix
> > 2 WG_CPU = x86
> > 3 WG_ARCH = x86
> > 4 WG_ENDIAN = little
> > 5
> > 6 KERNEL_ARCH = i386
> > 7 KERNEL_SFX = ko
> > 8 KERNEL_VPATH = true
> > 9
> > 10 export WG_ARCH
> > 11 export WG_CPU
> > 12 export WG_ENDIAN
> > 13 export KERNEL_ARCH
> > 14 export KERNEL_SFX
> > 15 export KERNEL_VPATH
> > //user/reviewboard/components/wg_linux/mainline/sysfiles/finley/etc/
> > fstab
> > Revision 1 New Change # this file is really /config/host_tools/
> > debug_platform.pkgspec and not sysfiles/finley/etc/fstab
> > 1 return
> > 2 Entry { dst = DRVPATH .. "oprofile." .. ext,
> > 3 src = "$LINUX_BASE/modules/arch/$KERNEL_ARCH/
> > oprofile/oprofile." .. ext }
> > 4
>
> > -
> > --- //user/reviewboard/components/wg_linux/mainline/sysfiles/etc/
> > passwd //user/reviewboard/components/wg_linux/mainline/sysfiles/etc/
> > passwd#1
> > +++ //user/reviewboard/components/wg_linux/mainline/sysfiles/etc/
> > passwd 2010-08-19 10:14:30
> > @@ -1,3 +1,5 @@
> > +#add a line
> > +#
> > root:!$1$jw92fqyv$NVy9MLVQEPDvXiOXQC4jp.:0:0:Administrator:/root:/bin/
> > ash
> > bin:x:1:1:bin:/bin:
> > system:x:2:96:WG System daemons:/:
> > --- //user/reviewboard/components/wg_linux/mainline/sysfiles/finley/
> > etc/fstab //user/reviewboard/components/wg_linux/mainline/sysfiles/
> > finley/etc/fstab#1
> > +++ //user/reviewboard/components/wg_linux/mainline/sysfiles/finley/
> > etc/fstab 2010-08-19 10:14:30
> > @@ -1,3 +1,6 @@
> > +#new line
> > +#and another
> > +
> > /dev/wgrd.sysa_code / ext2
> > ro 1 1
> > none /proc proc
> > defaults 0 0
> > none /sys sysfs
> > defaults 0 0
>
> > --
> > Logging shows:
> > 2010-08-20 08:43:41,623 - DEBUG - Generating diff viewer page for
> > filediff id 9
> > 2010-08-20 08:43:41,641 - DEBUG - Begin: Generating diff file info for
> > diffset id 9
> > 2010-08-20 08:43:41,644 - DEBUG - End: Generating diff file info for
> > diffset id 9
> > 2010-08-20 08:43:41,644 - DEBUG - Generating diff file info for
> > diffset id 9 took 0.2773 seconds
> > 2010-08-20 08:43:41,649 - DEBUG - Begin: Generating diff file info for
> > diffset id 9, filediff 14
> > 2010-08-20 08:43:41,651 - DEBUG - End: Generating diff file info for
> > diffset id 9, filediff 14
> > 2010-08-20 08:43:41,651 - DEBUG - Generating diff file info for
> > diffset id 9, filediff 14 took 0.2185 seconds
> > 2010-08-20 08:43:42,013 - DEBUG - Done generating diff viewer page for
> > filediff id 9
> > 2010-08-20 08:43:42,582 - DEBUG - Begin: Generating diff file info for
> > diffset id 9, filediff 15
> > 2010-08-20 08:43:42,584 - DEBUG - End: Generating diff file info for
> > diffset id 9, filediff 15
> > 2010-08-20 08:43:42,584 - DEBUG - Generating diff file info for
> > diffset id 9, filediff 15 took 0.1751 seconds
>
> > --
>
> > Any help in sorting this out would be appreciated. We are attempting
> > this against Perforce.
>
> > Thanks
>
> > On Aug 19, 5:04 pm, Christian Hammond wrote:
> > > I don't see any files attached.
>
> > > Which files were shown in the diff viewer?
>
> > > Christian
>
> > > --
> > > Christian Hammond - chip...@chipx86.com
> > > Review Board -http://www.reviewboard.org
> > > VMware, Inc. -http://www.vmware.com
>
> > > On Wed, Aug 18, 2010 at 2:35 PM, tag_98007work > >wrote:
>
> > > > I uploaded a changelist with 2 files in it: Code Review Checklist.txt,
> > > > place_holder
>
> > > > When I view the diff throught the View Diff button the files displayed
> > > > are not the files from the changelist. The diff in the download diff
> > > > is correct.
>
> > > > I uploaded the files: cl285668_viewdiff.txt so you can see what's
> > > > visiable on the view diff button.
> > > > cl285668bug.path is what's visable on the
> > > > download diff. This one is correct.
>
> > > > I'm running RB 1.5 RC1 on a Linux server
> > > > Mysql on Linux
> > > > RBTools 0.2 on Windows
>
> > > > --
> > > > Want to help the Review Board project? Donate today at
> > > >http://www.reviewboard.org/donate/
> > > > Happy user? Let us k
Re: Files in Patch not the same as files in view diff
Oh, so your diff is uploading passwd but you're seeing Config.mak.
It's possible that you have some odd caching problem. If you're using
memcached, try restarting it to clear the cache. If it's a file-based cache,
delete all the files in the cache. Then re-view the diff.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Fri, Aug 20, 2010 at 8:51 AM, tag_98007work wrote:
> View diff shows:
>
> Revision 1 New Change # this file is really /config/host_tools/
> Config.mak not sysfiles/etc/passwd
> 1 # WG_CPU is toolchain prefix
> 2 WG_CPU = x86
> 3 WG_ARCH = x86
> 4 WG_ENDIAN = little
> 5
> 6 KERNEL_ARCH = i386
> 7 KERNEL_SFX = ko
> 8 KERNEL_VPATH = true
> 9
> 10 export WG_ARCH
> 11 export WG_CPU
> 12 export WG_ENDIAN
> 13 export KERNEL_ARCH
> 14 export KERNEL_SFX
> 15 export KERNEL_VPATH
> //user/reviewboard/components/wg_linux/mainline/sysfiles/finley/etc/
> fstab
> Revision 1 New Change # this file is really /config/host_tools/
> debug_platform.pkgspec and not sysfiles/finley/etc/fstab
> 1 return
> 2 Entry { dst = DRVPATH .. "oprofile." .. ext,
> 3 src = "$LINUX_BASE/modules/arch/$KERNEL_ARCH/
> oprofile/oprofile." .. ext }
> 4
>
> -
> --- //user/reviewboard/components/wg_linux/mainline/sysfiles/etc/
> passwd //user/reviewboard/components/wg_linux/mainline/sysfiles/etc/
> passwd#1
> +++ //user/reviewboard/components/wg_linux/mainline/sysfiles/etc/
> passwd 2010-08-19 10:14:30
> @@ -1,3 +1,5 @@
> +#add a line
> +#
> root:!$1$jw92fqyv$NVy9MLVQEPDvXiOXQC4jp.:0:0:Administrator:/root:/bin/
> ash
> bin:x:1:1:bin:/bin:
> system:x:2:96:WG System daemons:/:
> --- //user/reviewboard/components/wg_linux/mainline/sysfiles/finley/
> etc/fstab //user/reviewboard/components/wg_linux/mainline/sysfiles/
> finley/etc/fstab#1
> +++ //user/reviewboard/components/wg_linux/mainline/sysfiles/finley/
> etc/fstab 2010-08-19 10:14:30
> @@ -1,3 +1,6 @@
> +#new line
> +#and another
> +
> /dev/wgrd.sysa_code/ ext2
> ro 1 1
> none /proc proc
> defaults0 0
> none /syssysfs
> defaults0 0
>
> --
> Logging shows:
> 2010-08-20 08:43:41,623 - DEBUG - Generating diff viewer page for
> filediff id 9
> 2010-08-20 08:43:41,641 - DEBUG - Begin: Generating diff file info for
> diffset id 9
> 2010-08-20 08:43:41,644 - DEBUG - End: Generating diff file info for
> diffset id 9
> 2010-08-20 08:43:41,644 - DEBUG - Generating diff file info for
> diffset id 9 took 0.2773 seconds
> 2010-08-20 08:43:41,649 - DEBUG - Begin: Generating diff file info for
> diffset id 9, filediff 14
> 2010-08-20 08:43:41,651 - DEBUG - End: Generating diff file info for
> diffset id 9, filediff 14
> 2010-08-20 08:43:41,651 - DEBUG - Generating diff file info for
> diffset id 9, filediff 14 took 0.2185 seconds
> 2010-08-20 08:43:42,013 - DEBUG - Done generating diff viewer page for
> filediff id 9
> 2010-08-20 08:43:42,582 - DEBUG - Begin: Generating diff file info for
> diffset id 9, filediff 15
> 2010-08-20 08:43:42,584 - DEBUG - End: Generating diff file info for
> diffset id 9, filediff 15
> 2010-08-20 08:43:42,584 - DEBUG - Generating diff file info for
> diffset id 9, filediff 15 took 0.1751 seconds
>
> --
>
> Any help in sorting this out would be appreciated. We are attempting
> this against Perforce.
>
> Thanks
>
> On Aug 19, 5:04 pm, Christian Hammond wrote:
> > I don't see any files attached.
> >
> > Which files were shown in the diff viewer?
> >
> > Christian
> >
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.reviewboard.org
> > VMware, Inc. -http://www.vmware.com
> >
> > On Wed, Aug 18, 2010 at 2:35 PM, tag_98007work >wrote:
> >
> >
> >
> > > I uploaded a changelist with 2 files in it: Code Review Checklist.txt,
> > > place_holder
> >
> > > When I view the diff throught the View Diff button the files displayed
> > > are not the files from the changelist. The diff in the download diff
> > > is correct.
> >
> > > I uploaded the files: cl285668_viewdiff.txt so you can see what's
> > > visiable on the view diff button.
> > > cl285668bug.path is what's visable on the
> > > download diff. This one is correct.
> >
> > > I'm running RB 1.5 RC1 on a Linux server
> > > Mysql on Linux
> > > RBTools 0.2 on Windows
> >
> > > --
> > > Want to help the Review Board project? Donate today at
> > >http://www.reviewboard.org/donate/
> > > Happy user? Let us know athttp://www.reviewboard.org/users/
> > > -~--~~~~--~~--~--~---
> > > To unsubscribe from this group, send email to
> > > reviewboard+unsubscr...@googlegroups.com
>
> > > For more options, visit this group at
> > >http://groups.google.com/group/reviewboard?hl=en- Hide quoted text -
> >
> > - Show quote
Re: Files in Patch not the same as files in view diff
View diff shows:
Revision 1 New Change # this file is really /config/host_tools/
Config.mak not sysfiles/etc/passwd
1 # WG_CPU is toolchain prefix
2 WG_CPU = x86
3 WG_ARCH = x86
4 WG_ENDIAN = little
5
6 KERNEL_ARCH = i386
7 KERNEL_SFX = ko
8 KERNEL_VPATH = true
9
10 export WG_ARCH
11 export WG_CPU
12 export WG_ENDIAN
13 export KERNEL_ARCH
14 export KERNEL_SFX
15 export KERNEL_VPATH
//user/reviewboard/components/wg_linux/mainline/sysfiles/finley/etc/
fstab
Revision 1 New Change # this file is really /config/host_tools/
debug_platform.pkgspec and not sysfiles/finley/etc/fstab
1 return
2 Entry { dst = DRVPATH .. "oprofile." .. ext,
3 src = "$LINUX_BASE/modules/arch/$KERNEL_ARCH/
oprofile/oprofile." .. ext }
4
-
--- //user/reviewboard/components/wg_linux/mainline/sysfiles/etc/
passwd //user/reviewboard/components/wg_linux/mainline/sysfiles/etc/
passwd#1
+++ //user/reviewboard/components/wg_linux/mainline/sysfiles/etc/
passwd 2010-08-19 10:14:30
@@ -1,3 +1,5 @@
+#add a line
+#
root:!$1$jw92fqyv$NVy9MLVQEPDvXiOXQC4jp.:0:0:Administrator:/root:/bin/
ash
bin:x:1:1:bin:/bin:
system:x:2:96:WG System daemons:/:
--- //user/reviewboard/components/wg_linux/mainline/sysfiles/finley/
etc/fstab //user/reviewboard/components/wg_linux/mainline/sysfiles/
finley/etc/fstab#1
+++ //user/reviewboard/components/wg_linux/mainline/sysfiles/finley/
etc/fstab 2010-08-19 10:14:30
@@ -1,3 +1,6 @@
+#new line
+#and another
+
/dev/wgrd.sysa_code/ ext2
ro 1 1
none /proc proc
defaults0 0
none /syssysfs
defaults0 0
--
Logging shows:
2010-08-20 08:43:41,623 - DEBUG - Generating diff viewer page for
filediff id 9
2010-08-20 08:43:41,641 - DEBUG - Begin: Generating diff file info for
diffset id 9
2010-08-20 08:43:41,644 - DEBUG - End: Generating diff file info for
diffset id 9
2010-08-20 08:43:41,644 - DEBUG - Generating diff file info for
diffset id 9 took 0.2773 seconds
2010-08-20 08:43:41,649 - DEBUG - Begin: Generating diff file info for
diffset id 9, filediff 14
2010-08-20 08:43:41,651 - DEBUG - End: Generating diff file info for
diffset id 9, filediff 14
2010-08-20 08:43:41,651 - DEBUG - Generating diff file info for
diffset id 9, filediff 14 took 0.2185 seconds
2010-08-20 08:43:42,013 - DEBUG - Done generating diff viewer page for
filediff id 9
2010-08-20 08:43:42,582 - DEBUG - Begin: Generating diff file info for
diffset id 9, filediff 15
2010-08-20 08:43:42,584 - DEBUG - End: Generating diff file info for
diffset id 9, filediff 15
2010-08-20 08:43:42,584 - DEBUG - Generating diff file info for
diffset id 9, filediff 15 took 0.1751 seconds
--
Any help in sorting this out would be appreciated. We are attempting
this against Perforce.
Thanks
On Aug 19, 5:04 pm, Christian Hammond wrote:
> I don't see any files attached.
>
> Which files were shown in the diff viewer?
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
> On Wed, Aug 18, 2010 at 2:35 PM, tag_98007work wrote:
>
>
>
> > I uploaded a changelist with 2 files in it: Code Review Checklist.txt,
> > place_holder
>
> > When I view the diff throught the View Diff button the files displayed
> > are not the files from the changelist. The diff in the download diff
> > is correct.
>
> > I uploaded the files: cl285668_viewdiff.txt so you can see what's
> > visiable on the view diff button.
> > cl285668bug.path is what's visable on the
> > download diff. This one is correct.
>
> > I'm running RB 1.5 RC1 on a Linux server
> > Mysql on Linux
> > RBTools 0.2 on Windows
>
> > --
> > Want to help the Review Board project? Donate today at
> >http://www.reviewboard.org/donate/
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~--~~~~--~~--~--~---
> > To unsubscribe from this group, send email to
> > reviewboard+unsubscr...@googlegroups.com
> > For more options, visit this group at
> >http://groups.google.com/group/reviewboard?hl=en- Hide quoted text -
>
> - Show quoted text -
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Files in Patch not the same as files in view diff
I don't see any files attached. Which files were shown in the diff viewer? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Aug 18, 2010 at 2:35 PM, tag_98007work wrote: > I uploaded a changelist with 2 files in it: Code Review Checklist.txt, > place_holder > > When I view the diff throught the View Diff button the files displayed > are not the files from the changelist. The diff in the download diff > is correct. > > I uploaded the files: cl285668_viewdiff.txt so you can see what's > visiable on the view diff button. > cl285668bug.path is what's visable on the > download diff. This one is correct. > > > I'm running RB 1.5 RC1 on a Linux server > Mysql on Linux > RBTools 0.2 on Windows > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Files in Patch not the same as files in view diff
I uploaded a changelist with 2 files in it: Code Review Checklist.txt, place_holder When I view the diff throught the View Diff button the files displayed are not the files from the changelist. The diff in the download diff is correct. I uploaded the files: cl285668_viewdiff.txt so you can see what's visiable on the view diff button. cl285668bug.path is what's visable on the download diff. This one is correct. I'm running RB 1.5 RC1 on a Linux server Mysql on Linux RBTools 0.2 on Windows -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
