How to create a review containing multiple diffs (changesets) separately?

2011-11-09 Thread Long VU
We use mercurial.

In order to have a meaningful and concise description for each
changeset, we usually split a bug fix or a feature implementation in
multiple changesets. This workflow helps the reviewer as it is clear
what the developer wants to do at each step.

Using post-review to create a review of all outgoing changesets, it
folds all changesets into one gigantic diff which makes it hard for
the reviewer to understand the sequence of steps toward the solution,
reducing the chance to discover a step is incorrect. For a new
developer, it is harder to learn from a gigantic diff than from a
series of concise diff with a clear description.

So my question is how do we create one single review, listing each
changeset separately with its respective description and also allow
separate commenting for each changeset? We still want to have all
those changesets part of once single review because they are related
to the same bug/feature.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: How to create a review containing multiple diffs (changesets) separately?

2011-11-09 Thread David Trowbridge
This isn't really possible right now. We've been discussing how we might
support patch series but it's a long-term goal.

There are a few ways that I've seen people cope:
(a) post each change in the series as a successive diff, so you can use
interdiffs to see what changed each time.
(b) post each change in the series as a separate change using post-review's
--parent option, which would give you a separate review request for each
piece.
(c) Do an iterative approach where only the first change in the series
is posted,
and then once review is done, it's pushed and the second change is posted,
etc.

-David



On Wed, Nov 9, 2011 at 4:24 PM, Long VU t.long...@gmail.com wrote:
 We use mercurial.

 In order to have a meaningful and concise description for each
 changeset, we usually split a bug fix or a feature implementation in
 multiple changesets. This workflow helps the reviewer as it is clear
 what the developer wants to do at each step.

 Using post-review to create a review of all outgoing changesets, it
 folds all changesets into one gigantic diff which makes it hard for
 the reviewer to understand the sequence of steps toward the solution,
 reducing the chance to discover a step is incorrect. For a new
 developer, it is harder to learn from a gigantic diff than from a
 series of concise diff with a clear description.

 So my question is how do we create one single review, listing each
 changeset separately with its respective description and also allow
 separate commenting for each changeset? We still want to have all
 those changesets part of once single review because they are related
 to the same bug/feature.

 --
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en