How to make forcing pre-commit review

2009-12-14 Thread JohnHenry
Hi,all,
It seems that the ReviewBoard help Review code with a Human
positive process, But somtimes a programmer may lazy to make code
review process and commit his code directly. So is there any way to
force all RB users in a ReviewGroup to make pre-commit review? say, If
somebody write new code and commit to CVS without doing pre-commit
review request, or if not all his Reviewers admit his commit, His cvs
commit operation would come into false.


Best Regards!

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: How to make forcing pre-commit review

2009-12-14 Thread Scott Quesnelle
With CVS you can write pre-commit scripts. In our repository, we are
required to input a valid defect ID as the first item in the commit log. CVS
looks up that defect ID and checks for the results of a review request.
Alternatively, you could require the developers to include the review id in
the commit log, then it is easy to look it up on reviewboard.

Scott

On Mon, Dec 14, 2009 at 6:49 AM, JohnHenry qhlonl...@163.com wrote:

 Hi,all,
It seems that the ReviewBoard help Review code with a Human
 positive process, But somtimes a programmer may lazy to make code
 review process and commit his code directly. So is there any way to
 force all RB users in a ReviewGroup to make pre-commit review? say, If
 somebody write new code and commit to CVS without doing pre-commit
 review request, or if not all his Reviewers admit his commit, His cvs
 commit operation would come into false.


 Best Regards!

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en