Re: Inline diffs for text-like binary files

2016-04-15 Thread Christian Hammond
Hi Terry,

This isn't something that we can support today, since the diff viewer
expects the diff is going to reference a text-based file it can pull from
the repository and patch against.

You can always upload the text file itself as a file attachment, but it's
not ideal for your case, I imagine.

We are planning on some fancier diff support in probably Review Board 3.5
(3.0 is the upcoming release) that would allow us to do smarter things in
the diff viewer for non-text files, and having Power Pack take advantage of
that to do some better visualization of Office-based files.

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Fri, Apr 15, 2016 at 2:51 PM, Dunnigan, Terrence J <
terrence.j.dunni...@boeing.com> wrote:

> Is it possible to configure Review Board to display diffs via the diff
> viewer for text-like binary files (e.g. MS Office files)?
>
>
>
> I ask because Git for Windows includes scripts to convert binary Word
> files to text in order to perform a diff. So when we run RB Tools on
> Windows, it will generate a valid diff file when diffing two Word
> documents. But when we upload the diff to Review Board 1.7.27, we get
> errors because git on linux doesn’t appear to have those same scripts.
>
>
>
> Has anyone else encountered or resolved this issue?
>
>
>
> Terry
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Inline diffs for text-like binary files

2016-04-15 Thread Dunnigan, Terrence J
Is it possible to configure Review Board to display diffs via the diff viewer 
for text-like binary files (e.g. MS Office files)?

I ask because Git for Windows includes scripts to convert binary Word files to 
text in order to perform a diff. So when we run RB Tools on Windows, it will 
generate a valid diff file when diffing two Word documents. But when we upload 
the diff to Review Board 1.7.27, we get errors because git on linux doesn't 
appear to have those same scripts.

Has anyone else encountered or resolved this issue?

Terry

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.