Re: Line context in comments
We don't show additional context right now (I suppose we could consider adding such an option), but are you aware of multi-line comments? If the comment applies to a block of code more than one line in length, you can click and drag to specify all the relevant lines. This lets the reviewer decide how much context is necessary, and if you're not using it already, would probably go a long way towards solving your problem. -David On Fri, Jan 6, 2012 at 5:24 PM, Marco ma...@snaplogic.com wrote: Hi, here we all love RB, and use it happily. However, there's one feature missing that drives us nuts: in review mode, when going through the reviewer's comments, only the actual line the comment is relative to is displayed. Often, it would be very useful to be able to see the 'context' of the line (eg, a couple of lines above and below) but we seem unable to find an option that would allow us to enable that, so we're assuming that's not possible. One colleagues suggested, as a workaround, that we have 3 monitors: one for the review, one for the diff, and the third for Eclipse/emacs/ vim whatever - is that about right? If you guys could implement this (or suggest a workaround that does not treble our IT budget) that'd be most appreciated! Thanks, Marco. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Line context in comments
We actually have the same issues and do use multi-line comments. Multi-line comments are fit when the comment applies to the whole block in our case. I see what you mean, but it's a confusing option to use for us. On Jan 6, 2012 8:01 PM, David Trowbridge trowb...@gmail.com wrote: We don't show additional context right now (I suppose we could consider adding such an option), but are you aware of multi-line comments? If the comment applies to a block of code more than one line in length, you can click and drag to specify all the relevant lines. This lets the reviewer decide how much context is necessary, and if you're not using it already, would probably go a long way towards solving your problem. -David On Fri, Jan 6, 2012 at 5:24 PM, Marco ma...@snaplogic.com wrote: Hi, here we all love RB, and use it happily. However, there's one feature missing that drives us nuts: in review mode, when going through the reviewer's comments, only the actual line the comment is relative to is displayed. Often, it would be very useful to be able to see the 'context' of the line (eg, a couple of lines above and below) but we seem unable to find an option that would allow us to enable that, so we're assuming that's not possible. One colleagues suggested, as a workaround, that we have 3 monitors: one for the review, one for the diff, and the third for Eclipse/emacs/ vim whatever - is that about right? If you guys could implement this (or suggest a workaround that does not treble our IT budget) that'd be most appreciated! Thanks, Marco. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Line context in comments
Can you file an enhancement request in the bug tracker? -David On Fri, Jan 6, 2012 at 6:44 PM, Chris Tooley ch...@tooley.com wrote: We actually have the same issues and do use multi-line comments. Multi-line comments are fit when the comment applies to the whole block in our case. I see what you mean, but it's a confusing option to use for us. On Jan 6, 2012 8:01 PM, David Trowbridge trowb...@gmail.com wrote: We don't show additional context right now (I suppose we could consider adding such an option), but are you aware of multi-line comments? If the comment applies to a block of code more than one line in length, you can click and drag to specify all the relevant lines. This lets the reviewer decide how much context is necessary, and if you're not using it already, would probably go a long way towards solving your problem. -David On Fri, Jan 6, 2012 at 5:24 PM, Marco ma...@snaplogic.com wrote: Hi, here we all love RB, and use it happily. However, there's one feature missing that drives us nuts: in review mode, when going through the reviewer's comments, only the actual line the comment is relative to is displayed. Often, it would be very useful to be able to see the 'context' of the line (eg, a couple of lines above and below) but we seem unable to find an option that would allow us to enable that, so we're assuming that's not possible. One colleagues suggested, as a workaround, that we have 3 monitors: one for the review, one for the diff, and the third for Eclipse/emacs/ vim whatever - is that about right? If you guys could implement this (or suggest a workaround that does not treble our IT budget) that'd be most appreciated! Thanks, Marco. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
