Preventing commits from going through if status is still in review stage

2011-09-12 Thread james
Is there documentation on how to set this up with post-commit or pre- commit hooks where a user can't push changes into the repository unless the changeset has been reviewed and approved? I'm using git as our repo and so far I've gotten as far as being able to use post-review to submit a review

Re: Preventing commits from going through if status is still in review stage

2011-09-12 Thread Christian Hammond
There's nothing we provide, as it varies quite a bit between installs, repository types, etc. Right now anything you do requires a fair bit of custom code. We're working on a formal Python API for Review Board, which will make this easier from a development standpoint. From a workflow

Re: Preventing commits from going through if status is still in review stage

2011-09-12 Thread james
The Python API or even a Restful call to the reviewboard would be nice. Then I could probably call reviewboard from a curl and check on the changeset status. For instance this is my git log: --- SNIPPET --- commit 08c36a414d56a7e1db26bfd7f5fabe2cb9d0aff7 Author: james

Re: Preventing commits from going through if status is still in review stage

2011-09-12 Thread Christian Hammond
No, not necessarily. When you post a diff, it generates a squashed diff, whichay mean the SHA1 will differ. We also just have no mechanism today to look up a review request by this sort of info. Christian On Monday, September 12, 2011, james james.ngu...@gmail.com wrote: The Python API or even

Re: Preventing commits from going through if status is still in review stage

2011-09-12 Thread james
On Sep 12, 12:35 pm, Christian Hammond chip...@chipx86.com wrote: No, not necessarily. When you post a diff, it generates a squashed diff, whichay mean the SHA1 will differ. Ah. Got it. We also just have no mechanism today to look up a review request by this sort of info. Yeah. This was