Re: Problems with making post-review not load the system's proxy settings
Thanks, I'll give Python 2.6 a try. The documentation looks promising. Cheers, Tino On Fri, Jan 16, 2009 at 1:51 AM, Florian Föbel arenaweb...@googlemail.comwrote: Hi Tino, I got exactly the same problem and solved it with a rather lazy attempt. What I did is to unset the proxy environment variable directly in post-review using the following line of code added right at the beginning of the script: os.environ['http_proxy'] = '' According to the following documentation the problem should also be fixed with Python 2.6: http://docs.python.org/library/urllib.html Regards, Florian --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Problems with making post-review not load the system's proxy settings
Hi, We use Review Board within our group on a local server. Do get outside of the network we need to pass a proxy. That's why everybody usually has set http_proxy and no_proxy environment variables. Unfortunately the Python library urllib, which post-review uses to get the proxy settings of the system, does not check the no_proxy variable. This leads to 500 errors when I try to access the reviewboard server. A quick workaround is to surround the post-review call with 'unset http_proxy' and 'set http_proxy'. This works fine for most team members except for those with Macs. When running on a Mac urllib even checks the systems internet configuration, which is not that easy to alter. I tried to add a no_proxy switch to the post-review script (diff attached), but with this the script won't be able to authenticate anymore. Does anybody have an idea how to make that work properly? Thanks, Tino --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- add_no_proxy_support_to_postreview.diff Description: Binary data
