Re: Is there any flexibility to change the diff format for a review?

2010-03-23 Thread James McDougall
Thank you all - some useful ideas in there which I'll discuss my end. James On Mar 22, 9:46 pm, Christian Hammond chip...@chipx86.com wrote: It depends on the type of repository and the authentication mechanism. For Git, for example, you may not be able to easily do this. Having Review Board

Re: Is there any flexibility to change the diff format for a review?

2010-03-22 Thread Noah Campbell
I think the short answer is no, but the masters of RB should chime in. The reason being the view and diff technology are unique to RB. -Noah On Mon, Mar 22, 2010 at 4:56 AM, James McDougall jamesmcdoug...@gmail.com wrote: We have previously been using WinDiff (see

Re: Is there any flexibility to change the diff format for a review?

2010-03-22 Thread Christian Hammond
It's very likely that we'll have an API function in 1.5 for downloading a full file. No UI, at least for 1.5, but if someone really wanted a script that ran the diff through some external tool, it could use the API. Christian -- Christian Hammond - chip...@chipx86.com Review Board -

Re: Is there any flexibility to change the diff format for a review?

2010-03-22 Thread Noah Campbell
Can't you use the URLs from RB and your SCM (assuming you have the web access available?) -Noah On Mon, Mar 22, 2010 at 2:35 PM, Christian Hammond chip...@chipx86.com wrote: It's very likely that we'll have an API function in 1.5 for downloading a full file. No UI, at least for 1.5, but if

Re: Is there any flexibility to change the diff format for a review?

2010-03-22 Thread Christian Hammond
It depends on the type of repository and the authentication mechanism. For Git, for example, you may not be able to easily do this. Having Review Board proxy this is probably ideal, and keeps the details of the repository away from the caller. Christian -- Christian Hammond -