Re: Is there any flexibility to change the diff format for a review?
Thank you all - some useful ideas in there which I'll discuss my end. James On Mar 22, 9:46 pm, Christian Hammond chip...@chipx86.com wrote: It depends on the type of repository and the authentication mechanism. For Git, for example, you may not be able to easily do this. Having Review Board proxy this is probably ideal, and keeps the details of the repository away from the caller. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Mar 22, 2010 at 2:40 PM, Noah Campbell noahcampb...@gmail.comwrote: Can't you use the URLs from RB and your SCM (assuming you have the web access available?) -Noah On Mon, Mar 22, 2010 at 2:35 PM, Christian Hammond chip...@chipx86.com wrote: It's very likely that we'll have an API function in 1.5 for downloading a full file. No UI, at least for 1.5, but if someone really wanted a script that ran the diff through some external tool, it could use the API. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Mar 22, 2010 at 2:33 PM, Dana Lacoste dlaco...@aperio.com wrote: I think that, perhaps, a better approach to this would be to allow the user to download the full modified file (not the patch) so they can use their own diff tool. For example, before I first started with ReviewBoard, I worked with a small internal tool (Python script) which would take a (Perforce) changelist and copy it to a network share in a /changelist/1 folder, copy the “base” Perforce revision to /changelist/base, and prepare an XML file which specified the share location and share number (named something other than .xml so Windows users could associate a command with it) and email that file to interested users. The user would then run a Python script which would read the file and run Araxis Merge (or Beyond Compare or WinDiff or…) against the relevant files. I think this kind of structure would be quite easy to mimic with ReviewBoard if we could simply download the full file, and then users could use any tool they desire to view the diffs (and, for the most part, the RB built in diff is 1239781092378912% easier to use for small changes anyways J ) Dana Lacoste PS: I know that “download the full file” is a feature on the backlog for some future release J From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com ] On Behalf Of Christian Hammond Sent: Monday, March 22, 2010 12:00 PM To: reviewboard@googlegroups.com Subject: Re: Is there any flexibility to change the diff format for a review? Right, we have our own pretty specific diff viewer. It's very much a side-by-side viewer right now and it would take a lot of work to change that. It's not a priority given other work and not likely to happen in the near future. Especially not before 2.0. In theory, after 2.0 someone could write a replacement diff viewer that does a more WinDiff-style view. It'll be a while before 2.0 is out, though. Christian -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+ unsubscribegooglegroups.com or
Re: Is there any flexibility to change the diff format for a review?
I think the short answer is no, but the masters of RB should chime in. The reason being the view and diff technology are unique to RB. -Noah On Mon, Mar 22, 2010 at 4:56 AM, James McDougall jamesmcdoug...@gmail.com wrote: We have previously been using WinDiff (see http://en.wikipedia.org/wiki/File:WinDiff_demonstration.png for example of output) and I have had several folk asking if there are alternatives to the side-by-side approach taken by ReviewBoard - specifically the format used by WinDiff. It's not clear to me how customisable this kind of output is or whether the review function is totally tied to the existing layout. Thanks -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject.
Re: Is there any flexibility to change the diff format for a review?
It's very likely that we'll have an API function in 1.5 for downloading a full file. No UI, at least for 1.5, but if someone really wanted a script that ran the diff through some external tool, it could use the API. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Mar 22, 2010 at 2:33 PM, Dana Lacoste dlaco...@aperio.com wrote: I think that, perhaps, a better approach to this would be to allow the user to download the full modified file (not the patch) so they can use their own diff tool. For example, before I first started with ReviewBoard, I worked with a small internal tool (Python script) which would take a (Perforce) changelist and copy it to a network share in a /changelist/1 folder, copy the “base” Perforce revision to /changelist/base, and prepare an XML file which specified the share location and share number (named something other than .xml so Windows users could associate a command with it) and email that file to interested users. The user would then run a Python script which would read the file and run Araxis Merge (or Beyond Compare or WinDiff or…) against the relevant files. I think this kind of structure would be quite easy to mimic with ReviewBoard if we could simply download the full file, and then users could use any tool they desire to view the diffs (and, for the most part, the RB built in diff is 1239781092378912% easier to use for small changes anyways J ) Dana Lacoste PS: I know that “download the full file” is a feature on the backlog for some future release J *From:* reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] *On Behalf Of *Christian Hammond *Sent:* Monday, March 22, 2010 12:00 PM *To:* reviewboard@googlegroups.com *Subject:* Re: Is there any flexibility to change the diff format for a review? Right, we have our own pretty specific diff viewer. It's very much a side-by-side viewer right now and it would take a lot of work to change that. It's not a priority given other work and not likely to happen in the near future. Especially not before 2.0. In theory, after 2.0 someone could write a replacement diff viewer that does a more WinDiff-style view. It'll be a while before 2.0 is out, though. Christian -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+ unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject.
Re: Is there any flexibility to change the diff format for a review?
Can't you use the URLs from RB and your SCM (assuming you have the web access available?) -Noah On Mon, Mar 22, 2010 at 2:35 PM, Christian Hammond chip...@chipx86.com wrote: It's very likely that we'll have an API function in 1.5 for downloading a full file. No UI, at least for 1.5, but if someone really wanted a script that ran the diff through some external tool, it could use the API. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Mar 22, 2010 at 2:33 PM, Dana Lacoste dlaco...@aperio.com wrote: I think that, perhaps, a better approach to this would be to allow the user to download the full modified file (not the patch) so they can use their own diff tool. For example, before I first started with ReviewBoard, I worked with a small internal tool (Python script) which would take a (Perforce) changelist and copy it to a network share in a /changelist/1 folder, copy the “base” Perforce revision to /changelist/base, and prepare an XML file which specified the share location and share number (named something other than .xml so Windows users could associate a command with it) and email that file to interested users. The user would then run a Python script which would read the file and run Araxis Merge (or Beyond Compare or WinDiff or…) against the relevant files. I think this kind of structure would be quite easy to mimic with ReviewBoard if we could simply download the full file, and then users could use any tool they desire to view the diffs (and, for the most part, the RB built in diff is 1239781092378912% easier to use for small changes anyways J ) Dana Lacoste PS: I know that “download the full file” is a feature on the backlog for some future release J From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Christian Hammond Sent: Monday, March 22, 2010 12:00 PM To: reviewboard@googlegroups.com Subject: Re: Is there any flexibility to change the diff format for a review? Right, we have our own pretty specific diff viewer. It's very much a side-by-side viewer right now and it would take a lot of work to change that. It's not a priority given other work and not likely to happen in the near future. Especially not before 2.0. In theory, after 2.0 someone could write a replacement diff viewer that does a more WinDiff-style view. It'll be a while before 2.0 is out, though. Christian -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject.
Re: Is there any flexibility to change the diff format for a review?
It depends on the type of repository and the authentication mechanism. For Git, for example, you may not be able to easily do this. Having Review Board proxy this is probably ideal, and keeps the details of the repository away from the caller. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Mar 22, 2010 at 2:40 PM, Noah Campbell noahcampb...@gmail.comwrote: Can't you use the URLs from RB and your SCM (assuming you have the web access available?) -Noah On Mon, Mar 22, 2010 at 2:35 PM, Christian Hammond chip...@chipx86.com wrote: It's very likely that we'll have an API function in 1.5 for downloading a full file. No UI, at least for 1.5, but if someone really wanted a script that ran the diff through some external tool, it could use the API. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Mar 22, 2010 at 2:33 PM, Dana Lacoste dlaco...@aperio.com wrote: I think that, perhaps, a better approach to this would be to allow the user to download the full modified file (not the patch) so they can use their own diff tool. For example, before I first started with ReviewBoard, I worked with a small internal tool (Python script) which would take a (Perforce) changelist and copy it to a network share in a /changelist/1 folder, copy the “base” Perforce revision to /changelist/base, and prepare an XML file which specified the share location and share number (named something other than .xml so Windows users could associate a command with it) and email that file to interested users. The user would then run a Python script which would read the file and run Araxis Merge (or Beyond Compare or WinDiff or…) against the relevant files. I think this kind of structure would be quite easy to mimic with ReviewBoard if we could simply download the full file, and then users could use any tool they desire to view the diffs (and, for the most part, the RB built in diff is 1239781092378912% easier to use for small changes anyways J ) Dana Lacoste PS: I know that “download the full file” is a feature on the backlog for some future release J From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com ] On Behalf Of Christian Hammond Sent: Monday, March 22, 2010 12:00 PM To: reviewboard@googlegroups.com Subject: Re: Is there any flexibility to change the diff format for a review? Right, we have our own pretty specific diff viewer. It's very much a side-by-side viewer right now and it would take a lot of work to change that. It's not a priority given other work and not likely to happen in the near future. Especially not before 2.0. In theory, after 2.0 someone could write a replacement diff viewer that does a more WinDiff-style view. It'll be a while before 2.0 is out, though. Christian -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+ unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at
