Re: Submitting patches, subversion post-review support for already committed revisions

2012-10-25 Thread Adam Badura
Hi, Same problem here with RB 1.6.11. When posting a review request with revistion that includes renaming some files i get this: (Not a versioned resource)\n', '\n', 'svn: A problem occurred; see other errors for details\n' Any news here? W dniu środa, 9 grudnia 2009 23:01:28 UTC+1

RE: Submitting patches, subversion post-review support for already committed revisions

2010-01-12 Thread Bickford, Mark
: Submitting patches, subversion post-review support for already committed revisions It seems that this broke at some point. I've been meaning to look into it but haven't really had the time lately. I believe it's due to us being a little more smart now with SVN diffs and going through trying

Re: Submitting patches, subversion post-review support for already committed revisions

2009-12-09 Thread Jason Felice
On Wed, Dec 9, 2009 at 5:01 PM, Lyndon Washington hoshp...@crazy-code.com wrote: Hi, Was there a resolution to the svn problem that was outlined, because I get a similar problem after I performed a commit that included some moved and deleted source files. When i try and create a review

Re: Submitting patches, subversion post-review support for already committed revisions

2009-12-09 Thread Christian Hammond
It seems that this broke at some point. I've been meaning to look into it but haven't really had the time lately. I believe it's due to us being a little more smart now with SVN diffs and going through trying to grab info on the affected files. We need to handle the moves/renames properly.

Re: Submitting patches, subversion post-review support for already committed revisions

2009-12-03 Thread Jason Felice
On Thu, Dec 3, 2009 at 1:54 AM, Christian Hammond chip...@chipx86.com wrote: Hi Jason, A standard diff -u doesn't contain the revision information needed, and a git diff by default uses short SHA1s, which we can't use to fetch the files. You will need to use either post-review (recommended)

Re: Submitting patches, subversion post-review support for already committed revisions

2009-12-02 Thread Christian Hammond
Hi Jason, A standard diff -u doesn't contain the revision information needed, and a git diff by default uses short SHA1s, which we can't use to fetch the files. You will need to use either post-review (recommended) or git diff --full-index. post-review with Subversion should support renames and