Hi Keith,

You shouldn't be seeing that behavior. Can you check the browser's
JavaScript console to see if there are any errors? We don't rely on the
anchors themselves to jump. It's handled in JavaScript.

Also, what version are you using?

(Agreed that "target" isn't the right attribute for us to be using.. I
think that was left over from the original contribution. Still, it
shouldn't technically matter.)

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com


On Tue, Sep 17, 2013 at 7:23 AM, Keith Moyer <goo...@keithmoyer.com> wrote:

> This seems basic enough that I would think it's been answered numerous
> times, but for the life of me I can't find a bug report nor an explanation
> on why it behaves the way it does.
>
> When a changeset includes moved lines of code, they are marked with "Moved
> to" and "Moved from" tags (very useful!).  These tags are linked, but they
> do not behave in a reasonable manner.  Instead of the "Moved to" link
> linking to the place the code was moved to, it opens up a new window
> (placed at the top of the page).
>
> The anchor tag has strange attributes, with a "target" property consisting
> of the line number the code was moved to and a "line" property consisting
> of the current line number.  Because "target" has a specific meaning for
> anchor tags, and this is not what it is being used as, the strange behavior
> is invoked.
>
> Could somebody help me understand why this behavior was chosen, point me
> to a bug report to follow, or indicate this is a "new" bug?
>
> Thanks!
>
>  - Keith
>
> --
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to