Re: 401 Unauthorized when creating a review from an existing git commit on repo hosted via GitLab

2015-12-01 Thread Younes Manton
I found the patch, applied it, and it solves the problem. Thanks.

https://reviews.reviewboard.org/r/7768/ in case anyone else is interested.

On Tuesday, 1 December 2015 16:16:49 UTC-5, David Trowbridge wrote:
>
> Hi,
>
> This is a known issue which is already fixed in git, and will ship in 
> 2.5.2.
>
> -David
>
> On Tue, Dec 1, 2015 at 12:37 PM Younes Manton  > wrote:
>
>> Hi,
>>
>> I'm trying to set up RB 2.5.1.1 and thus far everything seems to work, 
>> except when I try to create a review request from an existing git commit on 
>> a repo hosted via GitLab. RB seems to have no trouble accessing the repo 
>> for the most part, all of the commits to the repo show up in RB. Creating a 
>> new review request by clicking on one of the commits results in a review 
>> request without any diff and the following is emitted to the log:
>>
>> 2015-12-01 19:57:48,168 - ERROR -  - Unable to update new review request 
>> from commit ID 73fa5...8132: HTTP Error 401: Unauthorized
>> Traceback (most recent call last):
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.1.1-py2.6.egg/reviewboard/reviews/managers.py",
>>  
>> line 150, in create
>> review_request.update_from_commit_id(commit_id)
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.1.1-py2.6.egg/reviewboard/reviews/models/base_review_request_details.py",
>>  
>> line 220, in update_from_commit_id
>> self.update_from_committed_change(commit_id)
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.1.1-py2.6.egg/reviewboard/reviews/models/base_review_request_details.py",
>>  
>> line 264, in update_from_committed_change
>> commit = self.repository.get_change(commit_id)
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.1.1-py2.6.egg/reviewboard/scmtools/models.py",
>>  
>> line 450, in get_change
>> return hosting_service.get_change(self, revision)
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.1.1-py2.6.egg/reviewboard/hostingsvcs/gitlab.py",
>>  
>> line 317, in get_change
>> headers={'Accept': 'text/plain'})
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.1.1-py2.6.egg/reviewboard/hostingsvcs/service.py",
>>  
>> line 55, in http_get
>> return self.http_request(url, method='GET', **kwargs)
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.1.1-py2.6.egg/reviewboard/hostingsvcs/service.py",
>>  
>> line 79, in http_request
>> u = urlopen(r)
>>   File "/usr/lib64/python2.6/urllib2.py", line 126, in urlopen
>> return _opener.open(url, data, timeout)
>>   File "/usr/lib64/python2.6/urllib2.py", line 397, in open
>> response = meth(req, response)
>>   File "/usr/lib64/python2.6/urllib2.py", line 510, in http_response
>> 'http', request, response, code, msg, hdrs)
>>   File "/usr/lib64/python2.6/urllib2.py", line 435, in error
>> return self._call_chain(*args)
>>   File "/usr/lib64/python2.6/urllib2.py", line 369, in _call_chain
>> result = func(*args)
>>   File "/usr/lib64/python2.6/urllib2.py", line 518, in http_error_default
>> raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
>> HTTPError: HTTP Error 401: Unauthorized
>>
>> Commit ID 73fa5...8132 does in fact exist and is viewable in the GitLab 
>> web interface. Also, uploading a diff works just fine.
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
> -- 
> -David 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: 401 Unauthorized when creating a review from an existing git commit on repo hosted via GitLab

2015-12-01 Thread David Trowbridge
Hi,

This is a known issue which is already fixed in git, and will ship in 2.5.2.

-David

On Tue, Dec 1, 2015 at 12:37 PM Younes Manton  wrote:

> Hi,
>
> I'm trying to set up RB 2.5.1.1 and thus far everything seems to work,
> except when I try to create a review request from an existing git commit on
> a repo hosted via GitLab. RB seems to have no trouble accessing the repo
> for the most part, all of the commits to the repo show up in RB. Creating a
> new review request by clicking on one of the commits results in a review
> request without any diff and the following is emitted to the log:
>
> 2015-12-01 19:57:48,168 - ERROR -  - Unable to update new review request
> from commit ID 73fa5...8132: HTTP Error 401: Unauthorized
> Traceback (most recent call last):
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.1.1-py2.6.egg/reviewboard/reviews/managers.py",
> line 150, in create
> review_request.update_from_commit_id(commit_id)
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.1.1-py2.6.egg/reviewboard/reviews/models/base_review_request_details.py",
> line 220, in update_from_commit_id
> self.update_from_committed_change(commit_id)
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.1.1-py2.6.egg/reviewboard/reviews/models/base_review_request_details.py",
> line 264, in update_from_committed_change
> commit = self.repository.get_change(commit_id)
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.1.1-py2.6.egg/reviewboard/scmtools/models.py",
> line 450, in get_change
> return hosting_service.get_change(self, revision)
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.1.1-py2.6.egg/reviewboard/hostingsvcs/gitlab.py",
> line 317, in get_change
> headers={'Accept': 'text/plain'})
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.1.1-py2.6.egg/reviewboard/hostingsvcs/service.py",
> line 55, in http_get
> return self.http_request(url, method='GET', **kwargs)
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.1.1-py2.6.egg/reviewboard/hostingsvcs/service.py",
> line 79, in http_request
> u = urlopen(r)
>   File "/usr/lib64/python2.6/urllib2.py", line 126, in urlopen
> return _opener.open(url, data, timeout)
>   File "/usr/lib64/python2.6/urllib2.py", line 397, in open
> response = meth(req, response)
>   File "/usr/lib64/python2.6/urllib2.py", line 510, in http_response
> 'http', request, response, code, msg, hdrs)
>   File "/usr/lib64/python2.6/urllib2.py", line 435, in error
> return self._call_chain(*args)
>   File "/usr/lib64/python2.6/urllib2.py", line 369, in _call_chain
> result = func(*args)
>   File "/usr/lib64/python2.6/urllib2.py", line 518, in http_error_default
> raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
> HTTPError: HTTP Error 401: Unauthorized
>
> Commit ID 73fa5...8132 does in fact exist and is viewable in the GitLab
> web interface. Also, uploading a diff works just fine.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-David

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.