On Mon, Oct 6, 2008 at 5:47 PM, Chris Clark <[EMAIL PROTECTED]> wrote:
> On Oct 6, 5:26 pm, "Christian Hammond" <[EMAIL PROTECTED]> wrote: > > It's possible in that one could modify the code to add this > functionality. > > However, I wouldn't add support to show the entire raw diff in the > upstream > > codebase, as that would be quite bad for a lot of people (some diffs can > get > > very large). > > Trying to clarify here, do you mean no diffs at all, or no diffs in > the template? I'd rather not modify Review Board to include the diff at all in the e-mail template or as an attachment. We've had diffs at VMware that have been quite large (megabytes in size), and I know other places have as well, and this would certainly put strain on the mail servers. I guess I wouldn't be too upset with a preference (defaulted to off) that did include the diff in the template, but I might need more convincing. The link to the raw diff is right there in the e-mail and should be easy for anyone to open, but I know that convincing people to use a new product for something like code review does mean making them feel comfortable using it. If you want to provide a patch that introduces such a preference and then support it in the e-mail code and templates, I'll review it. I know this doesn't help for right now, but down the road a bit (and there's already a bunch of code for this) we'll be introducing Extension support, which would allow people to replace or ammend functionality in Review Board. E-mail being one of these things. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
