Re: Added Files not being added to reviews
Try running "svn add" on those files and making sure it knows about them. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Jul 25, 2011 at 11:06 AM, Leonel Togniolli wrote: > Issue 2188 logged for the feature request. > > Sorry, meant to include the info but forgot. It's on SVN. The file > shows as added the TortoiseSVN's "check for modifications" dialog. > > "post-review -d" didn't seem to show anything interesting. > > On Mon, Jul 25, 2011 at 2:21 PM, Christian Hammond > wrote: > > Hi Leonel, > > > > What sort of repository are you using this with? We generally call out to > > svn diff, git diff, etc., so it's dependent on how the particular SCM > works. > > > > Can you file the feature request on the bug tracker? > > > > Christian > > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board - http://www.reviewboard.org > > VMware, Inc. - http://www.vmware.com > > > > > > On Mon, Jul 25, 2011 at 7:42 AM, Leonel Togniolli > > wrote: > >> > >> Hi, > >> > >> After upgrading to 1.6 RC1 and RBTools 0.3, I noticed that added files > >> are not included in review requests by post-review. If I call > >> post-review specifying the added-file filename, I get "There don't > >> seem to be any diffs!". Is this intentional? > >> > >> While I'm at it, a feature request: the ability to configure an ignore > >> list for post-review. Right now I have some files that get changed > >> locally automatically but are not commited. Right now I have to > >> manually revert them before calling post-review, or post-review a > >> specific file/folder without them. > >> > >> -- > >> Leonel > >> > >> -- > >> Want to help the Review Board project? Donate today at > >> http://www.reviewboard.org/donate/ > >> Happy user? Let us know at http://www.reviewboard.org/users/ > >> -~--~~~~--~~--~--~--- > >> To unsubscribe from this group, send email to > >> reviewboard+unsubscr...@googlegroups.com > >> For more options, visit this group at > >> http://groups.google.com/group/reviewboard?hl=en > > > > -- > > Want to help the Review Board project? Donate today at > > http://www.reviewboard.org/donate/ > > Happy user? Let us know at http://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > > http://groups.google.com/group/reviewboard?hl=en > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Added Files not being added to reviews
Issue 2188 logged for the feature request. Sorry, meant to include the info but forgot. It's on SVN. The file shows as added the TortoiseSVN's "check for modifications" dialog. "post-review -d" didn't seem to show anything interesting. On Mon, Jul 25, 2011 at 2:21 PM, Christian Hammond wrote: > Hi Leonel, > > What sort of repository are you using this with? We generally call out to > svn diff, git diff, etc., so it's dependent on how the particular SCM works. > > Can you file the feature request on the bug tracker? > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > On Mon, Jul 25, 2011 at 7:42 AM, Leonel Togniolli > wrote: >> >> Hi, >> >> After upgrading to 1.6 RC1 and RBTools 0.3, I noticed that added files >> are not included in review requests by post-review. If I call >> post-review specifying the added-file filename, I get "There don't >> seem to be any diffs!". Is this intentional? >> >> While I'm at it, a feature request: the ability to configure an ignore >> list for post-review. Right now I have some files that get changed >> locally automatically but are not commited. Right now I have to >> manually revert them before calling post-review, or post-review a >> specific file/folder without them. >> >> -- >> Leonel >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~--~~~~--~~--~--~--- >> To unsubscribe from this group, send email to >> reviewboard+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Added Files not being added to reviews
Hi Leonel, What sort of repository are you using this with? We generally call out to svn diff, git diff, etc., so it's dependent on how the particular SCM works. Can you file the feature request on the bug tracker? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Jul 25, 2011 at 7:42 AM, Leonel Togniolli wrote: > Hi, > > After upgrading to 1.6 RC1 and RBTools 0.3, I noticed that added files > are not included in review requests by post-review. If I call > post-review specifying the added-file filename, I get "There don't > seem to be any diffs!". Is this intentional? > > While I'm at it, a feature request: the ability to configure an ignore > list for post-review. Right now I have some files that get changed > locally automatically but are not commited. Right now I have to > manually revert them before calling post-review, or post-review a > specific file/folder without them. > > -- > Leonel > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
