The problem is likely that the file is being marked as a text file rather than a binary file in Perforce. As such, we end up getting a text diff, which we completely will fail to handle. The Perforce administrator needs to make sure word documents are always listed as binary files. I don't know the steps necessary for that, not being a Perforce admin.
Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Nov 2, 2009 at 3:55 PM, Kunjal <kunjal.par...@gmail.com> wrote: > > Hello, > > we have RB 1.0.3-Perforce setup. > I created pending CL with word document. When I post the review, it > did post the review successfully. > But when I click on View Diff, on my first try I get below message: > > The patch to 'c:/Perforce/Sources/Integration/Automation_Scripts/ > ClearQuest_Documents/4weewrewrewr.doc' didn't apply cleanly. The > temporary files have been left in '/tmp/reviewboard.0_p4v9' for > debugging purposes. `patch` returned: patching file /tmp/reviewboard. > 0_p4v9/tmpnshHiq patch: **** malformed patch at line 5: > Traceback (most recent call last): > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ > views.py", line 152, in view_diff > interdiffset, highlighting, True) > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ > diffutils.py", line 623, in get_diff_files > large_data=True) > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > packages/Djblets-0.5.3-py2.5.egg/djblets/util/misc.py", line 162, in > cache_memoize > data = lookup_callable() > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ > diffutils.py", line 622, in <lambda> > enable_syntax_highlighting), > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ > diffutils.py", line 345, in get_chunks > new = get_patched_file(old, filediff) > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ > diffutils.py", line 261, in get_patched_file > return patch(filediff.diff, buffer, filediff.dest_file) > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ > diffutils.py", line 129, in patch > (filename, tempdir, patch_output)) > Exception: The patch to 'c:/Perforce/Sources/Integration/ > Automation_Scripts/ClearQuest_Documents/4weewrewrewr.doc' didn't apply > cleanly. The temporary files have been left in '/tmp/reviewboard. > 0_p4v9' for debugging purposes. > `patch` returned: patching file /tmp/reviewboard.0_p4v9/tmpnshHiq > patch: **** malformed patch at line 5: > > > ON MY SECOND TRY WITH NEW PENDING CL, I GOT BELOW MESSAGE WHEN I CLICK > ON VIEW DIFF: > > 'ascii' codec can't decode byte 0xa0 in position 87: ordinal not in > range(128) > Traceback (most recent call last): > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ > views.py", line 152, in view_diff > interdiffset, highlighting, True) > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ > diffutils.py", line 623, in get_diff_files > large_data=True) > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > packages/Djblets-0.5.3-py2.5.egg/djblets/util/misc.py", line 162, in > cache_memoize > data = lookup_callable() > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ > diffutils.py", line 622, in <lambda> > enable_syntax_highlighting), > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ > diffutils.py", line 345, in get_chunks > new = get_patched_file(old, filediff) > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ > diffutils.py", line 261, in get_patched_file > return patch(filediff.diff, buffer, filediff.dest_file) > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ > diffutils.py", line 129, in patch > (filename, tempdir, patch_output)) > UnicodeDecodeError: 'ascii' codec can't decode byte 0xa0 in position > 87: ordinal not in range(128) > > HOW TO FIX THIS ISSUE? > > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -~----------~----~----~----~------~----~------~--~--- > > --~--~---------~--~----~------------~-------~--~----~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
