Hi Justin,

There is no configurable option for this, and there’s unlikely to be one. I 
knew going into this that this wouldn’t be a popular change for everybody 
involved, but I believe it was the right one to make. I’ll go into our reasons 
why:

1. Most review request texts are either hand-written and wrapping at the text 
area boundaries, or pulled in from a commit (which tends to be 80 columns of 
text at most, from our testing — this is also what many other tools out there 
assume). That meant a lot of wasted space on the right in the average case.

2. The fields previously above the review request caused the description and 
testing done to be pushed down, even though those were often the most important 
fields to read. We wanted to bring those higher up, promoting them and reducing 
the need to scroll.

3. It was harder to scan those fields, since you had to read left-to-right, 
top-to-bottom. The new fields are just top-to-bottom, which is easier.

4. A common request was for the ability for extensions to add custom fields. 
This proved really annoying to do with the old design, as extensions had no 
idea what sort of widths they had to work with, or what their placement would 
be. This got even worse with fields that were conditionally visible, since 
fields would shuffle rows and columns depending on the visibility of other 
fields. We wanted to provide a consistent experience for extensions.

5. Wider displays are pretty common for developers, but I know it’s not always 
the case (mobile displays, for instance). With the general 80 columns of text 
that we found to be common (in our own usage and in seeing what others do), we 
picked these widths, which will fit into a 1024x768 display. I’d expect most 
developers would have larger widths than that on their main machines.

Down the road, we may figure out something (collapsing for instance) if the 
screen is small, in order to provide more room for the text, but this would be 
geared more toward mobile devices than desktops.

Anyway, I’m sorry this made things more difficult for your setup, but I think 
overall, it’s a good move.

Can you give me more information on your environment? I’d like to know more 
about it for future consideration.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 22, 2014 at 12:14:51 PM, Justin Fletcher (ge...@gerph.org) wrote:

Hiya,

I am evaluating upgrading to Reviewboard 2.0.2 and one thing the jumped out at 
me as a bad decision was the move of the 'information' section from the top of 
the page on reviews, to the right hand side.

The reasons I feel it to be a bad decision is that:

  * the content of this information section is squashed up on the right, 
wrapping oddly and not being especially readable. Previously this information 
had the full width of the window to be presented.
  * the content of this information section now squeezes the content of the 
description and testing done. Previously the description and testing done had 
the full width of the window and could be more readable because of it.
  * the content of this information section is generally only about as high as 
a part of the description (assuming that the reviewee has written an 
appropriately descriptive description), so the rest of the description and 
testing done section are squeezed left, with a block of dead space to their 
right, because of a small amount of information.

Maybe the users of this tool only use it with very large displays, where these 
issues are not a problem. On smaller displays this becomes increasingly acute 
and obviously bad decision (obviously in my opinion).

Is there a user-configurable option to move the information content back to the 
top of the page, as before. I cannot see one, but in my short time using it I 
may have missed one.

--
Justin Fletcher
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to