Re: Crash while viewing review request

2015-09-09 Thread David Trowbridge
Looks like a fine fix. Can you post this on reviews.reviewboard.org? Thanks! -David On Wed, Sep 9, 2015 at 10:33 AM Alexey Neyman wrote: > FWIW, converting an iterator to list explicitly seems to help. Changed > this line: > > return

Re: Crash while viewing review request

2015-09-09 Thread Alexey Neyman
FWIW, converting an iterator to list explicitly seems to help. Changed this line: return json.dumps(review_ui.serialize_comments( file_attachment.get_comments())) to this return json.dumps(list(review_ui.serialize_comments( file_attachment.get_comments( no crash

Re: Crash while viewing review request

2015-09-09 Thread Christian Hammond
This is actually already fixed for 2.0.20, unless I missed something big. Planning a release in the next few days. Christian -- Christian Hammond - chip...@chipx86.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On Wed, Sep 9, 2015 at 11:58 AM, David