Re: Diffing between revisions is unreliable.

[Jonathan Anderson]

Yes, the differences are changes that I made in patch 2, and they show up 
when viewing orig---2

On Tuesday, March 10, 2015 at 5:38:36 PM UTC-7, David Trowbridge wrote:
>
> Just to confirm, the differences you see starting at line 100 are changes 
> that you made in the patch uploaded as r2? We explicitly don't highlight 
> differences that are only due to upstream changes in the files and not 
> changed hunks in the patch.
>
> -David
>
> On Tue, Mar 10, 2015 at 4:55 PM Jonathan Anderson  > wrote:
>
>> I am using ReviewBoard 2.0.12
>>
>> I posted a code review using with 'rbt post', making changes to multiple 
>> files.
>> Subsequently, I updated two of the files and posted a second revision 
>> with 'rbt post -r 33'.
>>
>> The CR now has 3 versions of each file: orig---1---2
>>
>> Selecting orig---1 shows the correct version 1 diff.
>> Selecting orig---2 shows the correct version 2 diff.
>>
>> But 1---2 only shows changes to one of the two files I changed. For the 
>> other file, it says that only whitespace changes were made. Manually 
>> showing more lines to reveal the file shows that both sides have the 
>> correct (different) versions of the file, but there is no highlighting.
>>
>> What information can I provide to diagnose this issue?
>>
>> Thanks,
>> Jonathan Anderson
>> Quosal LLC
>>
>>
>> As you can see, the file below says the diff only contains whitespace 
>> changes, but at line 100, the files diverge.
>>
>>
>> 
>>
>>
>> 
>>
>>  -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Diffing between revisions is unreliable.

[David Trowbridge]

Just to confirm, the differences you see starting at line 100 are changes
that you made in the patch uploaded as r2? We explicitly don't highlight
differences that are only due to upstream changes in the files and not
changed hunks in the patch.

-David

On Tue, Mar 10, 2015 at 4:55 PM Jonathan Anderson 
wrote:

> I am using ReviewBoard 2.0.12
>
> I posted a code review using with 'rbt post', making changes to multiple
> files.
> Subsequently, I updated two of the files and posted a second revision with
> 'rbt post -r 33'.
>
> The CR now has 3 versions of each file: orig---1---2
>
> Selecting orig---1 shows the correct version 1 diff.
> Selecting orig---2 shows the correct version 2 diff.
>
> But 1---2 only shows changes to one of the two files I changed. For the
> other file, it says that only whitespace changes were made. Manually
> showing more lines to reveal the file shows that both sides have the
> correct (different) versions of the file, but there is no highlighting.
>
> What information can I provide to diagnose this issue?
>
> Thanks,
> Jonathan Anderson
> Quosal LLC
>
>
> As you can see, the file below says the diff only contains whitespace
> changes, but at line 100, the files diverge.
>
>
> 
>
>
> 
>
>  --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.