Re: Diffs and comments don't wrap properly in IE8

2011-02-16 Thread Christian Hammond
Ahh, the text and not the diff... Yeah, that's really weird. I've never seen
that and I don't have a clue why that would be. The styling for that hasn't
changed since the early days. It certainly shouldn't be able to flow out of
its container. I'd chalk it up to an IE bug, but if you wanted to work on a
fix and found out that didn't break other browsers, I'd welcome it.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Wed, Feb 16, 2011 at 11:48 AM, heffe  wrote:

> It's interesting.  At first this morning I couldn't reproduce the problem
> when IE had another window doing something else.  Then after I completely
> exited all IE sessions and tried only viewing the RB diff, I could reproduce
> the problem again.  Attached is a screen shot showing the wrapping problem.
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Diffs and comments don't wrap properly in IE8

2011-02-14 Thread Christian Hammond
Hi,

Can you provide a screenshot?

This is usually caused by really long lines with no word-breaking characters
(such as spaces, "/", etc.). Unfortunately, this is a browser issue, and
there's really nothing we can do about it. IE appears to be the only browser
on the market with this level of brokenness in their word wrapping.

In your case, if it does wrap but is always past the shadow, that's
definitely very odd and I'd love to see what that looks like. It's possible
it's something we can fix, but I don't know.

It'd be interesting if you could reproduce this with some diff on
http://demo.reviewboard.org/.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Mon, Feb 14, 2011 at 10:32 AM, heffe  wrote:

> I manage an RB 1.5.1 installation and have received a user complaint that I
> can reproduce where IE8 doesn't properly wrap the lines of review comments
> or the diff content.  The same page viewed in Firefox displays just fine,
> but when displayed in IE some of the lines don't wrap at the correct spot.
> While those lines do still appear to wrap in IE, they wrap off of the right
> edge of the window so no matter how you resize the window you can never see
> the text that extended beyond the edge.  Has this been seen before?  Any
> idea how this can be fixed?
>
> Thanks!  BTW, been using RB for 1.5 years now, great tool!
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en