Re: Error uploading diff with post-review

2012-04-04 Thread Christian Hammond
Hey,

Looks like you're missing the p4 binary in your path somewhere on the
server.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Wed, Apr 4, 2012 at 6:30 PM, Steven Zhu steven...@gmail.com wrote:

 ** NOTE: Do not post confidential information in this bug report.    
 If you need immediate support, please contact   
 reviewboard@googlegroups.com **
 *What version are you running?*
 RB 1.6.4.1
 RBTOOLS 0.4.1
 *What's the URL of the page containing the problem?*
 N/A
 *What steps will reproduce the problem?*
 1. post-review changenum

 *What is the expected output? What do you see instead?*
  RBTools 0.4.1
  Home = /home/mstar
  HTTP GETting api/
  HTTP GETting http://msstra066-ubuntu/api/info/
  Using the new web API
  HTTP GETting http://msstra066-ubuntu/api/repositories/
  Repositories on Server: [{u'path': u'http://MSSPC1474/svn/rb-test' 
  u'tool': u'Subversion', u'id': 3, u'links': {u'info': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/3/info/' u'method': u'GET'}, 
  u'self': {u'href': u'http://msstra066-ubuntu/api/repositories/3/' 
  u'method': u'GET'}, u'update': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/3/' u'method': u'PUT'}, 
  u'delete': {u'href': u'http://msstra066-ubuntu/api/repositories/3/' 
  u'method': u'DELETE'}}, u'name': u'haha'}, {u'path': 
  u'msstra066-ubuntu:1666', u'tool': u'Perforce', u'id': 6, u'links': 
  {u'info': {u'href': u'http://msstra066-ubuntu/api/repositories/6/info/' 
  u'method': u'GET'}, u'self': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/6/' u'method': u'GET'}, 
  u'update': {u'href': u'http://msstra066-ubuntu/api/repositories/6/' 
  u'method': u'PUT'}, u'delete': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/6/' u'method': u'DELETE'}}, 
  u'name': u'perforce'}]
  Server Aliases: ['msstra066-ubuntu.mstarsemi.com.tw:1666', 
  'msstra066-ubuntu:1666', 'mstar:1666']
  Attempting to create review request on msstra066-ubuntu:1666 for 5
  HTTP POSTing to http://msstra066-ubuntu/api/review-requests/ 
  {'changenum': '5', 'repository': u'msstra066-ubuntu:1666'}
  Got API Error 204 (HTTP code 409): The change number specified has 
  already been used
  Error data: {u'stat': u'fail', u'review_request': {u'status': u'pending', 
  u'last_updated': u'2012-04-01T18:29:33', u'description': u'saved by 
  Perforce\n', u'links': {u'diffs': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/diffs/' u'method': 
  u'GET'}, u'repository': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/6/' u'method': u'GET', 
  u'title': u'perforce'}, u'changes': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/changes/' u'method': 
  u'GET'}, u'self': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/' u'method': u'GET'}, 
  u'update': {u'href': u'http://msstra066-ubuntu/api/review-requests/19/' 
  u'method': u'PUT'}, u'last_update': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/last-update/' u'method': 
  u'GET'}, u'reviews': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/reviews/' u'method': 
  u'GET'}, u'draft': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/draft/' u'method': 
  u'GET'}, u'file_attachments': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/file-attachments/' 
  u'method': u'GET'}, u'submitter': {u'href': 
  u'http://msstra066-ubuntu/api/users/mstar/' u'method': u'GET', u'title': 
  u'mstar'}, u'screenshots': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/screenshots/' u'method': 
  u'GET'}, u'delete': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/' u'method': 
  u'DELETE'}}, u'target_groups': [], u'bugs_closed': [], u'changenum': 5, 
  u'target_people': [], u'testing_done': u'', u'branch': u'', u'id': 19, 
  u'time_added': u'2012-04-01T18:29:33', u'summary': u'saved by 
  Perforce', u'public': False}, u'err': {u'msg': u'The change number 
  specified has already been used', u'code': 204}}
  Review request already exists. Updating it...
  HTTP PUTting to http://msstra066-ubuntu/api/review-requests/19/ 
  {'changenum': 5}
  Uploading diff, size: 179
  HTTP POSTing to http://msstra066-ubuntu/api/review-requests/19/diffs/ {}
  Got API Error 105 (HTTP code 400): One or more fields had errors
  Error data: {u'fields': {u'path': [u'[Errno 2] No such file or 
  directory']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had 
  errors', u'code': 105}}
 Your review request still exists, but the diff is not attached.
 *What operating system are you using? What browser?*
 OS: ubuntu
 browser: firefox
 *Please provide any additional information below.*



 --
 BR
 Steven.zhu

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 

Re: Error uploading diff with post-review

2012-04-04 Thread Steven Zhu
Hi,
p4 binary is stored in my specified folder,like
/op/p4v-2011.1.405081/bin.
if i run 'which p4', the system can find the p4 binary.
Does p4 binary should be put into /usr/sbin or /usr/bin folder ?


2012/4/5 Christian Hammond chip...@chipx86.com

 Hey,

 Looks like you're missing the p4 binary in your path somewhere on the
 server.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Wed, Apr 4, 2012 at 6:30 PM, Steven Zhu steven...@gmail.com wrote:

 ** NOTE: Do not post confidential information in this bug report.    
 If you need immediate support, please contact   
 reviewboard@googlegroups.com **
 *What version are you running?*
 RB 1.6.4.1
 RBTOOLS 0.4.1
 *What's the URL of the page containing the problem?*
 N/A
 *What steps will reproduce the problem?*
 1. post-review changenum

 *What is the expected output? What do you see instead?*
  RBTools 0.4.1
  Home = /home/mstar
  HTTP GETting api/
  HTTP GETting http://msstra066-ubuntu/api/info/
  Using the new web API
  HTTP GETting http://msstra066-ubuntu/api/repositories/
  Repositories on Server: [{u'path': u'http://MSSPC1474/svn/rb-test' 
  u'tool': u'Subversion', u'id': 3, u'links': {u'info': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/3/info/' u'method': u'GET'}, 
  u'self': {u'href': u'http://msstra066-ubuntu/api/repositories/3/' 
  u'method': u'GET'}, u'update': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/3/' u'method': u'PUT'}, 
  u'delete': {u'href': u'http://msstra066-ubuntu/api/repositories/3/' 
  u'method': u'DELETE'}}, u'name': u'haha'}, {u'path': 
  u'msstra066-ubuntu:1666', u'tool': u'Perforce', u'id': 6, u'links': 
  {u'info': {u'href': u'http://msstra066-ubuntu/api/repositories/6/info/' 
  u'method': u'GET'}, u'self': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/6/' u'method': u'GET'}, 
  u'update': {u'href': u'http://msstra066-ubuntu/api/repositories/6/' 
  u'method': u'PUT'}, u'delete': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/6/' u'method': u'DELETE'}}, 
  u'name': u'perforce'}]
  Server Aliases: ['msstra066-ubuntu.mstarsemi.com.tw:1666', 
  'msstra066-ubuntu:1666', 'mstar:1666']
  Attempting to create review request on msstra066-ubuntu:1666 for 5
  HTTP POSTing to http://msstra066-ubuntu/api/review-requests/ 
  {'changenum': '5', 'repository': u'msstra066-ubuntu:1666'}
  Got API Error 204 (HTTP code 409): The change number specified has 
  already been used
  Error data: {u'stat': u'fail', u'review_request': {u'status': 
  u'pending', u'last_updated': u'2012-04-01T18:29:33', u'description': 
  u'saved by Perforce\n', u'links': {u'diffs': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/diffs/' u'method': 
  u'GET'}, u'repository': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/6/' u'method': u'GET', 
  u'title': u'perforce'}, u'changes': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/changes/' u'method': 
  u'GET'}, u'self': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/' u'method': u'GET'}, 
  u'update': {u'href': u'http://msstra066-ubuntu/api/review-requests/19/' 
  u'method': u'PUT'}, u'last_update': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/last-update/' 
  u'method': u'GET'}, u'reviews': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/reviews/' u'method': 
  u'GET'}, u'draft': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/draft/' u'method': 
  u'GET'}, u'file_attachments': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/file-attachments/' 
  u'method': u'GET'}, u'submitter': {u'href': 
  u'http://msstra066-ubuntu/api/users/mstar/' u'method': u'GET', u'title': 
  u'mstar'}, u'screenshots': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/screenshots/' 
  u'method': u'GET'}, u'delete': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/' u'method': 
  u'DELETE'}}, u'target_groups': [], u'bugs_closed': [], u'changenum': 5, 
  u'target_people': [], u'testing_done': u'', u'branch': u'', u'id': 19, 
  u'time_added': u'2012-04-01T18:29:33', u'summary': u'saved by 
  Perforce', u'public': False}, u'err': {u'msg': u'The change number 
  specified has already been used', u'code': 204}}
  Review request already exists. Updating it...
  HTTP PUTting to http://msstra066-ubuntu/api/review-requests/19/ 
  {'changenum': 5}
  Uploading diff, size: 179
  HTTP POSTing to http://msstra066-ubuntu/api/review-requests/19/diffs/ {}
  Got API Error 105 (HTTP code 400): One or more fields had errors
  Error data: {u'fields': {u'path': [u'[Errno 2] No such file or 
  directory']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields 
  had errors', u'code': 105}}
 Your review request still exists, but the diff is not attached.
 *What operating system are you using? What browser?*
 OS: ubuntu
 browser: 

Re: Error uploading diff with post-review

2012-04-04 Thread Christian Hammond
That may be in your path, but it also has to be in Apache's path. I'd advise a 
system binary path.

Christian



On Apr 4, 2012, at 18:47, Steven Zhu steven...@gmail.com wrote:

 Hi,
 p4 binary is stored in my specified folder,like /op/p4v-2011.1.405081/bin.
 if i run 'which p4', the system can find the p4 binary.
 Does p4 binary should be put into /usr/sbin or /usr/bin folder ?
 
 
 2012/4/5 Christian Hammond chip...@chipx86.com
 Hey,
 
 Looks like you're missing the p4 binary in your path somewhere on the server.
 
 Christian
 
 -- 
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com
 
 
 On Wed, Apr 4, 2012 at 6:30 PM, Steven Zhu steven...@gmail.com wrote:
 * NOTE: Do not post confidential information in this bug report. *
 *   If you need immediate support, please contact*
 *   reviewboard@googlegroups.com *
 
 What version are you running?
 RB 1.6.4.1
 RBTOOLS 0.4.1
 
 What's the URL of the page containing the problem?
 N/A
 
 What steps will reproduce the problem?
 1. post-review changenum
 
 
 What is the expected output? What do you see instead?
  RBTools 0.4.1
  Home = /home/mstar
  HTTP GETting api/
  HTTP GETting http://msstra066-ubuntu/api/info/
  Using the new web API
  HTTP GETting http://msstra066-ubuntu/api/repositories/
  Repositories on Server: [{u'path': u'http://MSSPC1474/svn/rb-test' 
  u'tool': u'Subversion', u'id': 3, u'links': {u'info': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/3/info/' u'method': u'GET'}, 
  u'self': {u'href': u'http://msstra066-ubuntu/api/repositories/3/' 
  u'method': u'GET'}, u'update': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/3/' u'method': u'PUT'}, 
  u'delete': {u'href': u'http://msstra066-ubuntu/api/repositories/3/' 
  u'method': u'DELETE'}}, u'name': u'haha'}, {u'path': 
  u'msstra066-ubuntu:1666', u'tool': u'Perforce', u'id': 6, u'links': 
  {u'info': {u'href': u'http://msstra066-ubuntu/api/repositories/6/info/' 
  u'method': u'GET'}, u'self': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/6/' u'method': u'GET'}, 
  u'update': {u'href': u'http://msstra066-ubuntu/api/repositories/6/' 
  u'method': u'PUT'}, u'delete': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/6/' u'method': u'DELETE'}}, 
  u'name': u'perforce'}]
  Server Aliases: ['msstra066-ubuntu.mstarsemi.com.tw:1666', 
  'msstra066-ubuntu:1666', 'mstar:1666']
  Attempting to create review request on msstra066-ubuntu:1666 for 5
  HTTP POSTing to http://msstra066-ubuntu/api/review-requests/ 
  {'changenum': '5', 'repository': u'msstra066-ubuntu:1666'}
  Got API Error 204 (HTTP code 409): The change number specified has 
  already been used
  Error data: {u'stat': u'fail', u'review_request': {u'status': u'pending', 
  u'last_updated': u'2012-04-01T18:29:33', u'description': u'saved by 
  Perforce\n', u'links': {u'diffs': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/diffs/' u'method': 
  u'GET'}, u'repository': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/6/' u'method': u'GET', 
  u'title': u'perforce'}, u'changes': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/changes/' u'method': 
  u'GET'}, u'self': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/' u'method': u'GET'}, 
  u'update': {u'href': u'http://msstra066-ubuntu/api/review-requests/19/' 
  u'method': u'PUT'}, u'last_update': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/last-update/' u'method': 
  u'GET'}, u'reviews': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/reviews/' u'method': 
  u'GET'}, u'draft': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/draft/' u'method': 
  u'GET'}, u'file_attachments': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/file-attachments/' 
  u'method': u'GET'}, u'submitter': {u'href': 
  u'http://msstra066-ubuntu/api/users/mstar/' u'method': u'GET', u'title': 
  u'mstar'}, u'screenshots': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/screenshots/' u'method': 
  u'GET'}, u'delete': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/' u'method': 
  u'DELETE'}}, u'target_groups': [], u'bugs_closed': [], u'changenum': 5, 
  u'target_people': [], u'testing_done': u'', u'branch': u'', u'id': 19, 
  u'time_added': u'2012-04-01T18:29:33', u'summary': u'saved by 
  Perforce', u'public': False}, u'err': {u'msg': u'The change number 
  specified has already been used', u'code': 204}}
  Review request already exists. Updating it...
  HTTP PUTting to http://msstra066-ubuntu/api/review-requests/19/ 
  {'changenum': 5}
  Uploading diff, size: 179
  HTTP POSTing to http://msstra066-ubuntu/api/review-requests/19/diffs/ {}
  Got API Error 105 (HTTP code 400): One or more fields had errors
  Error data: {u'fields': {u'path': [u'[Errno 2] No such file or 
  directory']}, u'stat': u'fail', u'err': {u'msg': u'One 

Re: Error uploading diff with post-review

2012-04-04 Thread Steven Zhu
I refer to following link and put the p4 binary into /usr/sbin folder. but
got the same error
Reference link:
http://code.google.com/p/reviewboard/issues/detail?id=1637can=1q=%2Fusr%2Fsbin%20instead%20of%20%2Fusr%2Fbincolspec=ID%20Type%20Status%20Priority%20Component%20Owner%20Summary%20Milestone

2012/4/5 Christian Hammond chip...@gmail.com

 That may be in your path, but it also has to be in Apache's path. I'd
 advise a system binary path.

 Christian



 On Apr 4, 2012, at 18:47, Steven Zhu steven...@gmail.com wrote:

 Hi,
 p4 binary is stored in my specified folder,like
 /op/p4v-2011.1.405081/bin.
 if i run 'which p4', the system can find the p4 binary.
 Does p4 binary should be put into /usr/sbin or /usr/bin folder ?


 2012/4/5 Christian Hammond chip...@chipx86.com

 Hey,

 Looks like you're missing the p4 binary in your path somewhere on the
 server.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Wed, Apr 4, 2012 at 6:30 PM, Steven Zhu steven...@gmail.com wrote:

 ** NOTE: Do not post confidential information in this bug report.   
  If you need immediate support, please contact   
 reviewboard@googlegroups.com **
 *What version are you running?*
 RB 1.6.4.1
 RBTOOLS 0.4.1
 *What's the URL of the page containing the problem?*
 N/A
 *What steps will reproduce the problem?*
 1. post-review changenum

 *What is the expected output? What do you see instead?*
  RBTools 0.4.1
  Home = /home/mstar
  HTTP GETting api/
  HTTP GETting http://msstra066-ubuntu/api/info/
  Using the new web API
  HTTP GETting http://msstra066-ubuntu/api/repositories/
  Repositories on Server: [{u'path': u'http://MSSPC1474/svn/rb-test' 
  u'tool': u'Subversion', u'id': 3, u'links': {u'info': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/3/info/' u'method': u'GET'}, 
  u'self': {u'href': u'http://msstra066-ubuntu/api/repositories/3/' 
  u'method': u'GET'}, u'update': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/3/' u'method': u'PUT'}, 
  u'delete': {u'href': u'http://msstra066-ubuntu/api/repositories/3/' 
  u'method': u'DELETE'}}, u'name': u'haha'}, {u'path': 
  u'msstra066-ubuntu:1666', u'tool': u'Perforce', u'id': 6, u'links': 
  {u'info': {u'href': u'http://msstra066-ubuntu/api/repositories/6/info/' 
  u'method': u'GET'}, u'self': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/6/' u'method': u'GET'}, 
  u'update': {u'href': u'http://msstra066-ubuntu/api/repositories/6/' 
  u'method': u'PUT'}, u'delete': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/6/' u'method': u'DELETE'}}, 
  u'name': u'perforce'}]
  Server Aliases: ['msstra066-ubuntu.mstarsemi.com.tw:1666', 
  'msstra066-ubuntu:1666', 'mstar:1666']
  Attempting to create review request on msstra066-ubuntu:1666 for 5
  HTTP POSTing to http://msstra066-ubuntu/api/review-requests/ 
  {'changenum': '5', 'repository': u'msstra066-ubuntu:1666'}
  Got API Error 204 (HTTP code 409): The change number specified has 
  already been used
  Error data: {u'stat': u'fail', u'review_request': {u'status': 
  u'pending', u'last_updated': u'2012-04-01T18:29:33', u'description': 
  u'saved by Perforce\n', u'links': {u'diffs': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/diffs/' u'method': 
  u'GET'}, u'repository': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/6/' u'method': u'GET', 
  u'title': u'perforce'}, u'changes': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/changes/' u'method': 
  u'GET'}, u'self': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/' u'method': u'GET'}, 
  u'update': {u'href': u'http://msstra066-ubuntu/api/review-requests/19/' 
  u'method': u'PUT'}, u'last_update': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/last-update/' 
  u'method': u'GET'}, u'reviews': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/reviews/' u'method': 
  u'GET'}, u'draft': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/draft/' u'method': 
  u'GET'}, u'file_attachments': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/file-attachments/' 
  u'method': u'GET'}, u'submitter': {u'href': 
  u'http://msstra066-ubuntu/api/users/mstar/' u'method': u'GET', 
  u'title': u'mstar'}, u'screenshots': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/screenshots/' 
  u'method': u'GET'}, u'delete': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/' u'method': 
  u'DELETE'}}, u'target_groups': [], u'bugs_closed': [], u'changenum': 5, 
  u'target_people': [], u'testing_done': u'', u'branch': u'', u'id': 19, 
  u'time_added': u'2012-04-01T18:29:33', u'summary': u'saved by 
  Perforce', u'public': False}, u'err': {u'msg': u'The change number 
  specified has already been used', u'code': 204}}
  Review request already exists. Updating it...
  HTTP PUTting to 

Re: Error uploading diff with post-review

2012-04-04 Thread Christian Hammond
Hmm, what about patch?

Getting a trace from the server's reviewboard.log would tell me more.

Christian



On Apr 4, 2012, at 19:32, Steven Zhu steven...@gmail.com wrote:

 I refer to following link and put the p4 binary into /usr/sbin folder. but 
 got the same error
 Reference link: 
 http://code.google.com/p/reviewboard/issues/detail?id=1637can=1q=%2Fusr%2Fsbin%20instead%20of%20%2Fusr%2Fbincolspec=ID%20Type%20Status%20Priority%20Component%20Owner%20Summary%20Milestone
  
 
 2012/4/5 Christian Hammond chip...@gmail.com
 That may be in your path, but it also has to be in Apache's path. I'd advise 
 a system binary path.
 
 Christian
 
 
 
 On Apr 4, 2012, at 18:47, Steven Zhu steven...@gmail.com wrote:
 
 Hi,
 p4 binary is stored in my specified folder,like 
 /op/p4v-2011.1.405081/bin.
 if i run 'which p4', the system can find the p4 binary.
 Does p4 binary should be put into /usr/sbin or /usr/bin folder ?
 
 
 2012/4/5 Christian Hammond chip...@chipx86.com
 Hey,
 
 Looks like you're missing the p4 binary in your path somewhere on the server.
 
 Christian
 
 -- 
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com
 
 
 On Wed, Apr 4, 2012 at 6:30 PM, Steven Zhu steven...@gmail.com wrote:
 * NOTE: Do not post confidential information in this bug report. *
 *   If you need immediate support, please contact*
 *   reviewboard@googlegroups.com *
 
 What version are you running?
 RB 1.6.4.1
 RBTOOLS 0.4.1
 
 What's the URL of the page containing the problem?
 N/A
 
 What steps will reproduce the problem?
 1. post-review changenum
 
 
 What is the expected output? What do you see instead?
  RBTools 0.4.1
  Home = /home/mstar
  HTTP GETting api/
  HTTP GETting http://msstra066-ubuntu/api/info/
  Using the new web API
  HTTP GETting http://msstra066-ubuntu/api/repositories/
  Repositories on Server: [{u'path': u'http://MSSPC1474/svn/rb-test' 
  u'tool': u'Subversion', u'id': 3, u'links': {u'info': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/3/info/' u'method': u'GET'}, 
  u'self': {u'href': u'http://msstra066-ubuntu/api/repositories/3/' 
  u'method': u'GET'}, u'update': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/3/' u'method': u'PUT'}, 
  u'delete': {u'href': u'http://msstra066-ubuntu/api/repositories/3/' 
  u'method': u'DELETE'}}, u'name': u'haha'}, {u'path': 
  u'msstra066-ubuntu:1666', u'tool': u'Perforce', u'id': 6, u'links': 
  {u'info': {u'href': u'http://msstra066-ubuntu/api/repositories/6/info/' 
  u'method': u'GET'}, u'self': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/6/' u'method': u'GET'}, 
  u'update': {u'href': u'http://msstra066-ubuntu/api/repositories/6/' 
  u'method': u'PUT'}, u'delete': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/6/' u'method': u'DELETE'}}, 
  u'name': u'perforce'}]
  Server Aliases: ['msstra066-ubuntu.mstarsemi.com.tw:1666', 
  'msstra066-ubuntu:1666', 'mstar:1666']
  Attempting to create review request on msstra066-ubuntu:1666 for 5
  HTTP POSTing to http://msstra066-ubuntu/api/review-requests/ 
  {'changenum': '5', 'repository': u'msstra066-ubuntu:1666'}
  Got API Error 204 (HTTP code 409): The change number specified has 
  already been used
  Error data: {u'stat': u'fail', u'review_request': {u'status': 
  u'pending', u'last_updated': u'2012-04-01T18:29:33', u'description': 
  u'saved by Perforce\n', u'links': {u'diffs': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/diffs/' u'method': 
  u'GET'}, u'repository': {u'href': 
  u'http://msstra066-ubuntu/api/repositories/6/' u'method': u'GET', 
  u'title': u'perforce'}, u'changes': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/changes/' u'method': 
  u'GET'}, u'self': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/' u'method': u'GET'}, 
  u'update': {u'href': u'http://msstra066-ubuntu/api/review-requests/19/' 
  u'method': u'PUT'}, u'last_update': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/last-update/' 
  u'method': u'GET'}, u'reviews': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/reviews/' u'method': 
  u'GET'}, u'draft': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/draft/' u'method': 
  u'GET'}, u'file_attachments': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/file-attachments/' 
  u'method': u'GET'}, u'submitter': {u'href': 
  u'http://msstra066-ubuntu/api/users/mstar/' u'method': u'GET', u'title': 
  u'mstar'}, u'screenshots': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/screenshots/' 
  u'method': u'GET'}, u'delete': {u'href': 
  u'http://msstra066-ubuntu/api/review-requests/19/' u'method': 
  u'DELETE'}}, u'target_groups': [], u'bugs_closed': [], u'changenum': 5, 
  u'target_people': [], u'testing_done': u'', u'branch': u'', u'id': 19, 
  u'time_added': u'2012-04-01T18:29:33', u'summary': u'saved by 
  

Re: Error uploading diff with post-review

2012-04-04 Thread Steven Zhu
The following error info is from apache error log and my reviewboard/logs
folder is empty, I could not get any info.
[Thu Apr 05 10:56:18 2012] [error] ERROR:root:Error uploading new diff:
[Errno 2] No such file or directory
[Thu Apr 05 10:56:18 2012] [error] Traceback (most recent call last):
[Thu Apr 05 10:56:18 2012] [error]   File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/webapi/resources.py,
line 1503, in create
[Thu Apr 05 10:56:18 2012] [error]
request.FILES.get('parent_diff_path'))
[Thu Apr 05 10:56:18 2012] [error]   File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/reviews/forms.py,
line 286, in create
[Thu Apr 05 10:56:18 2012] [error] history)
[Thu Apr 05 10:56:18 2012] [error]   File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/diffviewer/forms.py,
line 63, in create
[Thu Apr 05 10:56:18 2012] [error] diff_file, basedir,
check_existance=(not parent_diff_file)))
[Thu Apr 05 10:56:18 2012] [error]   File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/diffviewer/forms.py,
line 149, in _process_files
[Thu Apr 05 10:56:18 2012] [error] not tool.file_exists(filename,
revision))):
[Thu Apr 05 10:56:18 2012] [error]   File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/scmtools/core.py,
line 72, in file_exists
[Thu Apr 05 10:56:18 2012] [error] self.get_file(path, revision)
[Thu Apr 05 10:56:18 2012] [error]   File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/scmtools/perforce.py,
line 325, in get_file
[Thu Apr 05 10:56:18 2012] [error] return self.client.get_file(path,
revision)
[Thu Apr 05 10:56:18 2012] [error]   File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/scmtools/perforce.py,
line 243, in get_file
[Thu Apr 05 10:56:18 2012] [error] return self._run_worker(lambda:
self._get_file(path, revision))
[Thu Apr 05 10:56:18 2012] [error]   File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/scmtools/perforce.py,
line 173, in _run_worker
[Thu Apr 05 10:56:18 2012] [error] result = worker()
[Thu Apr 05 10:56:18 2012] [error]   File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/scmtools/perforce.py,
line 243, in lambda
[Thu Apr 05 10:56:18 2012] [error] return self._run_worker(lambda:
self._get_file(path, revision))
[Thu Apr 05 10:56:18 2012] [error]   File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/scmtools/perforce.py,
line 220, in _get_file
[Thu Apr 05 10:56:18 2012] [error] stderr=subprocess.PIPE)
[Thu Apr 05 10:56:18 2012] [error]   File
/usr/lib/python2.6/subprocess.py, line 633, in __init__
[Thu Apr 05 10:56:18 2012] [error] errread, errwrite)
[Thu Apr 05 10:56:18 2012] [error]   File
/usr/lib/python2.6/subprocess.py, line 1139, in _execute_child
[Thu Apr 05 10:56:18 2012] [error] raise child_exception
[Thu Apr 05 10:56:18 2012] [error] OSError: [Errno 2] No such file or
directory




2012/4/5 Christian Hammond chip...@gmail.com

 Hmm, what about patch?

 Getting a trace from the server's reviewboard.log would tell me more.

 Christian



 On Apr 4, 2012, at 19:32, Steven Zhu steven...@gmail.com wrote:

 I refer to following link and put the p4 binary into /usr/sbin folder. but
 got the same error
 Reference link:

 http://code.google.com/p/reviewboard/issues/detail?id=1637can=1q=%2Fusr%2Fsbin%20instead%20of%20%2Fusr%2Fbincolspec=ID%20Type%20Status%20Priority%20Component%20Owner%20Summary%20Milestone

 2012/4/5 Christian Hammond chip...@gmail.com

 That may be in your path, but it also has to be in Apache's path. I'd
 advise a system binary path.

 Christian



 On Apr 4, 2012, at 18:47, Steven Zhu steven...@gmail.com wrote:

 Hi,
 p4 binary is stored in my specified folder,like
 /op/p4v-2011.1.405081/bin.
 if i run 'which p4', the system can find the p4 binary.
 Does p4 binary should be put into /usr/sbin or /usr/bin folder ?


 2012/4/5 Christian Hammond chip...@chipx86.com

 Hey,

 Looks like you're missing the p4 binary in your path somewhere on the
 server.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Wed, Apr 4, 2012 at 6:30 PM, Steven Zhu steven...@gmail.com wrote:

 ** NOTE: Do not post confidential information in this bug report.  
   If you need immediate support, please contact   
 reviewboard@googlegroups.com **
 *What version are you running?*
 RB 1.6.4.1
 RBTOOLS 0.4.1
 *What's the URL of the page containing the problem?*
 N/A
 *What steps will reproduce the problem?*
 1. post-review changenum

 *What is the expected output? What do you see instead?*
  RBTools 0.4.1
  Home = /home/mstar
  HTTP GETting api/
  HTTP GETting 

Re: Error uploading diff with post-review

2012-04-04 Thread Steven Zhu
Hi,
I just enabled reviewboard log and got the following info.

Error info:
2012-04-05 11:12:43,993 - DEBUG - DiffParser.parse: Beginning parse of
diff, size = 187
2012-04-05 11:12:43,993 - DEBUG - DiffParser.parse: Finished parsing diff.
2012-04-05 11:12:44,000 - ERROR - Error uploading new diff: [Errno 2] No
such file or directory
Traceback (most recent call last):
  File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/webapi/resources.py,
line 1503, in create
request.FILES.get('parent_diff_path'))
  File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/reviews/forms.py,
line 286, in create
history)
  File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/diffviewer/forms.py,
line 63, in create
diff_file, basedir, check_existance=(not parent_diff_file)))
  File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/diffviewer/forms.py,
line 149, in _process_files
not tool.file_exists(filename, revision))):
  File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/scmtools/core.py,
line 72, in file_exists
self.get_file(path, revision)
  File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/scmtools/perforce.py,
line 325, in get_file
return self.client.get_file(path, revision)
  File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/scmtools/perforce.py,
line 243, in get_file
return self._run_worker(lambda: self._get_file(path, revision))
  File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/scmtools/perforce.py,
line 173, in _run_worker
result = worker()
  File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/scmtools/perforce.py,
line 243, in lambda
return self._run_worker(lambda: self._get_file(path, revision))
  File
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/scmtools/perforce.py,
line 220, in _get_file
stderr=subprocess.PIPE)
  File /usr/lib/python2.6/subprocess.py, line 633, in __init__
errread, errwrite)
  File /usr/lib/python2.6/subprocess.py, line 1139, in _execute_child
raise child_exception
OSError: [Errno 2] No such file or directory




2012/4/5 Steven Zhu steven...@gmail.com

 The following error info is from apache error log and my reviewboard/logs
 folder is empty, I could not get any info.
 [Thu Apr 05 10:56:18 2012] [error] ERROR:root:Error uploading new diff:
 [Errno 2] No such file or directory
 [Thu Apr 05 10:56:18 2012] [error] Traceback (most recent call last):
 [Thu Apr 05 10:56:18 2012] [error]   File
 /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/webapi/resources.py,
 line 1503, in create
 [Thu Apr 05 10:56:18 2012] [error]
 request.FILES.get('parent_diff_path'))
 [Thu Apr 05 10:56:18 2012] [error]   File
 /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/reviews/forms.py,
 line 286, in create
 [Thu Apr 05 10:56:18 2012] [error] history)
 [Thu Apr 05 10:56:18 2012] [error]   File
 /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/diffviewer/forms.py,
 line 63, in create
 [Thu Apr 05 10:56:18 2012] [error] diff_file, basedir,
 check_existance=(not parent_diff_file)))
 [Thu Apr 05 10:56:18 2012] [error]   File
 /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/diffviewer/forms.py,
 line 149, in _process_files
 [Thu Apr 05 10:56:18 2012] [error] not tool.file_exists(filename,
 revision))):
 [Thu Apr 05 10:56:18 2012] [error]   File
 /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/scmtools/core.py,
 line 72, in file_exists
 [Thu Apr 05 10:56:18 2012] [error] self.get_file(path, revision)
 [Thu Apr 05 10:56:18 2012] [error]   File
 /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/scmtools/perforce.py,
 line 325, in get_file
 [Thu Apr 05 10:56:18 2012] [error] return self.client.get_file(path,
 revision)
 [Thu Apr 05 10:56:18 2012] [error]   File
 /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/scmtools/perforce.py,
 line 243, in get_file
 [Thu Apr 05 10:56:18 2012] [error] return self._run_worker(lambda:
 self._get_file(path, revision))
 [Thu Apr 05 10:56:18 2012] [error]   File
 /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/scmtools/perforce.py,
 line 173, in _run_worker
 [Thu Apr 05 10:56:18 2012] [error] result = worker()
 [Thu Apr 05 10:56:18 2012] [error]   File
 /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.4.1-py2.6.egg/reviewboard/scmtools/perforce.py,
 line 243, in lambda
 [Thu Apr 05 10:56:18 2012] [error] return self._run_worker(lambda:
 self._get_file(path, revision))
 [Thu Apr 05 10:56:18 2012] [error]   File