Re: Fixed diff width
Christian, Please accept my apologies for bringing this up as a problem. It is not. I have missed an insanely long line which has got underscores and double semicolons in it (C++ function definition with an insanely long name and parameter type...). I thought I've double checked this, sorry. Best Regards, Bartek On Dec 17, 4:21 am, Christian Hammond chip...@gmail.com wrote: What's the offending line? Christian On Dec 16, 2011, at 13:59, Bart Celary bartlomiej.cel...@gmail.com wrote: Tried already on Chromium and Firefox under latest Ubuntu as well as Chrome/Firefox on Windows... Most files show well but some produce a diff table to be 2000px wide. Are there any views that in the future (css3?) this could work as expected in all the cases? Bartek On 16 Gru, 18:44, Christian Hammond chip...@gmail.com wrote: Are you using IE? If so, you're a bit out of luck. The problem should largely go away with Firefox/Chrome, though depending on content it's still possible to hit. It's up to the browser to decide when to wrap. We already provide hints telling it to be liberal with its wrapping. Christian On Dec 16, 2011, at 6:38, Bart Celary bartlomiej.cel...@gmail.com wrote: Hi, I have searched the group's archives and haven't really found and answer to my question. In the diff viewer I am getting quite wide diffs for some files. The diff in question does not contain any text that is not breakable (e.g. we are using spaces to separate words, no long strings such as '-'*120, etc.). Is there a way to make sure the diff stays on the 100% of the screen width? We do not have a strict 80 characters margin policy, so forcing this is not a solution for me. I wonder what is causing this? Can I force the text to be broken to fit the screen? Thanks, Bartek -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Fixed diff width
Are you using IE? If so, you're a bit out of luck. The problem should largely go away with Firefox/Chrome, though depending on content it's still possible to hit. It's up to the browser to decide when to wrap. We already provide hints telling it to be liberal with its wrapping. Christian On Dec 16, 2011, at 6:38, Bart Celary bartlomiej.cel...@gmail.com wrote: Hi, I have searched the group's archives and haven't really found and answer to my question. In the diff viewer I am getting quite wide diffs for some files. The diff in question does not contain any text that is not breakable (e.g. we are using spaces to separate words, no long strings such as '-'*120, etc.). Is there a way to make sure the diff stays on the 100% of the screen width? We do not have a strict 80 characters margin policy, so forcing this is not a solution for me. I wonder what is causing this? Can I force the text to be broken to fit the screen? Thanks, Bartek -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Fixed diff width
Tried already on Chromium and Firefox under latest Ubuntu as well as Chrome/Firefox on Windows... Most files show well but some produce a diff table to be 2000px wide. Are there any views that in the future (css3?) this could work as expected in all the cases? Bartek On 16 Gru, 18:44, Christian Hammond chip...@gmail.com wrote: Are you using IE? If so, you're a bit out of luck. The problem should largely go away with Firefox/Chrome, though depending on content it's still possible to hit. It's up to the browser to decide when to wrap. We already provide hints telling it to be liberal with its wrapping. Christian On Dec 16, 2011, at 6:38, Bart Celary bartlomiej.cel...@gmail.com wrote: Hi, I have searched the group's archives and haven't really found and answer to my question. In the diff viewer I am getting quite wide diffs for some files. The diff in question does not contain any text that is not breakable (e.g. we are using spaces to separate words, no long strings such as '-'*120, etc.). Is there a way to make sure the diff stays on the 100% of the screen width? We do not have a strict 80 characters margin policy, so forcing this is not a solution for me. I wonder what is causing this? Can I force the text to be broken to fit the screen? Thanks, Bartek -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Fixed diff width
What's the offending line? Christian On Dec 16, 2011, at 13:59, Bart Celary bartlomiej.cel...@gmail.com wrote: Tried already on Chromium and Firefox under latest Ubuntu as well as Chrome/Firefox on Windows... Most files show well but some produce a diff table to be 2000px wide. Are there any views that in the future (css3?) this could work as expected in all the cases? Bartek On 16 Gru, 18:44, Christian Hammond chip...@gmail.com wrote: Are you using IE? If so, you're a bit out of luck. The problem should largely go away with Firefox/Chrome, though depending on content it's still possible to hit. It's up to the browser to decide when to wrap. We already provide hints telling it to be liberal with its wrapping. Christian On Dec 16, 2011, at 6:38, Bart Celary bartlomiej.cel...@gmail.com wrote: Hi, I have searched the group's archives and haven't really found and answer to my question. In the diff viewer I am getting quite wide diffs for some files. The diff in question does not contain any text that is not breakable (e.g. we are using spaces to separate words, no long strings such as '-'*120, etc.). Is there a way to make sure the diff stays on the 100% of the screen width? We do not have a strict 80 characters margin policy, so forcing this is not a solution for me. I wonder what is causing this? Can I force the text to be broken to fit the screen? Thanks, Bartek -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
