Re: How to ignore certain file types or sections of a file?
There's no concept of ignoring certain files, other than what your SCM provides. Usually, auto-generated Makefiles constructed at build time aren't included in the source tree, so they get left out of the diff. If they're tracked by your repository and not ignored by it, then they'll be included, and since we depend on the tool for the SCM in post-review for generating these diffs, it's mostly out of our control. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Wed, Mar 4, 2009 at 7:46 AM, ticica tic...@gmail.com wrote: The makefiles in our projects are very large (store a lot of autogenerated dependency information). This makes the diff for review very large. Is there a way to limit the diff to exclude certain portions of a file, or a whole file perhaps? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: How to ignore certain file types or sections of a file?
We have the same problem with large project files, and in our case the xml gets rearranged whenever the project file is saved. The resulting diffs could be so monstrous that we could not load the review request pages. To deal with this problem, I wrote a script that deletes file diffs from the review board database after a review request has been created. That's a poor solution, but it's working for now. I wrote it for a RB version from October, and have not tested it with the latest alphas. One major drawback is that RB can still choke on simply trying to create a review request from such a large file. The key SQL code is: DELETE FROM diffviewer_filediff WHERE diffviewer_filediff.dest_file LIKE %s AND diffviewer_filediff.diffset_id IN (SELECT id FROM diffviewer_diffset diffset WHERE diffset.history_id = (SELECT diffset_history_id FROM reviews_reviewrequest request WHERE request.id = %s) ) You supply a request ID and a file name pattern. I have uploaded the script as erase_diff.py into the files section of this group. Noah On Mar 4, 10:46 am, ticica tic...@gmail.com wrote: The makefiles in our projects are very large (store a lot of autogenerated dependency information). This makes the diff for review very large. Is there a way to limit the diff to exclude certain portions of a file, or a whole file perhaps? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
