Re: How to make sure 'git push' does not work until the codes are reviewed?

[Jinzheng Sha]

Hi,

Thank you for such quick help. I am about to try this solution.

But I found another interesting problem which is that after I 'rbt land 
--dest master' and 'git log', there were two commit messages, one of which 
is a duplicate of the other with 'Reviewed at /r/' at 
the bottom, as in the attached picture.

Is there any possible way to get rid of one of the two?

Regards!

On Tuesday, October 27, 2015 at 4:01:08 AM UTC-4, Christian Hammond wrote:
>
> Hi,
>
> If you maintain the Git server yourself, you can use a pre-receive hook 
> that looks for a "Reviewed at " line and validates that the change is 
> approved.
>
> See 
> https://github.com/reviewboard/rbtools/blob/master/contrib/tools/git-hook-check-approval
>
> Christian
>
> -- 
> Christian Hammond - chri...@beanbaginc.com 
> Review Board - https://www.reviewboard.org
> Beanbag, Inc. - https://www.beanbaginc.com
>
> On Mon, Oct 26, 2015 at 6:37 PM, Jinzheng Sha  > wrote:
>
>> Hi All,
>>
>> I am a newbie to ReviewBoard. And I just set up RB server on AWS, and ran 
>> into an interesting question. Hope you can give me some insights.
>>
>> The problem is that if I check out a working copy from the remote server, 
>> make some local changes directly in the 'master' branch, and run 'git 
>> push', it will check in code as well. But since I want to prevent users 
>> from directly checking in codes which are not reviewed, how can I make sure 
>> that 'git push' does not work until the codes have got 'Ship it' from 
>> reviewers? 
>>
>> Regards!
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: How to make sure 'git push' does not work until the codes are reviewed?

[Christian Hammond]

Hi,

If you maintain the Git server yourself, you can use a pre-receive hook
that looks for a "Reviewed at " line and validates that the change is
approved.

See
https://github.com/reviewboard/rbtools/blob/master/contrib/tools/git-hook-check-approval

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Mon, Oct 26, 2015 at 6:37 PM, Jinzheng Sha 
wrote:

> Hi All,
>
> I am a newbie to ReviewBoard. And I just set up RB server on AWS, and ran
> into an interesting question. Hope you can give me some insights.
>
> The problem is that if I check out a working copy from the remote server,
> make some local changes directly in the 'master' branch, and run 'git
> push', it will check in code as well. But since I want to prevent users
> from directly checking in codes which are not reviewed, how can I make sure
> that 'git push' does not work until the codes have got 'Ship it' from
> reviewers?
>
> Regards!
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.