Hi Satish, Review Board does not currently store the binary files in any form that can be reviewed or patched, but we probably don't want to outright fail when patching in these cases.
Can you file a bug report on this, with these details and any log output? Thanks, Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On Wed, Nov 4, 2015 at 9:14 PM, satish singh <trivi...@gmail.com> wrote: > Hi Team, > > "rbt patch" fails for binary files, it doesn't work for binary files. > Is this intended behavior ? > > Review board 2.0.12 > RBTools0.5.3 > Perforce repository > > Log: Output of rbt patch --print > > ==== //depot/aaa/bbbb/cccc/ddd/South-1.0.2.tar.gz#1 ==A== > //aaa/bbbb/cccc/ddd/xyz/South-1.0.2.tar.gz ==== --------Fails for binary > file > Binary files /tmp/tmpiLF66E and > /u/satish3/p4/testRBtools/depot/South-1.0.2.tar.gz differ > > --- //depot/aaa/bbbb/cccc/ddd/test.py > //depot/aaa/bbbb/cccc/ddd//xyz/test.py#1 > ----Works for normal file > +++ //depot/prod/code-quality/code-review/rbtools/test.py 2015-11-04 > 07:35:32 > @@ -0,0 +1 @@ > +#test > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
