Re: Post-commit review - Send review comment to the person that made the change
David, thank you for your response. I really appreciate it! I agree wtih your comment but I think for post-commit-review flow it would be very interesting if the reviewer could assign an issue to someone. It would be great if Review Board could do this. Thank you! Em quarta-feira, 4 de dezembro de 2013 19h01min01s UTC-2, David Trowbridge escreveu: Bruno, If there's a single review request comprising the work of a bunch of people, there's no easy way to direct comments toward or assign issues to specific users. Your solution of using a group sounds reasonable to me--I know as a developer, if I see comments about code I wrote (even in others' review requests), I try to pay attention. -David On Wed, Dec 4, 2013 at 8:29 AM, Bruno Carneiro brun...@gmail.comjavascript: wrote: Hi everybody, I'm using Review Board to do post-commit review. I have some doubts about it. I have a several branchs and to get these branches merged into a development branch I do a code review. So, many developers commit into a feature branch. After this feature get ready, they post a review with all changes made. I'm facing a problem that I would like to see which person has done a specific change to submit a comment to him. Is that possible using Review Board? What I did was that a feature branch has a group and every review comment goes to this group (all developers from this branch receive email). Is there anyway to tag a person into a comment or using comment issue assign an issue to the person that made the change (comment issue always goes to the submitter)? Cheers, Bruno Carneiro -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Post-commit review - Send review comment to the person that made the change
We've been thinking about how to make it easier for people to have group ownership of a review request, but that's a very long-term project that's going to require a lot of careful work. -David On Thu, Dec 5, 2013 at 3:09 AM, Bruno Carneiro brunoa...@gmail.com wrote: David, thank you for your response. I really appreciate it! I agree wtih your comment but I think for post-commit-review flow it would be very interesting if the reviewer could assign an issue to someone. It would be great if Review Board could do this. Thank you! Em quarta-feira, 4 de dezembro de 2013 19h01min01s UTC-2, David Trowbridge escreveu: Bruno, If there's a single review request comprising the work of a bunch of people, there's no easy way to direct comments toward or assign issues to specific users. Your solution of using a group sounds reasonable to me--I know as a developer, if I see comments about code I wrote (even in others' review requests), I try to pay attention. -David On Wed, Dec 4, 2013 at 8:29 AM, Bruno Carneiro brun...@gmail.com wrote: Hi everybody, I'm using Review Board to do post-commit review. I have some doubts about it. I have a several branchs and to get these branches merged into a development branch I do a code review. So, many developers commit into a feature branch. After this feature get ready, they post a review with all changes made. I'm facing a problem that I would like to see which person has done a specific change to submit a comment to him. Is that possible using Review Board? What I did was that a feature branch has a group and every review comment goes to this group (all developers from this branch receive email). Is there anyway to tag a person into a comment or using comment issue assign an issue to the person that made the change (comment issue always goes to the submitter)? Cheers, Bruno Carneiro -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Post-commit review - Send review comment to the person that made the change
Bruno, If there's a single review request comprising the work of a bunch of people, there's no easy way to direct comments toward or assign issues to specific users. Your solution of using a group sounds reasonable to me--I know as a developer, if I see comments about code I wrote (even in others' review requests), I try to pay attention. -David On Wed, Dec 4, 2013 at 8:29 AM, Bruno Carneiro brunoa...@gmail.com wrote: Hi everybody, I'm using Review Board to do post-commit review. I have some doubts about it. I have a several branchs and to get these branches merged into a development branch I do a code review. So, many developers commit into a feature branch. After this feature get ready, they post a review with all changes made. I'm facing a problem that I would like to see which person has done a specific change to submit a comment to him. Is that possible using Review Board? What I did was that a feature branch has a group and every review comment goes to this group (all developers from this branch receive email). Is there anyway to tag a person into a comment or using comment issue assign an issue to the person that made the change (comment issue always goes to the submitter)? Cheers, Bruno Carneiro -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
