Re: Preserving diff file sort order

2011-09-13 Thread SCFrench
Success!

In case it helps anyone else, here's what I had to do:

1. Comment out this line in diffviewer/forms.py:

files.sort(cmp=self._compare_files, key=lambda f: f.origFile)

2. Comment out this line in in diffviewer/diffutils.py:

files.sort(cmp_file)

3. I'm not sure if this step is necessary, but I deleted and
regenerated forms.pyc and diffutils.pyc. I found this link to show how
to manually regenerate them after making the changes in steps 1 and
2:

http://pyfaq.infogami.com/how-do-i-create-a-pyc-file

4. Restart memcached (on Linux, Debian 6):

/etc/init.d/memcached restart

5. Restart apache (on Linux, Debian 6):

/etc/init.d/apache2 restart

After that, new posts show up in the same order as the posted diff-
file.

Thanks!
Scott

On Sep 12, 3:06 pm, Christian Hammond chip...@chipx86.com wrote:
 Actually, I believe it is at upload time. So new diffs should be fine.
 diffviewer/forms.py would be the place to look.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.reviewboard.org
 VMware, Inc. -http://www.vmware.com







 On Mon, Sep 12, 2011 at 6:50 AM, SCFrench sc...@mathworks.com wrote:
  I'm pretty sure I tried that (restarting memcached), but I can try
  again.

  Do you know if the sorting occurs when posting the review to the
  database, or only when viewing the diff? That is, once I've commented
  out sort calls and restarted memcached, would I need to re-post the
  diff file or would existing reviews revert to the original ordering?
  And does it make sense to assume that if there were no sorting, the
  order in the diff-file would be the default ordering used?

  Thanks for your help,
  Scott

  On Sep 10, 3:44 am, Christian Hammond chip...@chipx86.com wrote:
   Hi,

   We purposefully reorder the files so that headers will come before
   implementation files, which aids in the review process in general. I
  imagine
   those are the spots you tried to comment out. You can certainly do that
   (maybe we need an advanced pref for it). However, you likely will need to
   clear your memcached for it to take effect.

   Christian

   --
   Christian Hammond - chip...@chipx86.com
   Review Board -http://www.reviewboard.org
   VMware, Inc. -http://www.vmware.com

   On Fri, Sep 9, 2011 at 12:57 PM, SCFrench sc...@mathworks.com wrote:
We are currently using Review Board 1.5.6, and have a custom tool
which generates cvs diff files in a particular order. When we use post-
review to upload that diff file, the contents get reordered. I've
tried commenting out two sites (one in diffutils.py, and one in
diffviewer/forms.py) which appear to sort the files list, but this
seems to be having no effect. I can't find any other places in the
code which call sort, but I could easily be missing something.

Is there any way (including hacking Python) to get Review Board to
honor the file ordering in a diff file?

Thanks,
Scott

--
Want to help the Review Board project? Donate today at
   http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
   http://groups.google.com/group/reviewboard?hl=en

  --
  Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to
  reviewboard+unsubscr...@googlegroups.com
  For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Preserving diff file sort order

2011-09-12 Thread SCFrench
I'm pretty sure I tried that (restarting memcached), but I can try
again.

Do you know if the sorting occurs when posting the review to the
database, or only when viewing the diff? That is, once I've commented
out sort calls and restarted memcached, would I need to re-post the
diff file or would existing reviews revert to the original ordering?
And does it make sense to assume that if there were no sorting, the
order in the diff-file would be the default ordering used?

Thanks for your help,
Scott

On Sep 10, 3:44 am, Christian Hammond chip...@chipx86.com wrote:
 Hi,

 We purposefully reorder the files so that headers will come before
 implementation files, which aids in the review process in general. I imagine
 those are the spots you tried to comment out. You can certainly do that
 (maybe we need an advanced pref for it). However, you likely will need to
 clear your memcached for it to take effect.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.reviewboard.org
 VMware, Inc. -http://www.vmware.com







 On Fri, Sep 9, 2011 at 12:57 PM, SCFrench sc...@mathworks.com wrote:
  We are currently using Review Board 1.5.6, and have a custom tool
  which generates cvs diff files in a particular order. When we use post-
  review to upload that diff file, the contents get reordered. I've
  tried commenting out two sites (one in diffutils.py, and one in
  diffviewer/forms.py) which appear to sort the files list, but this
  seems to be having no effect. I can't find any other places in the
  code which call sort, but I could easily be missing something.

  Is there any way (including hacking Python) to get Review Board to
  honor the file ordering in a diff file?

  Thanks,
  Scott

  --
  Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to
  reviewboard+unsubscr...@googlegroups.com
  For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Preserving diff file sort order

2011-09-12 Thread Christian Hammond
Actually, I believe it is at upload time. So new diffs should be fine.
diffviewer/forms.py would be the place to look.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Mon, Sep 12, 2011 at 6:50 AM, SCFrench sc...@mathworks.com wrote:

 I'm pretty sure I tried that (restarting memcached), but I can try
 again.

 Do you know if the sorting occurs when posting the review to the
 database, or only when viewing the diff? That is, once I've commented
 out sort calls and restarted memcached, would I need to re-post the
 diff file or would existing reviews revert to the original ordering?
 And does it make sense to assume that if there were no sorting, the
 order in the diff-file would be the default ordering used?

 Thanks for your help,
 Scott

 On Sep 10, 3:44 am, Christian Hammond chip...@chipx86.com wrote:
  Hi,
 
  We purposefully reorder the files so that headers will come before
  implementation files, which aids in the review process in general. I
 imagine
  those are the spots you tried to comment out. You can certainly do that
  (maybe we need an advanced pref for it). However, you likely will need to
  clear your memcached for it to take effect.
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.reviewboard.org
  VMware, Inc. -http://www.vmware.com
 
 
 
 
 
 
 
  On Fri, Sep 9, 2011 at 12:57 PM, SCFrench sc...@mathworks.com wrote:
   We are currently using Review Board 1.5.6, and have a custom tool
   which generates cvs diff files in a particular order. When we use post-
   review to upload that diff file, the contents get reordered. I've
   tried commenting out two sites (one in diffutils.py, and one in
   diffviewer/forms.py) which appear to sort the files list, but this
   seems to be having no effect. I can't find any other places in the
   code which call sort, but I could easily be missing something.
 
   Is there any way (including hacking Python) to get Review Board to
   honor the file ordering in a diff file?
 
   Thanks,
   Scott
 
   --
   Want to help the Review Board project? Donate today at
  http://www.reviewboard.org/donate/
   Happy user? Let us know athttp://www.reviewboard.org/users/
   -~--~~~~--~~--~--~---
   To unsubscribe from this group, send email to
   reviewboard+unsubscr...@googlegroups.com
   For more options, visit this group at
  http://groups.google.com/group/reviewboard?hl=en

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Preserving diff file sort order

2011-09-10 Thread Christian Hammond
Hi,

We purposefully reorder the files so that headers will come before
implementation files, which aids in the review process in general. I imagine
those are the spots you tried to comment out. You can certainly do that
(maybe we need an advanced pref for it). However, you likely will need to
clear your memcached for it to take effect.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Fri, Sep 9, 2011 at 12:57 PM, SCFrench sc...@mathworks.com wrote:

 We are currently using Review Board 1.5.6, and have a custom tool
 which generates cvs diff files in a particular order. When we use post-
 review to upload that diff file, the contents get reordered. I've
 tried commenting out two sites (one in diffutils.py, and one in
 diffviewer/forms.py) which appear to sort the files list, but this
 seems to be having no effect. I can't find any other places in the
 code which call sort, but I could easily be missing something.

 Is there any way (including hacking Python) to get Review Board to
 honor the file ordering in a diff file?

 Thanks,
 Scott

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en