Re: Prompt console window many times for cleartool when post-review and viewing diff on Windows 7

2013-01-23 Thread Tao Zhou
sorry, introduced pdb.set_trace() by mistake into the patch, plz delete this line, and use the patch as below: diff --git a/reviewboard/scmtools/clearcase.py b/reviewboard/scmtools/clearcase.py index 19ea97f..35888e3 100644 --- a/reviewboard/scmtools/clearcase.py +++

Re: Prompt console window many times for cleartool when post-review and viewing diff on Windows 7

2013-01-22 Thread Tao Zhou
I found out that the cause, the problem is the code to call cleartool.exe in reviewboard\scmtools\clearcase.py, if add 'shell=True' paramter to all the subprocess.Popen(...), there will no annoying console window pop up. patch code as below: diff --git