Re: Publish changes without e-mail notification

2013-10-23 Thread Kim Gräsman
Hi Ze,

On Tue, Oct 22, 2013 at 2:55 PM, Ze Lin Xiao ilacknormal...@gmail.com wrote:
 We've solved this problem with our in house patch and it's been in place for 
 over 3 years. It's something called Publish (Silent) and yes it's a new 
 button.

 Publish (Silent) is only available AFTER the initial publish of the review so 
 that subsequent emails can be suppressed. We've found it very useful and have 
 had no complaints because it puts the onus on the review submitter.

 If this is something that you think that RB would like to take on, I'd be 
 happy to work on submitting those patches.

I know I'd be delighted to see this in RB proper.

- Kim

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Publish changes without e-mail notification

2013-10-22 Thread Ze Lin Xiao
We've solved this problem with our in house patch and it's been in place for 
over 3 years. It's something called Publish (Silent) and yes it's a new 
button. 

Publish (Silent) is only available AFTER the initial publish of the review so 
that subsequent emails can be suppressed. We've found it very useful and have 
had no complaints because it puts the onus on the review submitter. 

If this is something that you think that RB would like to take on, I'd be happy 
to work on submitting those patches. 

Ze

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Publish changes without e-mail notification

2013-10-21 Thread Kim Gräsman
On Fri, Oct 18, 2013 at 4:41 PM, Matthew Woehlke
mwoehlke.fl...@gmail.com wrote:
 On 2013-10-18 01:45, Kim Gräsman wrote:

 I might try to come up with a patch, but I haven't really thought
 about user experience. A new button seems a little brutal.

 If you've thought about this before, have you come up with any ideas
 for how this might be controlled?


 What about a 'trivial change' check box next to / under the 'describe what
 you changed' text area? Potentially this could be used for diffs, even (e.g.
 if I upload a new diff because I noticed a spelling mistake).

 Ideally this wouldn't necessarily suppress e-mail; only for people that
 don't have a corresponding 'I also want to see trivial changes' option set
 in their profile. This way users don't have the ability to entirely suppress
 mail (e.g. I can see managers that would not like that), but lets each
 subscriber decide whether they want to know about minutia or would prefer to
 not be bothered. (And of course it is borrowing a well-known wiki concept;
 reusing existing ideas is usually a good thing.)

 Bonus points for adding 'trivial' to the e-mail subject for changes so
 indicated.

Thanks, that sounds workable.

However, I just realized this is way too much work for me to take on
at this point. I'll keep this in the back of my head and see if I can
pick it up again when I have more bandwidth.

Thanks,
- Kim

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Publish changes without e-mail notification

2013-10-21 Thread Stephen Gallagher
On 10/18/2013 10:41 AM, Matthew Woehlke wrote:
 On 2013-10-18 01:45, Kim Gräsman wrote:
 I might try to come up with a patch, but I haven't really thought
 about user experience. A new button seems a little brutal.

 If you've thought about this before, have you come up with any ideas
 for how this might be controlled?
 
 What about a 'trivial change' check box next to / under the 'describe
 what you changed' text area? Potentially this could be used for diffs,
 even (e.g. if I upload a new diff because I noticed a spelling mistake).
 
 Ideally this wouldn't necessarily suppress e-mail; only for people that
 don't have a corresponding 'I also want to see trivial changes' option
 set in their profile. This way users don't have the ability to entirely
 suppress mail (e.g. I can see managers that would not like that), but
 lets each subscriber decide whether they want to know about minutia or
 would prefer to not be bothered. (And of course it is borrowing a
 well-known wiki concept; reusing existing ideas is usually a good thing.)
 
 Bonus points for adding 'trivial' to the e-mail subject for changes so
 indicated.
 

I think the least-invasive way would be to add the trivial button and
then just tack on a new 'X-ReviewBoard-Trival: true' header to the
email. Then you just continue sending out email as before, but clients
can just opt to write email filters to ignore those marked as Trivial if
they so desire.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Publish changes without e-mail notification

2013-10-21 Thread Matthew Woehlke

On 2013-10-21 07:05, Stephen Gallagher wrote:

On 10/18/2013 10:41 AM, Matthew Woehlke wrote:

On 2013-10-18 01:45, Kim Gräsman wrote:

I might try to come up with a patch, but I haven't really thought
about user experience. A new button seems a little brutal.

If you've thought about this before, have you come up with any ideas
for how this might be controlled?


What about a 'trivial change' check box next to / under the 'describe
what you changed' text area? Potentially this could be used for diffs,
even (e.g. if I upload a new diff because I noticed a spelling mistake).

Ideally this wouldn't necessarily suppress e-mail; only for people that
don't have a corresponding 'I also want to see trivial changes' option
set in their profile. This way users don't have the ability to entirely
suppress mail (e.g. I can see managers that would not like that), but
lets each subscriber decide whether they want to know about minutia or
would prefer to not be bothered. (And of course it is borrowing a
well-known wiki concept; reusing existing ideas is usually a good thing.)

Bonus points for adding 'trivial' to the e-mail subject for changes so
indicated.


I think the least-invasive way would be to add the trivial button and
then just tack on a new 'X-ReviewBoard-Trival: true' header to the
email. Then you just continue sending out email as before, but clients
can just opt to write email filters to ignore those marked as Trivial if
they so desire.


...or just add 'trivial' to the subject. Or both. (Depending on the 
client, it may be more difficult to filter on a custom header than a 
keyword in the subject line. Also having it in the subject line makes it 
easy to see what is trivial and what isn't when looking at your inbox).


I wouldn't take having an RB-side user setting off the wish list 
entirely, but what you described would still be wanted/needed in that 
case and is also a great initial implementation that would be a welcome 
improvement over not having the feature at all. Thanks for the idea!


--
Matthew

--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups reviewboard group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Publish changes without e-mail notification

2013-10-18 Thread Matthew Woehlke

On 2013-10-18 01:45, Kim Gräsman wrote:

I might try to come up with a patch, but I haven't really thought
about user experience. A new button seems a little brutal.

If you've thought about this before, have you come up with any ideas
for how this might be controlled?


What about a 'trivial change' check box next to / under the 'describe 
what you changed' text area? Potentially this could be used for diffs, 
even (e.g. if I upload a new diff because I noticed a spelling mistake).


Ideally this wouldn't necessarily suppress e-mail; only for people that 
don't have a corresponding 'I also want to see trivial changes' option 
set in their profile. This way users don't have the ability to entirely 
suppress mail (e.g. I can see managers that would not like that), but 
lets each subscriber decide whether they want to know about minutia or 
would prefer to not be bothered. (And of course it is borrowing a 
well-known wiki concept; reusing existing ideas is usually a good thing.)


Bonus points for adding 'trivial' to the e-mail subject for changes so 
indicated.


--
Matthew

--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups reviewboard group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: What's coming for 2.0 (Was: Re: Publish changes without e-mail notification)

2013-10-18 Thread markdbeyer
Sounds cool! 

Would you expect the revised extension framework to be backwards compatible 
with 1.7 extensions ? 

thanks
Mark

On Thursday, October 17, 2013 1:19:56 PM UTC-7, Christian Hammond wrote:

 On Thu, Oct 17, 2013 at 12:43 PM, Matthew Woehlke 
 mwoehlk...@gmail.comjavascript:
  wrote:

 On 2013-10-17 15:31, Christian Hammond wrote:

 [...] our plate's pretty full right now trying to get RB 2.0 ready to
 ship.


 Wait... what happened to 1.8? :-)

 If you're really planning a major version bump (i.e. that wasn't a typo), 
 is there a page somewhere with at least a brief overview of what's changing 
 to warrant the major version bump? (Also, what new features there will be?)



 1.8 is becoming 2.0.

 Here's a brief summary of what's changed since 1.7:


 * We've completely rewritten the entire JavaScript codebase to allow for 
 better maintenance, feature development, and extensibility. This is a 100% 
 rewrite. It'll allow us to do some pretty dang cool things.

 * Given the rewrite, we have fewer cases where the entire page has to 
 reload after some event (like publishing a reply to a review). We're going 
 to reduce reloads more as we go forward.

 * Extensions have been massively improved as well. Building and packaging 
 static media is now trivial (not just easy -- trivial). There are more 
 things to hook into.

 * There are now JavaScript-side extensions, for things like augmenting the 
 comment dialog. More will come in time, as we find good use cases. These 
 are also trivial to get going, as it just requires a JavaScript file 
 bundled with the extension and 2 fields filled out in the Extension class 
 (the name of the JavaScript file and the name of the RB.Extension subclass 
 in JavaScript).

 * Review UIs (which can be provided by extensions) can now show up within 
 the diff viewer, allowing for custom review UIs for binary files.

 * Review UIs can also provide diffing UIs.

 * With the two above, we now display uploaded images in the diff viewer, 
 and offer a few ways to show the differences between them. You can comment 
 on the image diff.

 * The diff viewer has a cleaner look to it, and shows new information, 
 such as the complexity of a given change through new complexity graphs 
 we've added, which concisely show the relative numbers of replaces, 
 inserts, deletes, and percentage of the file changed.

 * The diff viewer loads faster and it's faster to switch revisions or show 
 interdiffs, thanks to the new revision selector.

 * Easy post-commit support was added for many types of repositories. You 
 can now click New Review Request, select the repository, the branch, and 
 click a commit, and that commit will go up for review. No need to use rbt 
 post with --revision-range.

 * Comments and a review request's Description and Testing Done fields now 
 support Markdown. That means a comment can include an image, or 
 syntax-highlighted code samples, or what have you.

 * Things load faster all around now. We've reduced the number of file 
 downloads for any given page considerably. We also get some speed benefits 
 from upgrading to Django 1.5.

 * The UI is now completely localizable.


 So we felt it was worth a version bump.

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com
  


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: What's coming for 2.0 (Was: Re: Publish changes without e-mail notification)

2013-10-18 Thread David Trowbridge
Extensions written for 1.7.x are compatible. The changes in 2.0 will just
make a lot of things (like shipping javascript/css as part of your
extension) a lot easier and adds new hooks and capabilities.

-David


On Fri, Oct 18, 2013 at 12:56 PM, markdbe...@gmail.com wrote:

 Sounds cool!

 Would you expect the revised extension framework to be backwards
 compatible with 1.7 extensions ?

 thanks
 Mark

 On Thursday, October 17, 2013 1:19:56 PM UTC-7, Christian Hammond wrote:

 On Thu, Oct 17, 2013 at 12:43 PM, Matthew Woehlke mwoehlk...@gmail.**com
  wrote:

 On 2013-10-17 15:31, Christian Hammond wrote:

 [...] our plate's pretty full right now trying to get RB 2.0 ready to
 ship.


 Wait... what happened to 1.8? :-)

 If you're really planning a major version bump (i.e. that wasn't a
 typo), is there a page somewhere with at least a brief overview of what's
 changing to warrant the major version bump? (Also, what new features there
 will be?)



 1.8 is becoming 2.0.

 Here's a brief summary of what's changed since 1.7:


 * We've completely rewritten the entire JavaScript codebase to allow for
 better maintenance, feature development, and extensibility. This is a 100%
 rewrite. It'll allow us to do some pretty dang cool things.

 * Given the rewrite, we have fewer cases where the entire page has to
 reload after some event (like publishing a reply to a review). We're going
 to reduce reloads more as we go forward.

 * Extensions have been massively improved as well. Building and packaging
 static media is now trivial (not just easy -- trivial). There are more
 things to hook into.

 * There are now JavaScript-side extensions, for things like augmenting
 the comment dialog. More will come in time, as we find good use cases.
 These are also trivial to get going, as it just requires a JavaScript file
 bundled with the extension and 2 fields filled out in the Extension class
 (the name of the JavaScript file and the name of the RB.Extension subclass
 in JavaScript).

 * Review UIs (which can be provided by extensions) can now show up within
 the diff viewer, allowing for custom review UIs for binary files.

 * Review UIs can also provide diffing UIs.

 * With the two above, we now display uploaded images in the diff viewer,
 and offer a few ways to show the differences between them. You can comment
 on the image diff.

 * The diff viewer has a cleaner look to it, and shows new information,
 such as the complexity of a given change through new complexity graphs
 we've added, which concisely show the relative numbers of replaces,
 inserts, deletes, and percentage of the file changed.

 * The diff viewer loads faster and it's faster to switch revisions or
 show interdiffs, thanks to the new revision selector.

 * Easy post-commit support was added for many types of repositories. You
 can now click New Review Request, select the repository, the branch, and
 click a commit, and that commit will go up for review. No need to use rbt
 post with --revision-range.

 * Comments and a review request's Description and Testing Done fields now
 support Markdown. That means a comment can include an image, or
 syntax-highlighted code samples, or what have you.

 * Things load faster all around now. We've reduced the number of file
 downloads for any given page considerably. We also get some speed benefits
 from upgrading to Django 1.5.

 * The UI is now completely localizable.


 So we felt it was worth a version bump.

 Christian

 --
 Christian Hammond - chi...@chipx86.com

 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: What's coming for 2.0 (Was: Re: Publish changes without e-mail notification)

2013-10-18 Thread Matthew Woehlke

On 2013-10-17 16:19, Christian Hammond wrote:

On Thu, Oct 17, 2013 at 12:43 PM, Matthew Woehlke wrote:

Wait... what happened to 1.8? :-)


1.8 is becoming 2.0.

Here's a brief summary of what's changed since 1.7:
[...]


Thanks. Sounds very cool and exciting!


* Given the rewrite, we have fewer cases where the entire page has to
reload after some event (like publishing a reply to a review). We're going
to reduce reloads more as we go forward.


See, it's when you do awesome stuff like that that I can't understand 
why anyone in their right mind thinks gerrit is a worthwhile tool 
compared to RB :-).



* Comments and a review request's Description and Testing Done fields now
support Markdown. That means a comment can include an image, or
syntax-highlighted code samples, or what have you.


Sweet :-D.


[...]
So we felt it was worth a version bump.


Is there is a 'sandbox' server running the bleeding edge anywhere? I 
suppose I could always roll my own, but it would be cool if there was a 
convenient way for curious folks to play around with the new features in 
a non-production / demonstration environment.


--
Matthew

--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups reviewboard group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: What's coming for 2.0 (Was: Re: Publish changes without e-mail notification)

2013-10-18 Thread Christian Hammond
On Fri, Oct 18, 2013 at 2:11 PM, Matthew Woehlke
mwoehlke.fl...@gmail.comwrote:

 On 2013-10-17 16:19, Christian Hammond wrote:

 On Thu, Oct 17, 2013 at 12:43 PM, Matthew Woehlke wrote:

 Wait... what happened to 1.8? :-)


 1.8 is becoming 2.0.

 Here's a brief summary of what's changed since 1.7:
 [...]


 Thanks. Sounds very cool and exciting!


It should be an amazing release. We wanted it to be smaller, just the JS
rewrite mostly, but then we kept polishing, and polishing..





  * Given the rewrite, we have fewer cases where the entire page has to
 reload after some event (like publishing a reply to a review). We're going
 to reduce reloads more as we go forward.


 See, it's when you do awesome stuff like that that I can't understand why
 anyone in their right mind thinks gerrit is a worthwhile tool compared to
 RB :-).


:)

There's still a couple things Gerrit does that we don't, I guess. I'd have
to agree with you though, but I'm biased :)





  * Comments and a review request's Description and Testing Done fields now
 support Markdown. That means a comment can include an image, or
 syntax-highlighted code samples, or what have you.


 Sweet :-D.

  [...]

 So we felt it was worth a version bump.


 Is there is a 'sandbox' server running the bleeding edge anywhere? I
 suppose I could always roll my own, but it would be cool if there was a
 convenient way for curious folks to play around with the new features in a
 non-production / demonstration environment.


Yep. demo.reviewboard.org and reviews.reviewboard.org are running this
(though a week out of date I think).

Some features, like image diffing, currently requires some manual work to
associate the image with the diff, since the API for this isn't yet
committed and RBTools work still needs to be written, but it'll be there
soon.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: What's coming for 2.0 (Was: Re: Publish changes without e-mail notification)

2013-10-18 Thread Matthew Woehlke

On 2013-10-18 17:19, Christian Hammond wrote:

On Fri, Oct 18, 2013 at 2:11 PM, Matthew Woehlke  wrote:

Is there is a 'sandbox' server running the bleeding edge anywhere? I
suppose I could always roll my own, but it would be cool if there was a
convenient way for curious folks to play around with the new features in a
non-production / demonstration environment.


Yep. demo.reviewboard.org and reviews.reviewboard.org are running this
(though a week out of date I think).


Hmm, both of those 403 for me...?

--
Matthew

--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups reviewboard group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: What's coming for 2.0 (Was: Re: Publish changes without e-mail notification)

2013-10-18 Thread Christian Hammond
On Fri, Oct 18, 2013 at 2:28 PM, Matthew Woehlke
mwoehlke.fl...@gmail.comwrote:

 On 2013-10-18 17:19, Christian Hammond wrote:

 On Fri, Oct 18, 2013 at 2:11 PM, Matthew Woehlke  wrote:

  Is there is a 'sandbox' server running the bleeding edge anywhere? I
 suppose I could always roll my own, but it would be cool if there was a
 convenient way for curious folks to play around with the new features in
 a
 non-production / demonstration environment.


 Yep. demo.reviewboard.org and reviews.reviewboard.org are running this
 (though a week out of date I think).


 Hmm, both of those 403 for me...?


They 403? Can you (perhaps privately) share your IP address?

We get hit with spam bots pretty hard, and have a number of IPs
blacklisted. I want to check that yours isn't somehow on that list.

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: What's coming for 2.0 (Was: Re: Publish changes without e-mail notification)

2013-10-18 Thread Matthew Woehlke

On 2013-10-18 17:37, Christian Hammond wrote:

On Fri, Oct 18, 2013 at 2:28 PM, Matthew Woehlke wrote:

On 2013-10-18 17:19, Christian Hammond wrote:

Yep. demo.reviewboard.org and reviews.reviewboard.org are running this
(though a week out of date I think).


Hmm, both of those 403 for me...?


They 403? Can you (perhaps privately) share your IP address?

We get hit with spam bots pretty hard, and have a number of IPs
blacklisted. I want to check that yours isn't somehow on that list.


That may be; curl from home gave me a 301 to /dashboard/, so I'm going 
to say that it works from my home machine, which does imply it's 
specific to my work ISP IP address; 66.194.253.20.


Thanks for checking on it,

--
Matthew

--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups reviewboard group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Publish changes without e-mail notification

2013-10-17 Thread Christian Hammond
Hi Kim,

This feature doesn't exist, though it does come up from time to time. If
done right, I'd be okay taking a patch for it, but our plate's pretty full
right now trying to get RB 2.0 ready to ship.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com


On Thu, Oct 17, 2013 at 7:43 AM, Kim Gräsman kim.gras...@gmail.com wrote:

 Hi there,

 I'm an avid Review Board user, and I have a small question:

 Is there a way to selectively disable e-mail notification for changes
 to a review?

 Sometimes I make small editorial changes to review data, and I don't
 feel I need to spam a review group (sometimes 20-30 people) with the
 details. It'd be nice to be able to Publish Changes (without e-mail
 notification).

 Does this make sense at all? Does it already exist and I'm just missing it?

 Thanks,
 - Kim

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Publish changes without e-mail notification

2013-10-17 Thread Matthew Woehlke

On 2013-10-17 15:31, Christian Hammond wrote:

[...] our plate's pretty full right now trying to get RB 2.0 ready to
ship.


Wait... what happened to 1.8? :-)

If you're really planning a major version bump (i.e. that wasn't a 
typo), is there a page somewhere with at least a brief overview of 
what's changing to warrant the major version bump? (Also, what new 
features there will be?)


--
Matthew

--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups reviewboard group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


What's coming for 2.0 (Was: Re: Publish changes without e-mail notification)

2013-10-17 Thread Christian Hammond
On Thu, Oct 17, 2013 at 12:43 PM, Matthew Woehlke mwoehlke.fl...@gmail.com
 wrote:

 On 2013-10-17 15:31, Christian Hammond wrote:

 [...] our plate's pretty full right now trying to get RB 2.0 ready to
 ship.


 Wait... what happened to 1.8? :-)

 If you're really planning a major version bump (i.e. that wasn't a typo),
 is there a page somewhere with at least a brief overview of what's changing
 to warrant the major version bump? (Also, what new features there will be?)



1.8 is becoming 2.0.

Here's a brief summary of what's changed since 1.7:


* We've completely rewritten the entire JavaScript codebase to allow for
better maintenance, feature development, and extensibility. This is a 100%
rewrite. It'll allow us to do some pretty dang cool things.

* Given the rewrite, we have fewer cases where the entire page has to
reload after some event (like publishing a reply to a review). We're going
to reduce reloads more as we go forward.

* Extensions have been massively improved as well. Building and packaging
static media is now trivial (not just easy -- trivial). There are more
things to hook into.

* There are now JavaScript-side extensions, for things like augmenting the
comment dialog. More will come in time, as we find good use cases. These
are also trivial to get going, as it just requires a JavaScript file
bundled with the extension and 2 fields filled out in the Extension class
(the name of the JavaScript file and the name of the RB.Extension subclass
in JavaScript).

* Review UIs (which can be provided by extensions) can now show up within
the diff viewer, allowing for custom review UIs for binary files.

* Review UIs can also provide diffing UIs.

* With the two above, we now display uploaded images in the diff viewer,
and offer a few ways to show the differences between them. You can comment
on the image diff.

* The diff viewer has a cleaner look to it, and shows new information, such
as the complexity of a given change through new complexity graphs we've
added, which concisely show the relative numbers of replaces, inserts,
deletes, and percentage of the file changed.

* The diff viewer loads faster and it's faster to switch revisions or show
interdiffs, thanks to the new revision selector.

* Easy post-commit support was added for many types of repositories. You
can now click New Review Request, select the repository, the branch, and
click a commit, and that commit will go up for review. No need to use rbt
post with --revision-range.

* Comments and a review request's Description and Testing Done fields now
support Markdown. That means a comment can include an image, or
syntax-highlighted code samples, or what have you.

* Things load faster all around now. We've reduced the number of file
downloads for any given page considerably. We also get some speed benefits
from upgrading to Django 1.5.

* The UI is now completely localizable.


So we felt it was worth a version bump.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Publish changes without e-mail notification

2013-10-17 Thread Kim Gräsman
Hi Christian,

On Thu, Oct 17, 2013 at 9:31 PM, Christian Hammond chip...@chipx86.com wrote:

 This feature doesn't exist, though it does come up from time to time. If
 done right, I'd be okay taking a patch for it, but our plate's pretty full
 right now trying to get RB 2.0 ready to ship.

Good to hear!

I might try to come up with a patch, but I haven't really thought
about user experience. A new button seems a little brutal.

If you've thought about this before, have you come up with any ideas
for how this might be controlled?

Thanks,
- Kim

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.