Re: Question about customizing the diff view

2009-09-25 Thread Christian Hammond
Hi,

There is not, at least not within Review Board. You would have to write some
custom CSS rules and either modify the bundled stylesheets (which would be
overwritten on the next upgrade), or have people use a browser extension to
reference custom CSS rules (but that' sa lot of micro-management).

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Fri, Sep 25, 2009 at 8:31 AM, Hui Lin hui@bankofamerica.com wrote:


 I noticed that the lines in the diff view are automatically wrapped at
 the boundary of the browser windows.

 Is there a way to turn off the wrapping, and allow people to use
 horizontal scroll bar to control what is shown on the screen?
 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Question about customizing the diff view

2009-09-25 Thread Hui Lin

I think we have a solution. IE doesn't wrap the lines, but Firefox
does. Not sure which one is doing the right thing. At least we have a
choice.

On Sep 25, 2:39 pm, Christian Hammond chip...@chipx86.com wrote:
 Hi,

 There is not, at least not within Review Board. You would have to write some
 custom CSS rules and either modify the bundled stylesheets (which would be
 overwritten on the next upgrade), or have people use a browser extension to
 reference custom CSS rules (but that' sa lot of micro-management).

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.review-board.org
 VMware, Inc. -http://www.vmware.com

 On Fri, Sep 25, 2009 at 8:31 AM, Hui Lin hui@bankofamerica.com wrote:

  I noticed that the lines in the diff view are automatically wrapped at
  the boundary of the browser windows.

  Is there a way to turn off the wrapping, and allow people to use
  horizontal scroll bar to control what is shown on the screen?
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Question about customizing the diff view

2009-09-25 Thread Christian Hammond
Technically I believe IE is wrong here, but that works.

If you want to file a feature request for a preference to enable/disable
wrapping, we can discuss how we might go about it. I can't say right now
what we'll do with it, or how we'd implement it because, to be honest, this
is the first time we've had this request, but we may be able to figure out
something. Actually, most people request the opposite. They want us to make
IE do a better job of wrapping like Firefox :)

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Fri, Sep 25, 2009 at 2:21 PM, Hui Lin hui@bankofamerica.com wrote:


 I think we have a solution. IE doesn't wrap the lines, but Firefox
 does. Not sure which one is doing the right thing. At least we have a
 choice.

 On Sep 25, 2:39 pm, Christian Hammond chip...@chipx86.com wrote:
  Hi,
 
  There is not, at least not within Review Board. You would have to write
 some
  custom CSS rules and either modify the bundled stylesheets (which would
 be
  overwritten on the next upgrade), or have people use a browser extension
 to
  reference custom CSS rules (but that' sa lot of micro-management).
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.review-board.org
  VMware, Inc. -http://www.vmware.com
 
  On Fri, Sep 25, 2009 at 8:31 AM, Hui Lin hui@bankofamerica.com
 wrote:
 
   I noticed that the lines in the diff view are automatically wrapped at
   the boundary of the browser windows.
 
   Is there a way to turn off the wrapping, and allow people to use
   horizontal scroll bar to control what is shown on the screen?
 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---