Re: RB- Bug: Expand to header in diff viewer page is not coming for perl file

2013-08-23 Thread satish singh
Hi Christian, Thanks for helping me, the issue is resolved now. I didn't got file reviewboard/diffviewer/filetypes.py, but in diffviewer/diffutils.py I did added support for .thpl file and it looks to work now. '.thpl': [ re.compile(r'^\s*sub [A-Za-z0-9_]+'), ], '.thpl'

Re: RB- Bug: Expand to header in diff viewer page is not coming for perl file

2013-08-22 Thread satish singh
Hi Christian, I got the issue, actually we save a perl file with .thpl extension instead of .pl. I am attaching a screenshot where I have same file with .pl and .thpl extension, the Expand to function/class is working for file with .pl extension and it's not working for .thpl extension. Can

Re: RB- Bug: Expand to header in diff viewer page is not coming for perl file

2013-08-22 Thread Christian Hammond
Hi Satish, This would have to be modified in reviewboard/diffviewer/filetypes.py. What does a thpl file represent? I'm not familiar with that extension. If that's standard, it can be added to our mapping in a release. Christian -- Christian Hammond - chip...@chipx86.com Review Board -

Re: RB- Bug: Expand to header in diff viewer page is not coming for perl file

2013-08-21 Thread satish singh
Diff-viewer expansion to a function/class is not working for perl files, it working for rest of the file types, can anyone provide some pointers for this. Where to look for the issue ? Review board recently upgraded to 1.7.7.1 from 1.6.3 Thanks. On Wednesday, 21 August 2013 16:30:53 UTC+5:30,

Re: RB- Bug: Expand to header in diff viewer page is not coming for perl file

2013-08-21 Thread Christian Hammond
Can you provide a sample perl file that it does not work with that you think it should? Can you also take a screenshot? - Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Wed, Aug 21, 2013 at 5:36 AM,