Re: RBTools: rbt post -r ID changenum does not update the change list number in the review request
Issue 3855 entered. --Steve On Tuesday, April 21, 2015 at 3:22:32 PM UTC-7, David Trowbridge wrote: > > Would you mind filing a bug on our issue tracker? > > Thanks, > -David > > On Tue, Apr 21, 2015 at 2:35 PM Steve > > wrote: > >> Oops, sorry for forgetting that. >> >> Review Board 2.0.15 >> RBTools 0.7.2 >> >> --steve >> >> >> On Tuesday, April 21, 2015 at 2:22:17 PM UTC-7, David Trowbridge wrote: >> >>> What version of Review Board and RBTools are you running? >>> >>> -David >>> >>> On Tue, Apr 21, 2015 at 2:11 PM Steve wrote: >>> >> Looking further into this, it appears that when I run rbt post -r 3 CL commit_id for RR 3 gets updated with the new cl number, but changenum does not. The docs say that changenum is being deprecated in favor of commit_id, but from what I can see, it's the value in changenum that is being displayed in the review web page. Is it just me, or are others seeing the same behavior? --Steve On Monday, April 20, 2015 at 2:40:42 PM UTC-7, Steve wrote: > > I've noticed that when I post diffs from a new change list to an > existing review request using the -r option that the change list number > is > not updated in the review. I think the review request should update the > change list since that's the CL that reflects the current set of diffs, > but > there may be good reasons to not update it. So I guess my question is, > is > this a bug or a feature? > > Since we use perforce, one of the consequences of not updating it is > that when the change list is submitted, it won't get automatically > updated > in the review request with the actual submitted change list number, > because > the number in the review is not the one that was submitted. I hope that > wasn't as confusing as it sounds. > > Thanks > > > --Steve > > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. >>> >>> For more options, visit https://groups.google.com/d/optout. >>> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: RBTools: rbt post -r ID changenum does not update the change list number in the review request
Actually, maybe I should be testing out 2.5 anyway. I think I'll give that a try first. --steve On Wednesday, April 22, 2015 at 2:53:10 PM UTC-7, Steve wrote: > > Will do. Thanks! > > > On Tuesday, April 21, 2015 at 3:22:32 PM UTC-7, David Trowbridge wrote: >> >> Would you mind filing a bug on our issue tracker? >> >> Thanks, >> -David >> >> On Tue, Apr 21, 2015 at 2:35 PM Steve wrote: >> >>> Oops, sorry for forgetting that. >>> >>> Review Board 2.0.15 >>> RBTools 0.7.2 >>> >>> --steve >>> >>> >>> On Tuesday, April 21, 2015 at 2:22:17 PM UTC-7, David Trowbridge wrote: >>> What version of Review Board and RBTools are you running? -David On Tue, Apr 21, 2015 at 2:11 PM Steve wrote: >>> Looking further into this, it appears that when I run > > rbt post -r 3 CL > > commit_id for RR 3 gets updated with the new cl number, but changenum > does not. The docs say that changenum is being deprecated in favor of > commit_id, but from what I can see, it's the value in changenum that is > being displayed in the review web page. > > Is it just me, or are others seeing the same behavior? > > --Steve > > > On Monday, April 20, 2015 at 2:40:42 PM UTC-7, Steve wrote: >> >> I've noticed that when I post diffs from a new change list to an >> existing review request using the -r option that the change list number >> is >> not updated in the review. I think the review request should update the >> change list since that's the CL that reflects the current set of diffs, >> but >> there may be good reasons to not update it. So I guess my question is, >> is >> this a bug or a feature? >> >> Since we use perforce, one of the consequences of not updating it is >> that when the change list is submitted, it won't get automatically >> updated >> in the review request with the actual submitted change list number, >> because >> the number in the review is not the one that was submitted. I hope that >> wasn't as confusing as it sounds. >> >> Thanks >> >> >> --Steve >> >> -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google > Groups "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to reviewboard...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to reviewboard...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: RBTools: rbt post -r ID changenum does not update the change list number in the review request
Will do. Thanks! On Tuesday, April 21, 2015 at 3:22:32 PM UTC-7, David Trowbridge wrote: > > Would you mind filing a bug on our issue tracker? > > Thanks, > -David > > On Tue, Apr 21, 2015 at 2:35 PM Steve > > wrote: > >> Oops, sorry for forgetting that. >> >> Review Board 2.0.15 >> RBTools 0.7.2 >> >> --steve >> >> >> On Tuesday, April 21, 2015 at 2:22:17 PM UTC-7, David Trowbridge wrote: >> >>> What version of Review Board and RBTools are you running? >>> >>> -David >>> >>> On Tue, Apr 21, 2015 at 2:11 PM Steve wrote: >>> >> Looking further into this, it appears that when I run rbt post -r 3 CL commit_id for RR 3 gets updated with the new cl number, but changenum does not. The docs say that changenum is being deprecated in favor of commit_id, but from what I can see, it's the value in changenum that is being displayed in the review web page. Is it just me, or are others seeing the same behavior? --Steve On Monday, April 20, 2015 at 2:40:42 PM UTC-7, Steve wrote: > > I've noticed that when I post diffs from a new change list to an > existing review request using the -r option that the change list number > is > not updated in the review. I think the review request should update the > change list since that's the CL that reflects the current set of diffs, > but > there may be good reasons to not update it. So I guess my question is, > is > this a bug or a feature? > > Since we use perforce, one of the consequences of not updating it is > that when the change list is submitted, it won't get automatically > updated > in the review request with the actual submitted change list number, > because > the number in the review is not the one that was submitted. I hope that > wasn't as confusing as it sounds. > > Thanks > > > --Steve > > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. >>> >>> For more options, visit https://groups.google.com/d/optout. >>> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: RBTools: rbt post -r ID changenum does not update the change list number in the review request
Would you mind filing a bug on our issue tracker? Thanks, -David On Tue, Apr 21, 2015 at 2:35 PM Steve wrote: > Oops, sorry for forgetting that. > > Review Board 2.0.15 > RBTools 0.7.2 > > --steve > > > On Tuesday, April 21, 2015 at 2:22:17 PM UTC-7, David Trowbridge wrote: > >> What version of Review Board and RBTools are you running? >> >> -David >> >> On Tue, Apr 21, 2015 at 2:11 PM Steve wrote: >> > Looking further into this, it appears that when I run >>> >>> rbt post -r 3 CL >>> >>> commit_id for RR 3 gets updated with the new cl number, but changenum >>> does not. The docs say that changenum is being deprecated in favor of >>> commit_id, but from what I can see, it's the value in changenum that is >>> being displayed in the review web page. >>> >>> Is it just me, or are others seeing the same behavior? >>> >>> --Steve >>> >>> >>> On Monday, April 20, 2015 at 2:40:42 PM UTC-7, Steve wrote: I've noticed that when I post diffs from a new change list to an existing review request using the -r option that the change list number is not updated in the review. I think the review request should update the change list since that's the CL that reflects the current set of diffs, but there may be good reasons to not update it. So I guess my question is, is this a bug or a feature? Since we use perforce, one of the consequences of not updating it is that when the change list is submitted, it won't get automatically updated in the review request with the actual submitted change list number, because the number in the review is not the one that was submitted. I hope that wasn't as confusing as it sounds. Thanks --Steve -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> >> To unsubscribe from this group and stop receiving emails from it, send an >>> email to reviewboard...@googlegroups.com. >> >> >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: RBTools: rbt post -r ID changenum does not update the change list number in the review request
Oops, sorry for forgetting that. Review Board 2.0.15 RBTools 0.7.2 --steve On Tuesday, April 21, 2015 at 2:22:17 PM UTC-7, David Trowbridge wrote: > > What version of Review Board and RBTools are you running? > > -David > > On Tue, Apr 21, 2015 at 2:11 PM Steve > > wrote: > >> Looking further into this, it appears that when I run >> >> rbt post -r 3 CL >> >> commit_id for RR 3 gets updated with the new cl number, but changenum >> does not. The docs say that changenum is being deprecated in favor of >> commit_id, but from what I can see, it's the value in changenum that is >> being displayed in the review web page. >> >> Is it just me, or are others seeing the same behavior? >> >> --Steve >> >> >> On Monday, April 20, 2015 at 2:40:42 PM UTC-7, Steve wrote: >>> >>> I've noticed that when I post diffs from a new change list to an >>> existing review request using the -r option that the change list number is >>> not updated in the review. I think the review request should update the >>> change list since that's the CL that reflects the current set of diffs, but >>> there may be good reasons to not update it. So I guess my question is, is >>> this a bug or a feature? >>> >>> Since we use perforce, one of the consequences of not updating it is >>> that when the change list is submitted, it won't get automatically updated >>> in the review request with the actual submitted change list number, because >>> the number in the review is not the one that was submitted. I hope that >>> wasn't as confusing as it sounds. >>> >>> Thanks >>> >>> >>> --Steve >>> >>> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: RBTools: rbt post -r ID changenum does not update the change list number in the review request
What version of Review Board and RBTools are you running? -David On Tue, Apr 21, 2015 at 2:11 PM Steve wrote: > Looking further into this, it appears that when I run > > rbt post -r 3 CL > > commit_id for RR 3 gets updated with the new cl number, but changenum does > not. The docs say that changenum is being deprecated in favor of > commit_id, but from what I can see, it's the value in changenum that is > being displayed in the review web page. > > Is it just me, or are others seeing the same behavior? > > --Steve > > > On Monday, April 20, 2015 at 2:40:42 PM UTC-7, Steve wrote: >> >> I've noticed that when I post diffs from a new change list to an existing >> review request using the -r option that the change list number is not >> updated in the review. I think the review request should update the change >> list since that's the CL that reflects the current set of diffs, but there >> may be good reasons to not update it. So I guess my question is, is this a >> bug or a feature? >> >> Since we use perforce, one of the consequences of not updating it is that >> when the change list is submitted, it won't get automatically updated in >> the review request with the actual submitted change list number, because >> the number in the review is not the one that was submitted. I hope that >> wasn't as confusing as it sounds. >> >> Thanks >> >> >> --Steve >> >> -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: RBTools: rbt post -r ID changenum does not update the change list number in the review request
Looking further into this, it appears that when I run rbt post -r 3 CL commit_id for RR 3 gets updated with the new cl number, but changenum does not. The docs say that changenum is being deprecated in favor of commit_id, but from what I can see, it's the value in changenum that is being displayed in the review web page. Is it just me, or are others seeing the same behavior? --Steve On Monday, April 20, 2015 at 2:40:42 PM UTC-7, Steve wrote: > > I've noticed that when I post diffs from a new change list to an existing > review request using the -r option that the change list number is not > updated in the review. I think the review request should update the change > list since that's the CL that reflects the current set of diffs, but there > may be good reasons to not update it. So I guess my question is, is this a > bug or a feature? > > Since we use perforce, one of the consequences of not updating it is that > when the change list is submitted, it won't get automatically updated in > the review request with the actual submitted change list number, because > the number in the review is not the one that was submitted. I hope that > wasn't as confusing as it sounds. > > Thanks > > > --Steve > > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
