Re: RBtools and submitter issue and other questions

2015-04-30 Thread David Trowbridge
Can you clarify your use case? These two things shouldn't be easy to misuse.

-David
On Thu, Apr 30, 2015 at 11:31 AM Steve seide.al...@gmail.com wrote:

 Thanks David.  I think I've been using --username when I should be using
 --submit-as.  How does RB authenticate the --submit-as user?

 --Steve


 On Wednesday, April 29, 2015 at 5:02:49 PM UTC-7, David Trowbridge wrote:

 --username is for authenticating to the review board server. --submit-as
 is for impersonating another user (assuming the authenticated user has the
 right permissions) after authentication.

 The aforementioned scenario (having a post-commit hook or CI task) to
 post review requests on behalf of others is the use case for --submit-as.

 -David

 On Wed, Apr 29, 2015 at 3:42 PM Steve seide...@gmail.com wrote:

 Which makes me wonder - what is the difference between the --username and
 --submit-as options?

 --Steve


 On Tuesday, April 28, 2015 at 11:11:13 PM UTC-7, MoonWalker wrote:

 Found it :-). Seems like --submit-as username will do the trick

 On Wednesday, April 29, 2015 at 3:19:39 PM UTC+10, MoonWalker wrote:

 We are using Jenkins in our CI, and we have a job that takes care of
 doing some testing and if everything goes well a review will be posted in
 Reviewboard (2.0.15). Everything seems okay, the issue that I am facing is
 that I had to create a new user in RB called jenkins and the user that
 trigger the job is not able to modify the review because he was not the
 direct submitter. Is there any way to make a group capable to modify by
 default any review that targets the group?.

  --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups reviewboard group.

 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard...@googlegroups.com.


 For more options, visit https://groups.google.com/d/optout.

  --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: RBtools and submitter issue and other questions

2015-04-30 Thread Steve
Thanks David.  I think I've been using --username when I should be using 
--submit-as.  How does RB authenticate the --submit-as user?

--Steve

On Wednesday, April 29, 2015 at 5:02:49 PM UTC-7, David Trowbridge wrote:

 --username is for authenticating to the review board server. --submit-as 
 is for impersonating another user (assuming the authenticated user has the 
 right permissions) after authentication.

 The aforementioned scenario (having a post-commit hook or CI task) to post 
 review requests on behalf of others is the use case for --submit-as.

 -David
 On Wed, Apr 29, 2015 at 3:42 PM Steve seide...@gmail.com javascript: 
 wrote:

 Which makes me wonder - what is the difference between the --username and 
 --submit-as options?

 --Steve


 On Tuesday, April 28, 2015 at 11:11:13 PM UTC-7, MoonWalker wrote:

 Found it :-). Seems like --submit-as username will do the trick

 On Wednesday, April 29, 2015 at 3:19:39 PM UTC+10, MoonWalker wrote:

 We are using Jenkins in our CI, and we have a job that takes care of 
 doing some testing and if everything goes well a review will be posted in 
 Reviewboard (2.0.15). Everything seems okay, the issue that I am facing is 
 that I had to create a new user in RB called jenkins and the user that 
 trigger the job is not able to modify the review because he was not the 
 direct submitter. Is there any way to make a group capable to modify by 
 default any review that targets the group?.  

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: RBtools and submitter issue and other questions

2015-04-30 Thread Steve
We have a shared perforce account for doing merges called merge_master.  
Here's a typical workflow:

$ ssh sallan@mergehost
$ sudo su - merge_master
$ run_merge 

Once conflicts are resolved, we sometimes post for a review, but we want to 
do that as ourselves, not as merge_master

We've been doing that with --username

$ rbt post --username sallan CL

But that leaves a cookie behind in my name, so if the next person comes 
along and runs rbt without --username, they end up creating a review in my 
name, which is awkward. Maybe using --submit-as would be better?

--steve

On Thursday, April 30, 2015 at 11:35:32 AM UTC-7, David Trowbridge wrote:

 Can you clarify your use case? These two things shouldn't be easy to 
 misuse.

 -David
 On Thu, Apr 30, 2015 at 11:31 AM Steve seide...@gmail.com javascript: 
 wrote:

 Thanks David.  I think I've been using --username when I should be using 
 --submit-as.  How does RB authenticate the --submit-as user?

 --Steve


 On Wednesday, April 29, 2015 at 5:02:49 PM UTC-7, David Trowbridge wrote:

 --username is for authenticating to the review board server. --submit-as 
 is for impersonating another user (assuming the authenticated user has the 
 right permissions) after authentication.

 The aforementioned scenario (having a post-commit hook or CI task) to 
 post review requests on behalf of others is the use case for --submit-as.

 -David

 On Wed, Apr 29, 2015 at 3:42 PM Steve seide...@gmail.com wrote:

 Which makes me wonder - what is the difference between the --username and 
 --submit-as options?

 --Steve


 On Tuesday, April 28, 2015 at 11:11:13 PM UTC-7, MoonWalker wrote:

 Found it :-). Seems like --submit-as username will do the trick

 On Wednesday, April 29, 2015 at 3:19:39 PM UTC+10, MoonWalker wrote:

 We are using Jenkins in our CI, and we have a job that takes care of 
 doing some testing and if everything goes well a review will be posted 
 in 
 Reviewboard (2.0.15). Everything seems okay, the issue that I am facing 
 is 
 that I had to create a new user in RB called jenkins and the user that 
 trigger the job is not able to modify the review because he was not the 
 direct submitter. Is there any way to make a group capable to modify by 
 default any review that targets the group?.  

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.

 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.


 For more options, visit https://groups.google.com/d/optout.

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: RBtools and submitter issue and other questions

2015-04-30 Thread David Trowbridge
Yeah, might be. You could create a similar account in review board that has
the right permissions to post as other users, and then have that one
permanently logged in via the cookie.

-David

On Thu, Apr 30, 2015 at 1:11 PM Steve seide.al...@gmail.com wrote:

 We have a shared perforce account for doing merges called merge_master.
 Here's a typical workflow:

 $ ssh sallan@mergehost
 $ sudo su - merge_master
 $ run_merge 

 Once conflicts are resolved, we sometimes post for a review, but we want
 to do that as ourselves, not as merge_master

 We've been doing that with --username

 $ rbt post --username sallan CL

 But that leaves a cookie behind in my name, so if the next person comes
 along and runs rbt without --username, they end up creating a review in my
 name, which is awkward. Maybe using --submit-as would be better?


 --steve


 On Thursday, April 30, 2015 at 11:35:32 AM UTC-7, David Trowbridge wrote:

 Can you clarify your use case? These two things shouldn't be easy to
 misuse.

 -David

 On Thu, Apr 30, 2015 at 11:31 AM Steve seide...@gmail.com wrote:

 Thanks David.  I think I've been using --username when I should be using
 --submit-as.  How does RB authenticate the --submit-as user?

 --Steve


 On Wednesday, April 29, 2015 at 5:02:49 PM UTC-7, David Trowbridge wrote:

 --username is for authenticating to the review board server.
 --submit-as is for impersonating another user (assuming the authenticated
 user has the right permissions) after authentication.

 The aforementioned scenario (having a post-commit hook or CI task) to
 post review requests on behalf of others is the use case for --submit-as.

 -David

 On Wed, Apr 29, 2015 at 3:42 PM Steve seide...@gmail.com wrote:

 Which makes me wonder - what is the difference between the --username
 and --submit-as options?

 --Steve


 On Tuesday, April 28, 2015 at 11:11:13 PM UTC-7, MoonWalker wrote:

 Found it :-). Seems like --submit-as username will do the trick

 On Wednesday, April 29, 2015 at 3:19:39 PM UTC+10, MoonWalker wrote:

 We are using Jenkins in our CI, and we have a job that takes care of
 doing some testing and if everything goes well a review will be posted 
 in
 Reviewboard (2.0.15). Everything seems okay, the issue that I am facing 
 is
 that I had to create a new user in RB called jenkins and the user that
 trigger the job is not able to modify the review because he was not the
 direct submitter. Is there any way to make a group capable to modify by
 default any review that targets the group?.

  --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups reviewboard group.

 To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard...@googlegroups.com.


 For more options, visit https://groups.google.com/d/optout.

  --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

  --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: RBtools and submitter issue and other questions

2015-04-29 Thread MoonWalker
Found it :-). Seems like --submit-as username will do the trick

On Wednesday, April 29, 2015 at 3:19:39 PM UTC+10, MoonWalker wrote:

 We are using Jenkins in our CI, and we have a job that takes care of doing 
 some testing and if everything goes well a review will be posted in 
 Reviewboard (2.0.15). Everything seems okay, the issue that I am facing is 
 that I had to create a new user in RB called jenkins and the user that 
 trigger the job is not able to modify the review because he was not the 
 direct submitter. Is there any way to make a group capable to modify by 
 default any review that targets the group?.  


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: RBtools and submitter issue and other questions

2015-04-29 Thread David Trowbridge
--username is for authenticating to the review board server. --submit-as is
for impersonating another user (assuming the authenticated user has the
right permissions) after authentication.

The aforementioned scenario (having a post-commit hook or CI task) to post
review requests on behalf of others is the use case for --submit-as.

-David
On Wed, Apr 29, 2015 at 3:42 PM Steve seide.al...@gmail.com wrote:

 Which makes me wonder - what is the difference between the --username and
 --submit-as options?

 --Steve


 On Tuesday, April 28, 2015 at 11:11:13 PM UTC-7, MoonWalker wrote:

 Found it :-). Seems like --submit-as username will do the trick

 On Wednesday, April 29, 2015 at 3:19:39 PM UTC+10, MoonWalker wrote:

 We are using Jenkins in our CI, and we have a job that takes care of
 doing some testing and if everything goes well a review will be posted in
 Reviewboard (2.0.15). Everything seems okay, the issue that I am facing is
 that I had to create a new user in RB called jenkins and the user that
 trigger the job is not able to modify the review because he was not the
 direct submitter. Is there any way to make a group capable to modify by
 default any review that targets the group?.

  --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: RBtools and submitter issue and other questions

2015-04-29 Thread Steve
Which makes me wonder - what is the difference between the --username and 
--submit-as options?

--Steve

On Tuesday, April 28, 2015 at 11:11:13 PM UTC-7, MoonWalker wrote:

 Found it :-). Seems like --submit-as username will do the trick

 On Wednesday, April 29, 2015 at 3:19:39 PM UTC+10, MoonWalker wrote:

 We are using Jenkins in our CI, and we have a job that takes care of 
 doing some testing and if everything goes well a review will be posted in 
 Reviewboard (2.0.15). Everything seems okay, the issue that I am facing is 
 that I had to create a new user in RB called jenkins and the user that 
 trigger the job is not able to modify the review because he was not the 
 direct submitter. Is there any way to make a group capable to modify by 
 default any review that targets the group?.  



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: RBtools and submitter issue and other questions

2015-04-29 Thread MoonWalker
That is right. We are using a standard user Jenkins with default psw, but 
if we do not add  --submit-as  and the user that trigger the job, the user 
wont be able to modify the review, because the user that created such 
review is Jenkins

On Thursday, April 30, 2015 at 10:02:49 AM UTC+10, David Trowbridge wrote:

 --username is for authenticating to the review board server. --submit-as 
 is for impersonating another user (assuming the authenticated user has the 
 right permissions) after authentication.

 The aforementioned scenario (having a post-commit hook or CI task) to post 
 review requests on behalf of others is the use case for --submit-as.

 -David
 On Wed, Apr 29, 2015 at 3:42 PM Steve seide...@gmail.com javascript: 
 wrote:

 Which makes me wonder - what is the difference between the --username and 
 --submit-as options?

 --Steve


 On Tuesday, April 28, 2015 at 11:11:13 PM UTC-7, MoonWalker wrote:

 Found it :-). Seems like --submit-as username will do the trick

 On Wednesday, April 29, 2015 at 3:19:39 PM UTC+10, MoonWalker wrote:

 We are using Jenkins in our CI, and we have a job that takes care of 
 doing some testing and if everything goes well a review will be posted in 
 Reviewboard (2.0.15). Everything seems okay, the issue that I am facing is 
 that I had to create a new user in RB called jenkins and the user that 
 trigger the job is not able to modify the review because he was not the 
 direct submitter. Is there any way to make a group capable to modify by 
 default any review that targets the group?.  

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.