Yep, I think we can sneak this in. It's pretty low-risk.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com
On Tue, Jun 16, 2009 at 5:32 AM, Sebastien Douche wrote:
>
> On Tue, Jun 16, 2009 at 11:22, Christian
On Tue, Jun 16, 2009 at 11:22, Christian Hammond wrote:
> Sorry, I was wrong. You should see the Parent Diff field when choosing
> Upload Diff, but not New Review Request. This field was never added to
> templates/new_review_request.html. If you add it, it should work. It should
> be the "parent_d
Sorry, I was wrong. You should see the Parent Diff field when choosing
Upload Diff, but not New Review Request. This field was never added to
templates/new_review_request.html. If you add it, it should work. It should
be the "parent_diff_path" field. Copy/paste the "diff_path" and see if it
just wo
On Mon, Jun 15, 2009 at 20:35, Christian Hammond wrote:
>> I see: "Added support for parent diffs for Mercurial. Patch by Colin
>> Caughie." Why haven't you change initial screen (create a Hg review
>> request)? It's not possible to create a review request with parent
>> path.
>
> Pretty much beca
Yep, those are harmless. Has to do with the types of evoltuions we're
applying. It'd be nice to be able to disable those..
Glad it's otherwise working!
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com
On Tue,
Got a few rb-site upgrade warnings that I usually do not see:
sudo rb-site upgrade /var/www/reviewboard
Rebuilding directory structure
Updating database. This may take a while.
/var/lib/python-support/python2.6/MySQLdb/__init__.py:34:
DeprecationWarning: the sets module is deprecated
from sets
On Mon, Jun 15, 2009 at 8:07 AM, Sebastien Douche wrote:
>
> On Sun, Jun 14, 2009 at 03:43, Christian Hammond
> wrote:
>
> > I've just put out a release of 1.0 RC3, which should actually be the
> final
> > RC as long as nothing else blows up. I plan to release 1.0 next weekend.
>
> Upgrade (rc1->
On Sun, Jun 14, 2009 at 03:43, Christian Hammond wrote:
> I've just put out a release of 1.0 RC3, which should actually be the final
> RC as long as nothing else blows up. I plan to release 1.0 next weekend.
Upgrade (rc1->rc3) works fine.
> If people would test this release this week and make s
